From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Shuah Khan <shuahkh@osg.samsung.com>,
valentina.manea.m@gmail.com, shuah@kernel.org,
gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usbip: vhci_hcd: check rhport before using in vhci_hub_control()
Date: Fri, 6 Apr 2018 11:01:26 +0300 [thread overview]
Message-ID: <2bbe1e03-82e6-49c4-ca5b-30ada36a6e5a@cogentembedded.com> (raw)
In-Reply-To: <20180405223149.24643-1-shuahkh@osg.samsung.com>
Hello!
On 4/6/2018 1:31 AM, Shuah Khan wrote:
> Validate !rhport < 0 before using it to access port_status array.
Why '!'?
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/usb/usbip/vhci_hcd.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 20e3d4609583..d11f3f8dad40 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-04-06 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 22:31 Shuah Khan
2018-04-06 8:01 ` Sergei Shtylyov [this message]
2018-04-06 19:00 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bbe1e03-82e6-49c4-ca5b-30ada36a6e5a@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®