From: James Clark <james.clark@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Leo Yan <leo.yan@arm.com>, Suyash Mahar <smahar@meta.com>,
Amir Ayupov <aaupov@fb.com>, John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@arm.com>,
Leo Yan <leo.yan@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3 0/4] perf: cs-etm: HW_ID improvements
Date: Wed, 21 Oct 2026 09:42:24 +0100 [thread overview]
Message-ID: <2bc4b058-3a5b-4a9c-a469-eb8c93215594@linaro.org> (raw)
In-Reply-To: <20261002-james-cs-hw_id-output-failure-v3-0-1d8b6ef339c8@linaro.org>
On 02/10/2026 12:15, James Clark wrote:
> The driver might not always be able to write HW_IDs, but we don't need
> them for unformatted mode anyway, so fix that in commit ("perf cs-etm:
> Synthesize missing HW_ID mappings for raw trace").
>
> Include some other minor improvements encountered on the way to appease
> Sashiko, like properly freeing queues and ("perf: cs-etm: Respect
> --no-itrace option") makes debugging broken Coresight perf.data files
> easier.
>
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> Changes in v3:
> - Remove old b4 prerequisite metadata that's no longer relevant.
> - Link to v2: https://patch.msgid.link/20261002-james-cs-hw_id-output-failure-v2-0-7a194aa61173@linaro.org
>
> Changes in v2:
> - Drop driver changes and move to https://lore.kernel.org/linux-perf-users/20261001-james-cs-retry-hw_id-v1-0-4d45ab46cde7@linaro.org/T/#t
> - Don't process any HW_IDs for unformatted queues, just create decoders
> unconditionally with trace ID 1.
> - Use zfree() instead of etmq->decoder = NULL
> - Remove dependency on "[PATCH v2 00/14] perf cs-etm: Per-thread mode
> fixes and snapshot wrap support", it wasn't functionally dependant,
> just touching some of the same lines.
> - Link to v1: https://patch.msgid.link/20260821-james-cs-hw_id-output-failure-v1-0-9d532ddabcc3@linaro.org
>
> ---
> James Clark (3):
> perf: cs-etm: Don't add global v0 HW_IDs to unformatted queues
> perf cs-etm: Free partially created queues
> perf: cs-etm: Respect --no-itrace option
>
> Leo Yan (1):
> perf cs-etm: Synthesize missing HW_ID mappings for raw trace
>
> tools/perf/util/auxtrace.c | 2 +-
> tools/perf/util/auxtrace.h | 1 +
> tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 12 +-
> tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 2 +-
> tools/perf/util/cs-etm.c | 184 +++++++++++++++---------
> 5 files changed, 123 insertions(+), 78 deletions(-)
> ---
> base-commit: 705da5b15ab89ba97b11eedbe507c2fd83d31cb9
> change-id: 20260706-james-cs-hw_id-output-failure-1d06d042ef96
>
> Best regards,
> --
> James Clark <james.clark@linaro.org>
>
Hi Arnaldo,
Is it ok to take this one please, Leo has left his review tags.
Thanks
James
next prev parent reply other threads:[~2026-10-21 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 11:15 James Clark
2026-10-02 11:15 ` [PATCH v3 1/4] perf: cs-etm: Don't add global v0 HW_IDs to unformatted queues James Clark
2026-10-02 16:02 ` Leo Yan
2026-10-02 11:15 ` [PATCH v3 2/4] perf cs-etm: Free partially created queues James Clark
2026-10-02 11:15 ` [PATCH v3 3/4] perf cs-etm: Synthesize missing HW_ID mappings for raw trace James Clark
2026-10-02 17:14 ` Leo Yan
2026-10-05 8:33 ` James Clark
2026-10-02 11:15 ` [PATCH v3 4/4] perf: cs-etm: Respect --no-itrace option James Clark
2026-10-02 17:22 ` Leo Yan
2026-10-21 8:42 ` James Clark [this message]
2026-10-21 13:50 ` [PATCH v3 0/4] perf: cs-etm: HW_ID improvements Arnaldo Carvalho de Melo
2026-10-22 8:28 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bc4b058-3a5b-4a9c-a469-eb8c93215594@linaro.org \
--to=james.clark@linaro.org \
--cc=aaupov@fb.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=smahar@meta.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®