From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752120AbdHKGDC (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Aug 2017 02:03:02 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:55878 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751359AbdHKGDA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Aug 2017 02:03:00 -0400
Subject: Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA
 during probe
To: Robin Murphy <robin.murphy@arm.com>
Cc: Johan Hovold <johan@kernel.org>, Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alan Stern <stern@rowland.harvard.edu>,
        stable <stable@vger.kernel.org>,
        Sricharan R <sricharan@codeaurora.org>, Eric Anholt <eric@anholt.net>
References: <20170803155208.22165-1-johan@kernel.org>
 <20170805083807.GB14144@lst.de> <20170808180310.GF21342@localhost>
From: Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <2bc62b62-9021-2e55-ac2d-168d9ee70d19@i2se.com>
Date: Fri, 11 Aug 2017 08:02:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170808180310.GF21342@localhost>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: de-DE
X-Provags-ID: V03:K0:52IaxOTb5/3ycABDQI/w0Kr6VnFY3FHdhRpt88PEdP432VJi/OY
 NLZ4EeVTxHMGUC67Kij/aBLOQXP1hD4GtLZczobL5Ay0lK5paQn06AbILranCNGvCEphiW7
 30UsoCUYeJUYEGUcEwPzitOITjl0U2MvyyxmSDyZ/EmCOGOK37XQg7R7VUmYOUdj6KpSJ7l
 ChKLLY3Txxg7KUZi+bcLg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:6qHPWLHRcdU=:OOLDywNILTG1CAYqdTGa4I
 qfKMPEA0/5jUC9m3GQswEng52cuBOZdpe3WJjkJ5s5rtmfQduSLD7Zz+1+sDSkyppJuYRY7xT
 1m9Mth2sWk1zZA/mWAN/p/o9jo58qRHSq32A4CO3SkiVk5tT4SA4EA0FG+GF4iSpOcRqI24QD
 L3d3r5Qz5j1gwa76VTk2d4GY4aSyHSMkNVWEZDS8flV7BmpS2hZxzrOPD7PLBvBqMddijyOan
 ngxY6DTDOvyUiIVxmZxHVojNci4P9ZyAKVwI2KV6msXMjHSI7tgJGimY4jg9ND8GXIdn3Z/C9
 p5sf4SgD05QKkFPn0D067vu7Q1WfK1dEbwSHy3b7h9Ogkv/1/0muaeIb4K6ebq2iwDCRP6UUM
 JM4sfQs7bYHSGCdQI9njvQvIFm9O0GS21UZbaMfbCdohARr+qNcgBvSy6MZ5M4mnNSPfhNc2t
 OTjr3wYbLUlheYIejEpmyj0AuNx+dahdSUQuI+r5EOjcCdIOOezwwHICsq5NqldPDwMLrQaHn
 8E1ZbEvtKMSJv4aAPZq8bE45drmr1kay3LJowNHQxxoBEeE2hz5/aQLo1w59yftGnJL6H2PqK
 Xjevd1Fnli0nSpxW6Eqy2T5DnEZBOtCUhWEq7SjO07nQZfZx99aBhZyPV7VGn3Ou873OrPz8M
 tVAgskAeFxBGmJTQofjHopjd37q8NUnVR5LZknX651TxW/eIXhXmuSnHXcjz1bRminb0DLZUS
 HnGZOxcMx43xtjXozzkTRbqJ6xHfIM85eYuUxGpPDblbj+d8oTBBxevOCPs=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Robin,

Am 08.08.2017 um 20:03 schrieb Johan Hovold:
> On Sat, Aug 05, 2017 at 10:38:07AM +0200, Christoph Hellwig wrote:
>> I think the root problem is that the code added by
>> " of/acpi: Configure dma operations at probe time for platform/amba/pci bus
>> devices"
>>
>> is completely bogus and needs to be reverted.  We can't simply iterate
>> over all devices in the system and set up dma for them.  We'll need
>> to ask the firmware / OF what root port this applies to and only
>> apply it to those buses.
> I'm afraid I haven't had time to look any more at this, and now I'll be
> offline for the next two weeks.
>
> It sounded like Robin was working on a fix for the broken DMA-mask on
> RPI3 and that should address Hans's ethernet regression too even if we
> ultimately need to fix dma_configure() as well.

can you confirm that DMA-mask on RPI3 is broken? Why?

>
> Thanks,
> Johan