From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFC2C4167B for ; Fri, 1 Dec 2023 03:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376878AbjLAC7z (ORCPT ); Thu, 30 Nov 2023 21:59:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbjLAC7x (ORCPT ); Thu, 30 Nov 2023 21:59:53 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F2121711; Thu, 30 Nov 2023 18:59:59 -0800 (PST) Received: from dggpemd100001.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4ShHp650blzWj2q; Fri, 1 Dec 2023 10:59:10 +0800 (CST) Received: from [10.67.120.108] (10.67.120.108) by dggpemd100001.china.huawei.com (7.185.36.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.28; Fri, 1 Dec 2023 10:59:57 +0800 Message-ID: <2bc81cf1-5d94-c108-a107-a746daadb64d@huawei.com> Date: Fri, 1 Dec 2023 10:59:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH] scsi: libsas: Put the disk offline if all recovery actions fail Content-Language: en-CA From: yangxingui To: , , CC: , , , References: <20231130130118.14367-1-yangxingui@huawei.com> In-Reply-To: <20231130130118.14367-1-yangxingui@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.108] X-ClientProxiedBy: dggpemm100004.china.huawei.com (7.185.36.189) To dggpemd100001.china.huawei.com (7.185.36.94) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, please ignore this email, I need to update a new version, Thanks. On 2023/11/30 21:01, Xingui Yang wrote: > Currently, after all recovery actions in sas_eh_handle_sas_errors() fail > for sas disk, we just clear all IO, but the disk is still online. Perhaps > we should continue the subsequent recovery process for IO that cannot be > processed. If it still fails, the disk will be offline in > scsi_eh_ready_devs(). > > Signed-off-by: Xingui Yang > Signed-off-by: Bo Wu > --- > drivers/scsi/libsas/sas_scsi_host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c > index 9047cfcd1072..3f9b99fa1769 100644 > --- a/drivers/scsi/libsas/sas_scsi_host.c > +++ b/drivers/scsi/libsas/sas_scsi_host.c > @@ -637,8 +637,8 @@ static void sas_eh_handle_sas_errors(struct Scsi_Host *shost, struct list_head * > SAS_ADDR(task->dev->sas_addr), > cmd->device->lun); > > - sas_eh_finish_cmd(cmd); > - goto clear_q; > + list_move_tail(&cmd->eh_entry, work_q); > + goto out; > } > } > out: >