From: Chanwoo Choi <cw00.choi@samsung.com>
To: Lukasz Luba <l.luba@partner.samsung.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: b.zolnierkie@samsung.com, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, m.szyprowski@samsung.com,
s.nawrocki@samsung.com, mka@chromium.org, rostedt@goodmis.org,
mingo@redhat.com
Subject: Re: [PATCH v3 2/2] drivers: devfreq: add tracing for scheduling work
Date: Tue, 19 Feb 2019 09:28:20 +0900 [thread overview]
Message-ID: <2bc86822-9861-66d5-0a7e-d3d45494772c@samsung.com> (raw)
In-Reply-To: <1550514069-9237-3-git-send-email-l.luba@partner.samsung.com>
Hi Lukasz,
On 19. 2. 19. 오전 3:21, Lukasz Luba wrote:
> This patch add basic tracing of the devfreq workqueue and delayed work.
> It aims to capture changes of the polling intervals and device state.
>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> drivers/devfreq/devfreq.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 0ae3de7..660365a 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -29,6 +29,9 @@
> #include <linux/of.h>
> #include "governor.h"
>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/devfreq.h>
> +
> static struct class *devfreq_class;
>
> /*
> @@ -394,6 +397,8 @@ static void devfreq_monitor(struct work_struct *work)
> queue_delayed_work(devfreq_wq, &devfreq->work,
> msecs_to_jiffies(devfreq->profile->polling_ms));
> mutex_unlock(&devfreq->lock);
> +
> + trace_devfreq_monitor(devfreq);
> }
>
> /**
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-02-19 0:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190218182128eucas1p1bac39e9f11572143697b5cb854b2eb87@eucas1p1.samsung.com>
2019-02-18 18:21 ` [PATCH v3 0/2] tracing: drivers: devfreq: add basic trace mechanism Lukasz Luba
[not found] ` <CGME20190218182129eucas1p236fc8ccddd9a8cde25c15f7545276885@eucas1p2.samsung.com>
2019-02-18 18:21 ` [PATCH v3 1/2] trace: events: add devfreq trace event file Lukasz Luba
2019-02-19 0:25 ` Chanwoo Choi
[not found] ` <CGME20190218182129eucas1p1804530445570fc73af89ed46b9a448b9@eucas1p1.samsung.com>
2019-02-18 18:21 ` [PATCH v3 2/2] drivers: devfreq: add tracing for scheduling work Lukasz Luba
2019-02-19 0:28 ` Chanwoo Choi [this message]
[not found] ` <CGME20190218182129eucas1p236fc8ccddd9a8cde25c15f7545276885@epcms1p7>
2019-02-21 4:21 ` [PATCH v3 1/2] trace: events: add devfreq trace event file MyungJoo Ham
[not found] ` <CGME20190218182129eucas1p1804530445570fc73af89ed46b9a448b9@epcms1p1>
2019-02-21 4:26 ` [PATCH v3 2/2] drivers: devfreq: add tracing for scheduling work MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bc86822-9861-66d5-0a7e-d3d45494772c@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.luba@partner.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=myungjoo.ham@samsung.com \
--cc=rostedt@goodmis.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®