From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BFFE810CE for ; Wed, 27 Sep 2023 11:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231393AbjI0LQR (ORCPT ); Wed, 27 Sep 2023 07:16:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbjI0LQM (ORCPT ); Wed, 27 Sep 2023 07:16:12 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A34811AC for ; Wed, 27 Sep 2023 04:16:09 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-307d58b3efbso9186594f8f.0 for ; Wed, 27 Sep 2023 04:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695813368; x=1696418168; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7mEG755J6mA7UKW3osl1F7PnRsnYr6Mei3mYlrdVt/c=; b=XxO/tgFKBAK03VLSCtsN3WLByxXnELBKcTW/1QU9f3P9g+xYgldyKYy//XlkNChplX GTYCvc+K1XRM9ivLpJuCkwQQ2ho+INa+VEIwKSGV5piW5UnZwVGpFrwODbDztVzTVwva aODucYgBSHKIMzS2cev57MDfhtaeOB7xmzPMkB/TAxx2oJRMXA/vW3gXTjeNnWnqZMIR rydXFybmETz3zmnW5oTJNz/97aELiPXNPmTiFKAzMghdnSjs2J8fDuDSEIf49AlsDjxr QTc734Ep7Dn0nr/FyW7eIXa94xugTmYy61xzdht3EbPevi5B1wgKqHGQEtkFCJUiIaeb b5uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695813368; x=1696418168; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7mEG755J6mA7UKW3osl1F7PnRsnYr6Mei3mYlrdVt/c=; b=VM0tAVAEVictUFhxLgfUZrRquEagHGlvRsB7LuLpyYR0PRF5s2et9EYaReahO/cXA9 4Wch/rB5qJQ7Awy0QbqxFrYvqmZUz4di9YVPOyRzS1okewawcKrattqNACLaTUSw3tm6 l3KXVnNci6T1YynDqtL7U1AeEZQNl6csmjzdT8TKTYzG7LpG9bJzVMk5FP/1lMB5AVLl P7R8Ig3FeVIcgMZJjocRTDzKibM5siIEi7+/WEnHvH5GNebkqcVp1E1qcWRYYMQGSxnp 7jSh8/9F6KWGgtXiSisF2Rxb+UYZXMxq2FXe1/w3hYr/fPk2CnswkpfyRxs5d9oudUAX cZFw== X-Gm-Message-State: AOJu0YyPDLhV4nAG1fODDIGpp5bVCyl8I0sxt5Ox3pCVevkG2OIvxwQy BoJGKrQwtKzXVacc3GteK/GPKg== X-Google-Smtp-Source: AGHT+IHJJe5Jd54mOEoX3twENw0wNV3ryf0EENKQ1NcOMhVp0LkOGXOlDDAF3YkbdjSBAQNzUAyfig== X-Received: by 2002:a05:6000:1106:b0:31f:a16a:aecd with SMTP id z6-20020a056000110600b0031fa16aaecdmr1459762wrw.68.1695813367872; Wed, 27 Sep 2023 04:16:07 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id g7-20020a5d46c7000000b0031fbbe347e1sm16896539wrs.65.2023.09.27.04.16.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 04:16:07 -0700 (PDT) Message-ID: <2bd16a5b-260d-457d-98c5-bee030f05f00@linaro.org> Date: Wed, 27 Sep 2023 12:16:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm6375-pdx225: Add USBPHY regulators Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230927-topic-6375_stuff-v1-0-12243e36b45c@linaro.org> <20230927-topic-6375_stuff-v1-4-12243e36b45c@linaro.org> <8bbdf132-a007-4cb7-b842-a81de7c1629a@linaro.org> <354e5b45-468e-4fe6-9646-6b4d9596393a@linaro.org> From: Bryan O'Donoghue In-Reply-To: <354e5b45-468e-4fe6-9646-6b4d9596393a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/09/2023 12:05, Konrad Dybcio wrote: > On 27.09.2023 13:01, Bryan O'Donoghue wrote: >> On 27/09/2023 10:21, Konrad Dybcio wrote: >>> To make dtbs_check happy and the software more aware of what's going >>> on, describe the HSUSB PHY's regulators and tighten up VDDA_PLL to match. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>>   arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 7 +++++-- >>>   1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >>> index bbec7aee60be..0ce4fa8de8b0 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >>> +++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >>> @@ -243,8 +243,8 @@ pm6125_l6: l6 { >>>           }; >>>             pm6125_l7: l7 { >>> -            regulator-min-microvolt = <720000>; >>> -            regulator-max-microvolt = <1050000>; >>> +            regulator-min-microvolt = <880000>; >>> +            regulator-max-microvolt = <880000>; >> >> Where did the old values come from and why are the new values better ? >> >> Consider enumerating that in the commit log. > That's the pretty standard situation where: > > - downstream defines very loose ranges > - developer uses these very loose ranges as a guideline > - some hardware (often the exclusive user of that regulator) > has a hidden-ish request of a tighter range > - the developer realizes that and has to fix up the ranges > > Konrad If you got 72 and 105 from downstream, where did you get 88 from ? --- bod