From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758353AbdJMPQ0 (ORCPT ); Fri, 13 Oct 2017 11:16:26 -0400 Received: from mail-eopbgr10130.outbound.protection.outlook.com ([40.107.1.130]:40784 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758179AbdJMPQW (ORCPT ); Fri, 13 Oct 2017 11:16:22 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v2] stackdepot: ignore junk last entry in case of switch from user mode. To: Maninder Singh , akpm@linux-foundation.org, dvyukov@google.com, chris@chris-wilson.co.uk, kasan-dev@googlegroups.com, mark.rutland@arm.com Cc: linux-kernel@vger.kernel.org, pankaj.m@samsung.com, a.sahrawat@samsung.com, Vaneet Narang References: <1507725802-44574-1-git-send-email-maninder1.s@samsung.com> From: Andrey Ryabinin Message-ID: <2bd4d082-a62a-f956-0764-9962d8c05d89@virtuozzo.com> Date: Fri, 13 Oct 2017 18:19:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1507725802-44574-1-git-send-email-maninder1.s@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0202CA0012.eurprd02.prod.outlook.com (2603:10a6:3:8c::22) To VI1PR08MB2829.eurprd08.prod.outlook.com (2603:10a6:802:19::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d8339a1-3b07-43f5-8154-08d5124d5b26 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR08MB2829; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;3:n+e6bf0BjMRBduM/s7VTfXIy40Bp6sXRIRT6CeNWfso541lE/ZX/nsGqGdNsRVSJ420CntD6u7NZE89OPM55TvlvQtWAzR4LpTyWe2MjILz0NchBKHRypljPVX5QJ0SIuUBpQQ/x4+joxAXaPv4R02D+znaq4zcg/Y/mIkpiebM1ruGK3FS752aBECRYk7quXL280nomWLZX9rj40E3Uq2Ragp2BFCdgNyo4VKjP6njj8pBPs9TPqpgmDk3SUEhw;25:unOClvYUJB/4RMb7hTVhrwy2h/sDQLzZ3TdTD2sM6IfEWhRBGW6gVXFlIDchpQgekInOfhonnXnWCzLC9wTpU7743nxKUuA6MoqYejjkPfup/qGNh48eE5pRPmLKOs+KCJaDiHlOgY+aslDFQnys45lmzSLnsqIv//FVRRCHPAKdUFpLyIMC1rwAWIm28gLwO+Sk+GAMk2q738Dpl1Dz6xlmTs/Kwm+BNlpsxtZrFeAB2pv9if37jPwl9juoZ+oiWoPig6kyLN4kGGbdmNlFsoJHG+3MQ4TUiBoyFuQ0z+8x0pF1/nGSnIA4/YJrZ6sC4+Hs9K+OiYRE/0G5YioYiQ==;31:Sqr9buEsBFFDvsv73NsQ6Fz04zby/F9TXxdOP2XXz65CzFHysQgcW9chyFPar/vz+nMoeVZoDLOYwYNcTki1C7lUBpeJpgft2nIIeP2Mmru2XHFkkSVGxIpvG+JrA+6slgTxxOCzXRJrB/LvykCPkI65XJmm7G5DM2o1S4hXgXS8etz1igCUKQuGp/wdycZEyFKUBYXisa2q6QcdI2ohr7MNl2Cw3b2yddDivcDaqOo= X-MS-TrafficTypeDiagnostic: VI1PR08MB2829: X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;20:03My413sprrz+RtYCrv3HJBcoOjiwu9JpeDGM6TcI1HB/LephuQ8Yz10gUNuP6XlS00IWzQGRvIaLULJmfvVxM9LnK3wnUtTThJiQNghHD23vGxmQ1lBJ65rphjww7vYPkGNePTdYdIEoqPUUfSZ6nQR5qArcqqKbY3TJntJ+IbUPnn+B4DycyGCfGDlBIYxBD6JkirWcT0thFnYTx7A5wgobN2QMrBA44A8kUPkUaMcKfIm2TaDKn2nvXPUIo6PrAB4I0FpMUI2xd7uKmEfIdMMyOWVAqzCHKxzq00UZVkwGM3buGPMnjEM1yFtzYxxGRhqLzlwvPIWU6FzirYWD0vq03X0AmLz0e5lht9bivAcTUhxFSZcOp4m5se4LhKgRx+SYKCnObY6OKfV16cXtgpp6W8q8cmzizpcT6+CU6o=;4:xzzpuaeS/MluybtI8ovKFX2rrzsjFSOrnTk7y8kwiWvO8Z2M5pGsy57IuROlae6Cq7rZNsnO/5IfF3HhsgPlFS+jFCWOBAFLzAkuBebGZGu6vicWyr97CXFKZJMlCaEYgQ2wQqIzndCI52seA3P1PY0BNNf+h8BbVPKZMjtvP4Sk/3BgDDLq4+lImsLF89fKFQx/IEfgjPc71Y9xdApCO0HInm+c4xyt+Soh1DDN3fc7Jp1b/6qApvMM1exIVxWc X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR08MB2829;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR08MB2829; X-Forefront-PRVS: 04599F3534 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(376002)(346002)(377454003)(199003)(189002)(24454002)(97736004)(23676002)(65826007)(65806001)(47776003)(36756003)(316002)(65956001)(5660300001)(66066001)(6486002)(189998001)(6246003)(3846002)(68736007)(478600001)(7416002)(58126008)(229853002)(16526018)(25786009)(16576012)(54356999)(76176999)(77096006)(6116002)(31696002)(230700001)(50986999)(83506001)(101416001)(305945005)(2906002)(8676002)(53546010)(6666003)(2950100002)(81156014)(81166006)(8936002)(50466002)(53936002)(31686004)(64126003)(105586002)(4326008)(33646002)(106356001)(7736002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB2829;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4TUIyODI5OzIzOnRpdTFGM01ZbUZVS3JESXh5dFErSEhSQUZh?= =?utf-8?B?UVY2SngvZWJSZ1dLT3BWeUxUbm9ZcTFPQy9PMU9HdlVOUUhwM2NDcENVZTZ4?= =?utf-8?B?ZCtzVjA4Sk5IeS8wY0RTWE5KVGRrV3JhLytIVTBQT0tueFdWSVFLVUNkSzk4?= =?utf-8?B?amRYejFTQ2lBNmdHeVpFN290K05aUklQVkRzSEVEWlF2SCswaU5YcVJnOUdp?= =?utf-8?B?MkhWMGJROEEzZmppaVJSd212eGZ4cE04YlpUb2ZkSVBGZXBBMk1vSFVqbDA1?= =?utf-8?B?b0RYUjRiOEhydlJsc3RHb29PZUkvU2FRYXJYN2lSVWNKa0VJRzVta2FScVRs?= =?utf-8?B?VXlWVG5KclV6a2oxZktoTm1TTitCYjR5NGdUbFplaEhWQ2JjbVNNSVJlUG1T?= =?utf-8?B?MWFJRGFzZms3NWFKb25UWWpOcGFyOGxiUTNENng1ZTZlSFVxTnAvZmFCRldD?= =?utf-8?B?OThLQms1TmxiKzZKTHZpajRSdThOU3B3bnhiRlNnZkZqMFNGTmFlOWxzVlpa?= =?utf-8?B?cHFKZGxrKzloL3RYQ0VWeFZnNTZaNkVaTmkzaloveFZBYUE5NmkyVjJWK1RJ?= =?utf-8?B?aEtQR2pRcU5PZlYvUnMvMVFWL3Vlc2czSDBodHdIdnlDZHhZQ1FCME5pYkh2?= =?utf-8?B?eWQ1WEk4Z1AxSTB5aTBOa2pvaXhHUEgybnZVUm9oUnBIM0lPaDhzdkJ5cGsv?= =?utf-8?B?YUlCSFlYL0loTzNXUldqMWtXandTTk1ETDIvdUkvZU9JUFBoUGVWUkx4SHNw?= =?utf-8?B?bWZIVHNMNGNFdGtNUW1JSmJzd2k0L1BEeFdRL3FYYmFyUDJyR0czQ2lMd1NU?= =?utf-8?B?Y2FwcjBaNFpPdmdsMDRyR294ZHM2MFAvRlRob2pCNjVSR3lGT000a2sxQWY5?= =?utf-8?B?dzdjNXB3QUlHNWpkeExsMnFER3VrTkMrSlFIcm12VXM1OU9ySkdMMjZUMXor?= =?utf-8?B?eFcrOVF2TWd6R2Q2VEI0ZTN4K0tYUkRuSVEreDd4Yk90SWF5UUR2K1MzT0pL?= =?utf-8?B?UlZNVW9SWjZrb3ZJMU1Dc0dsZUFseW5IQlNSTFJtOUF3Mkl6THlqeUVyajNM?= =?utf-8?B?MnhlblBGY3dFSWZnU1RLZzFPWnAzdmJQWVkwOENwQitJaTlkWlVoYWlMc1kv?= =?utf-8?B?SzRPVHVyZUVlc2k1TXdwNGVVNlJXUUFRVU96YkVtcmg3Zjg2TG53NUk5WFZo?= =?utf-8?B?MnlSMUxoazhKNS8wbnhBa3EzNkRCSUo4b3VjeUVSZ3RsNXh0bWJ4T2daTnZt?= =?utf-8?B?ZWtCVWtacUxqSGtVT2oweEtSbGpoVzZYOUM2dHM0dnh6UHVlY3d3UFVXWmtY?= =?utf-8?B?MWEwdHErQmRpdnNYMDhBODdFdTZ5bExiL3UzWjlzc2FTeGJRZ2x2bld2WnFJ?= =?utf-8?B?bkc5ZCt4WjZ6d3BFb1FlMkdUL2ZXbmNzanlLcW13M0h5RmQ0NGttR1p4b0pr?= =?utf-8?B?ZjgwWHdFUWUwY09XWXlBZmQ3VjVEZ01ZOFd4NUZJOGxhN3B6TTFxZ1gydjYz?= =?utf-8?B?S0VtUDVHSUllYW1IR1hDZnZ2Rm1RaDg5eXEzSDlpNmhvdUg1UlladktNZEpQ?= =?utf-8?B?YUs2L3VKcXZCaUovY2hCVlB5VUZ6bUZYZmJkVVJoVGxHMDZhd0F1eGcyVExq?= =?utf-8?B?TXI0STJId2U5bWNEUWF5RzZtRFN1Z2VKcGJYUVlJVHhZZFJMQ1ZIMTh0dHV1?= =?utf-8?B?dm9NTUZMWjJpWXRQcXlBTVRpT21SZlBEajNhR3V0SnR5ZWdReTRLd0YyZEZ4?= =?utf-8?B?YmdiSGxIeTRrMXRhUGkwZ0lBc1NVTDFCcnZhdWtsZ1JNRlhZVWdCNXhwc0lQ?= =?utf-8?Q?4vikQjHgsOUtQ?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;6:hqWAZupMNbaI0TH1hwQP815fDI/XtX+4Y4t6ooROcaOWAgDs4tiWw4ghZfS+KmDbvOdSqrvoSh7BuEdPnc+Ycsq8QrTGxeiThb5JWqTKBazgrhHsQ5UXjPk8tt+zxKg660bVv3DaIMp8sNAs24UCQVeZ0JGWHQcfCs4zSMCH1Z1Se32/R4rSqtSw3xZuQ2Wa5ZOJYBOZcFHgbL50fZKWrUg9FG4nyHRd0ZzwzEZZlKrWWOEdrsILNxus8RZZ8FOci0UoVyd8JH/omEAAhH9EHhS9nUL4jiAk0aJbX6v80uXEADt/Y4LYM7g9pdT7eASDZAw9qgPae+nR3f0vJTxB3Q==;5:CeSrQmLXzrKl7ewlSjwckYCOrFpqKZlAbbVqlG7cgq6P93yqrg7Q1qTsImmgACrD8V2+15ewN0naJhlzYBmv9PWCA3fjTCbjAQsH5WMBWl5qozGDYyEu/rwch0wNO5bDsnG1tuCxcMxu0w5Y2haYeQ==;24:OGZa6B1sEFdTxCohMGdM7FN9+EWMh0e8zj2Uif3SSLfWfItZX3uRv2uyo7E40e/+ZHpOBjqrCSYvsirS9Jm9zyzsld0zrDejjEpgXegHZjQ=;7:I/84InbWmgp0zJJee6PiMx8pnp7RRlOho7OJjPPjn45x90Vpfnm/Am+909oQfPZBJFOMceTiSxZcnpAAfOdBRtZEcIfOQsscDQF6cv3YehkGhXSzM6XRJubUbvXr1Id3/OwgKo/MqI76PO+fjiFGFa+M0Gpz/bEsud6z8kMShNdJxeDFpCnsP0Ki7zCUgCqtGdpl8vLkyUIXgn18P8DshIvd69Tr5wRVR65LtzIsTXA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;20:LVX5OH2su4zmZtmAU/HjfBxfrnUcC7cO1yYyTSBxxroCmfV663ICjjOar0K5eCu+a8kNMR1XrPPfmCVeIqUZIJXSHu8KfZG5Z0DfS7SLGaknn2pZ5yhOUKKtdoR3zdRIPrJm9QCUSz61k9uezstBMbI+8EPq+XFikaj5L5YFp98= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 15:16:18.3200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2829 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2017 03:43 PM, Maninder Singh wrote: > Issue observed on ARM. > > Whenever there is switch from user mode, we end up with invalid last entry > with some user space address as below:- > > save_stack+0x40/0xec > __set_page_owner+0x2c/0x64 > .... > .... > __handle_domain_irq+0x9c/0x130 > gic_handle_irq+0x40/0x80 > __irq_usr+0x4c/0x60 > 0xb6507818 > Sounds like an ARM issue to me. ... > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index f87d138..a045748 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -214,6 +214,13 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace, > if (unlikely(trace->nr_entries == 0)) > goto fast_exit; > > + /* > + * Ignore last entry if it belongs to user space And if it belongs to module too. NACK. > + * in case of switch from user mode. > + */ > + if (!kernel_text_address(trace->entries[trace->nr_entries - 1])) > + trace->nr_entries--; > + > hash = hash_stack(trace->entries, trace->nr_entries); > bucket = &stack_table[hash & STACK_HASH_MASK]; > >