From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423927AbcFIIJr (ORCPT ); Thu, 9 Jun 2016 04:09:47 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:38839 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161123AbcFIIJk (ORCPT ); Thu, 9 Jun 2016 04:09:40 -0400 Subject: Re: [RFC PATCH 00/15] Exynos big-endian fixes To: Matthew Leach , Krzysztof Kozlowski References: <20160608183110.13851-1-matthew@mattleach.net> Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Ben Dooks Organization: Codethink Limited. Message-ID: <2bd53bbc-b8de-e616-b4ee-412330910a34@codethink.co.uk> Date: Thu, 9 Jun 2016 09:09:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160608183110.13851-1-matthew@mattleach.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06/16 19:30, Matthew Leach wrote: > Hi all, > > I've been working with Ben Dooks to get a big-endian kernel working on > my Exynos 4412 board. Primarily this series consists of: > > - Replacing the __raw_{read,write}l accessors, which aren't > endian-clean, with their respective {read,write}l_relaxed versions > across various drivers. > > - Adding endian-aware {set,clear}_bit functions to the Exynos serial > driver as the __{set,clear}_bit() functions aren't endian-clean. > > - Make the low-level Exynos debug printing macros endian-clean. > > There may well be other things that are broken under BE that we've not > tested but this series should be enough to allow a board to boot > user-space to a login prompt. The only nit is the use of "be", it would be nicer to either use BE8 consistently, or go for "big endian". -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius