From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2041.outbound.protection.outlook.com [40.107.100.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F5B114D430 for ; Wed, 18 Dec 2024 06:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.41 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734503371; cv=fail; b=P1U4XQlEsAhLY5+fziA3UIWOXb/gamflG7rUZak/uFbNBYJL2US7ufCUbVLj/qxspukWOK2lEJSMjf/cvg6to4/QxlshzbBY8fQdYRLBj5XJKYC/kcODny+GzH9ONbIqGFj6i92Xe9C8f94Jkn9wYEVh+kxog4RaYl1oB/U9VNQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734503371; c=relaxed/simple; bh=kZLP5jkOgguCEALLmIG8wZCUrUtQUfwDuh6ugIly7AQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=qMk37ncLK2bMxYnJViqEKi8Tg84yMNSt6oe0RBKL8Uft29ykuofpqvPQzO+1rxz7p0GVsOgA4U75XsWYUeZgNCHmIzyZvluDEwrSdjZd5VDAqYkujF131oQRqiPNHV50sEcChv+Akxyx+Um/eh6hDAJ+zer/F3UrDY7MptwDU58= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=jgJGVSaU; arc=fail smtp.client-ip=40.107.100.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="jgJGVSaU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DeOvhyW9T1ebuL0x4pU/fwOMXmjbBnFqTN/anlLKE7GO6B9eCQsgzUFFg2jkRAddl3t0aBf74wG/DSHFRmmsMl/N9KcPgUwuj/0ayCbOXk1aLaDsGbUBqmzdUik5Q45LMUJqDOLhfGl8Vn1uPeUxtfGn3XguY4fEAAduOFLFw96kEoqw63WJ72GndP4i3Y7w+0l9vagSXSG4IRxykNYfP/No8Yy1mKiUixfkrPgzY8/PG52IaQReCU+kQEeVW+ag6lAjdNpGIbubJnow2GFT0eztKSwD7xrM4/w9e+gfl9UM6qy6lw36HExiJNv43AVGyYf87zAVk85AYV/aZOYi7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6GmqDeVl7g/pZ2j9MGhzogyZSad9teclUrXeDA5g//M=; b=BBrLmhykunaxHuPQ4gjwqja44g+rlvDZ1PdMZtctzErJ/Khk+gqbWuFbJTZTwIUgOPASgcUWlpwwxCWWUsRnvSxylvWQ+VL3qgQ5U/brH2nmgjvmQYCNbDBRFnavfmgTSbAlTSs9PyMsUtZW7d8t7gj0R+iG9HDHJmUgLDD77QOBK37nfAg4W0w4EisM/0uyK2tNDZfTz1ljDTXK1v8Wz2GRTeHvOuocJe0seilnQBrZ/k/S9w8JYHOF5qum5hllG60f7NDD1GcF7xyhJqTZABrFpZn6X1tn3sDAGnRskEo+0d/PB7R/ci9cy45IzS/SoybO5A2dqli79YCvQHLDEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bytedance.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6GmqDeVl7g/pZ2j9MGhzogyZSad9teclUrXeDA5g//M=; b=jgJGVSaUSMoc5S8fypj364g2z4d7b4bA6SN7wagk0kAZMjfXgr0yHU/G3hkLxHoua15EjMILvszmSvzrp7L9xKkxVMBs2BdcIosMSix0AcdjtUc3PtsH1EqJJ7Hwgi5YwK19hMGxNEGF2aOlAbxOsPWeNpFh8qABjNpCbru0J1k= Received: from BN6PR17CA0034.namprd17.prod.outlook.com (2603:10b6:405:75::23) by DS7PR12MB9502.namprd12.prod.outlook.com (2603:10b6:8:250::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.13; Wed, 18 Dec 2024 06:29:25 +0000 Received: from BL02EPF0001A0F9.namprd03.prod.outlook.com (2603:10b6:405:75:cafe::3f) by BN6PR17CA0034.outlook.office365.com (2603:10b6:405:75::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.22 via Frontend Transport; Wed, 18 Dec 2024 06:29:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A0F9.mail.protection.outlook.com (10.167.242.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8251.15 via Frontend Transport; Wed, 18 Dec 2024 06:29:24 +0000 Received: from [10.136.34.246] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 18 Dec 2024 00:29:21 -0600 Message-ID: <2bda56c3-727f-4899-8d88-fd83f11b3e76@amd.com> Date: Wed, 18 Dec 2024 11:59:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] sched/fair: Remove unused task_numa_migrate return value To: Chuyi Zhou , , , , , , , , , CC: , References: <20241216122357.1276382-1-zhouchuyi@bytedance.com> <20241216122357.1276382-2-zhouchuyi@bytedance.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20241216122357.1276382-2-zhouchuyi@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0F9:EE_|DS7PR12MB9502:EE_ X-MS-Office365-Filtering-Correlation-Id: 81180ad7-3cf2-46a7-a4dc-08dd1f2d50fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|7416014|376014|7053199007|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VTVETmpPYUVEVUJ5SXAweHdkcVI0c2VSQm4rWGU5RG12QXNYbHk4WDUrZ2Yz?= =?utf-8?B?TkFnb1RxSjFzVE8vbjhkclZpVVh5Zm02UXEzLzRKT2lvb2JWL2lLaW40T2lF?= =?utf-8?B?SU1wcTdpTFZoQzRaZ0ZjYktldmpVMUpMR0Z0MkZHenRaRndDZ2JPbjg1TjNN?= =?utf-8?B?N3liRnB6dXRIZWd4TzQ0WWdXRUFEVEMzclBrbGdsMGJBcXBYblFNYldsY3ND?= =?utf-8?B?WmMzL3RwdmNLbDRrTTdmNjdvM282aWthNWNDeUFhNUlWNW50SDJYZEo5bXk2?= =?utf-8?B?enlsOVpTeEJzZkszblNkU1RTUnIrSjc5cGJzQXJIaTFwVDRzTk5ocHh5UnQ4?= =?utf-8?B?MW83SW4xd3VKWXhQNENmYWhpTzJpNU5ncG1FUnVSMUpqOFpqNWJhSnREbTNP?= =?utf-8?B?SEd6MkVXeis0Sm9wRGN5Q05FVnRTbmZiYmxWcGZJTHp2aFNZT21NbmQ3RU54?= =?utf-8?B?Q3R4NzBmQXNtUTVQeUZIa2dKWjQ5YlJxMVc0WTdsZEcxcTl1dVBuTjE2eUZ5?= =?utf-8?B?QSt1SWZNRnNJNzhZUWpVRFFUay9Pd0wzb1FBNFQ0dFpSN0hJOW92WSs0TG9Z?= =?utf-8?B?TWdERnh5U1R3UE5oQ3JXWkdOSE1xN2I4enJtRkF5RUlRemF0eER4a080YWZB?= =?utf-8?B?RWtGYU1EZDVid2MvSTMxUHJWdWpLdU13ZTlydVVFVWJFTzEvK0hvZGFobXVK?= =?utf-8?B?V2pOR1NsVGNmZUhWaGdHOFB2d0prZGFKZ1Nod0JLNnl4OGNsTW4wNmNHMjll?= =?utf-8?B?ZWRDTXdaZmJxdEZCWDJvTlo3ZnRBTUhhNzRNT2NEZWxNUXZhQ3NuTTZMRFlV?= =?utf-8?B?ZlViWmhWL0VsczZEc0d1enQ2c0FzV2dFMUROVmNoVkFqVHNrVmVqNldnTWZZ?= =?utf-8?B?dUpEZ2hLY2ZQT2JreThzZ0FEYkxnSmgyYVdjVnJscDhwbWpuL1owSjhsQXhs?= =?utf-8?B?aVlQTHF5VEk4NEwyNExaUURBQ0E2WUhaN2N6d0E5Tm9SeEtibndLak5PSi9U?= =?utf-8?B?SFZmNGtBQmRnbXVtaWdqazYwdXdSN09JRERaZHpDOUl3M3N3MTFQV01iTklL?= =?utf-8?B?R0RlSWxDZ2NIaUQwQ1NrSnQyNjE5cS9xbWtzWlRTeWl4TlpoelFFY01PN2xW?= =?utf-8?B?REp5WjJaTGpjRCtRK3lveFp1bkRBSEwzMm50SnZ5bTlndDJyVnhvd2p1ejRk?= =?utf-8?B?bWZJWkVsMXF4b2docGdjYW55YTZqSzNQclBydklIR3ZUQ0dvS0dhaVhDUEFT?= =?utf-8?B?L1dOb0hLWlA2V2FjeXVxaDIycTZHNm5sK3VlUVBzTFRLT2Z3RUNudkFQK0pM?= =?utf-8?B?MFkwTUMyN3h2d1ZWaWxhYmM1ZWxDQ25rRExuWUdjNlZxR2U5NzYxeDVMR2Ra?= =?utf-8?B?dWVzK3hPOEIxZ3hodWI5V2RzbU1LSS9yOTZpYU1aS0NlNy94cFJ3cGl6K0Fp?= =?utf-8?B?bzE0MU42aEV6WUZZY1pWY1FvR0ZWV2lXM3VDK2N5TVhrZ0d1cThYa0JvcnNo?= =?utf-8?B?aGlOa3NSTzY1UTlMZ1d4RGtWc1ZLWUNPb0k2UW9ZYmdlNEFDY3RUZHRvdWc2?= =?utf-8?B?OUNYYTJsb2JxVU5GQUtKMTdvNDI4eTJoV2Vacy94Z1R6dUJWQkRMb2JQV29N?= =?utf-8?B?anFHUFMrSG9ob25iRlh3SHg0VTNsWWtxK2xkMlhXbG1QTDRuRWxGRGFhWXpF?= =?utf-8?B?bjBldTBhNFpzSG5qeGlZR0hjNm1RVWd3RG5RWG5BMG8wanoyUUlBNWR4U3dT?= =?utf-8?B?SXpLTitBMlhDL3g3ZUVSWncrT21mWWRySkpKbTNzQ3RRYWZwaUVrR0l6UnNR?= =?utf-8?B?MDB2b0M4V3VTZ0tvUDlTb29tblJQNEZHUVY0c2xkNndreVhzemlkQ01HK1Ji?= =?utf-8?B?UmwwRnp0MUNCQzhmL0dNdXA3MkVOemZSS2FzRjF6Z05zUDBTNXZCWG1YVTNn?= =?utf-8?B?TWNUT1VNNklpdk1YZ0tOak4xR0VIZHk5OXl5MGdPVVFXdTdTZ2l2bURLYWpl?= =?utf-8?B?WXErSi9MazNTaUlXdmZHd3hHcEZ0S0J6UFgxNmNxb2g5ME1zZVpSdlJ4eVQw?= =?utf-8?Q?uAKuQ9?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(7416014)(376014)(7053199007)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 06:29:24.8708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 81180ad7-3cf2-46a7-a4dc-08dd1f2d50fe X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0F9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9502 Hello Chuyi, On 12/16/2024 5:53 PM, Chuyi Zhou wrote: > The return value of task_numa_migrate is unused, remove it. > > Signed-off-by: Chuyi Zhou Feel free to include: Reviewed-by: K Prateek Nayak If anyone cares for the history, initial NUMA Balancing implementation used the return value of task_numa_migrate() to retry NUMA Balancing in commit 6b9a7460b6ba ("sched/numa: Retry migration of tasks to CPU on a preferred node") however in the same series[1], Mel also included an optimization from Rik which retried NUMA Balancing periodically irrespective the return value from task_numa_migrate() in commit 2739d3eef3a9 ("sched/numa: Retry task_numa_migrate() periodically") [1] https://lore.kernel.org/all/1381141781-10992-34-git-send-email-mgorman@suse.de/ -- Thanks and Regards, Prateek > --- > kernel/sched/fair.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d5127d9beaea..f544012b9320 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -2486,7 +2486,7 @@ static void task_numa_find_cpu(struct task_numa_env *env, > } > } > > -static int task_numa_migrate(struct task_struct *p) > +static void task_numa_migrate(struct task_struct *p) > { > struct task_numa_env env = { > .p = p, > @@ -2531,7 +2531,7 @@ static int task_numa_migrate(struct task_struct *p) > */ > if (unlikely(!sd)) { > sched_setnuma(p, task_node(p)); > - return -EINVAL; > + return; > } > > env.dst_nid = p->numa_preferred_nid; > @@ -2600,7 +2600,7 @@ static int task_numa_migrate(struct task_struct *p) > /* No better CPU than the current one was found. */ > if (env.best_cpu == -1) { > trace_sched_stick_numa(p, env.src_cpu, NULL, -1); > - return -EAGAIN; > + return; > } > > best_rq = cpu_rq(env.best_cpu); > @@ -2609,7 +2609,7 @@ static int task_numa_migrate(struct task_struct *p) > WRITE_ONCE(best_rq->numa_migrate_on, 0); > if (ret != 0) > trace_sched_stick_numa(p, env.src_cpu, NULL, env.best_cpu); > - return ret; > + return; > } > > ret = migrate_swap(p, env.best_task, env.best_cpu, env.src_cpu); > @@ -2618,7 +2618,6 @@ static int task_numa_migrate(struct task_struct *p) > if (ret != 0) > trace_sched_stick_numa(p, env.src_cpu, env.best_task, env.best_cpu); > put_task_struct(env.best_task); > - return ret; > } > > /* Attempt to migrate a task to a CPU on the preferred node. */