From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F419EC48BD5 for ; Tue, 25 Jun 2019 16:52:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE8022064A for ; Tue, 25 Jun 2019 16:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727786AbfFYQw2 (ORCPT ); Tue, 25 Jun 2019 12:52:28 -0400 Received: from smtprelay0164.hostedemail.com ([216.40.44.164]:50128 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726599AbfFYQw2 (ORCPT ); Tue, 25 Jun 2019 12:52:28 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 4C3435000; Tue, 25 Jun 2019 16:52:26 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: tramp21_4f3996ed0ab50 X-Filterd-Recvd-Size: 2131 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 25 Jun 2019 16:52:24 +0000 (UTC) Message-ID: <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs From: Joe Perches To: "Gustavo A. R. Silva" , Jingoo Han , Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kees Cook , Masahiro Yamada , Michal Marek , linux-kbuild Date: Tue, 25 Jun 2019 09:52:23 -0700 In-Reply-To: <20190625160103.GA13133@embeddedor> References: <20190625160103.GA13133@embeddedor> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. [] > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. Just enable the thing already. If you stopped trying to do it all yourself, others will help resolve any new build warnings. For instance: a build of -next x86/64 defconfig has 2. nbd. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 5102b2bbd224..df909ffdfcdb 100644 --- a/Makefile +++ b/Makefile @@ -690,6 +690,7 @@ endif # may-sync-config endif # $(dot-config) KBUILD_CFLAGS += $(call cc-option,-fno-delete-null-pointer-checks,) +KBUILD_CFLAGS += $(call cc-option, -Wimplicit-fallthrough) KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,) KBUILD_CFLAGS += $(call cc-disable-warning, format-truncation) KBUILD_CFLAGS += $(call cc-disable-warning, format-overflow)