mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Conor Dooley <conor@kernel.org>
Cc: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Peter Yin <peteryin.openbmc@gmail.com>,
	Noah Wang <noahwang.wang@outlook.com>,
	Marek Vasut <marex@denx.de>, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v2 1/2] dt-bindings: trivial-devices: add ltp8800
Date: Wed, 6 Nov 2024 08:35:33 -0800	[thread overview]
Message-ID: <2bdc5b60-2442-4291-a2f2-2e3802b7e982@roeck-us.net> (raw)
In-Reply-To: <20241106-gatherer-glancing-495dbf9d86c7@spud>

On 11/6/24 08:06, Conor Dooley wrote:
> On Tue, Nov 05, 2024 at 08:34:01PM -0800, Guenter Roeck wrote:
>> On 11/5/24 19:09, Cedric Encarnacion wrote:
>>> Add Analog Devices LTP8800-1A, LTP8800-2, and LTP8800-4A DC/DC μModule
>>> regulator.
> 
> A single compatible for 3 devices is highly suspect. What is
> different between these devices?
> 

The maximum supported current is different.

-2:  135A
-1A: 150A
-4A: 200A

Programming is exactly the same, which is why I had asked the submitter to use
a single compatible property. Sorry for that if it is inappropriate.

Is there some guidance explaining when to use a single vs. multiple compatible
properties for different chip variants ?

Note that there are also LTP8803-1A which supports 160A, and LTP8802A-1B
which supports 140A. Maybe there are more, but those are the ones I can find in
public. I don't know if there is a difference from programming perspective compared
to the LTP8800 chip variants; the datasheets are too vague to be sure. It would be
useful to know if those chips should get separate compatible entries if programming
is the same.

Thanks,
Guenter


  parent reply	other threads:[~2024-11-06 16:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06  3:09 [PATCH v2 0/2] Add driver for LTP8800-1A, LTP8800-2 and LTP8800-4A Cedric Encarnacion
2024-11-06  3:09 ` [PATCH v2 1/2] dt-bindings: trivial-devices: add ltp8800 Cedric Encarnacion
2024-11-06  4:34   ` Guenter Roeck
2024-11-06 16:06     ` Conor Dooley
2024-11-06 16:11       ` Conor Dooley
2024-11-06 16:43         ` Guenter Roeck
2024-11-06 16:54           ` Conor Dooley
2024-11-06 18:19             ` Guenter Roeck
2024-11-06 18:38               ` Conor Dooley
2024-11-06 16:35       ` Guenter Roeck [this message]
2024-11-06 16:46         ` Conor Dooley
2024-11-06 18:23           ` Guenter Roeck
2024-11-06  3:09 ` [PATCH v2 2/2] hwmon: pmbus: add driver for ltp8800-1a, ltp8800-4a, and ltp8800-2 Cedric Encarnacion
2024-11-06  4:31   ` Guenter Roeck
2024-11-06 18:45   ` kernel test robot
2024-11-06 19:17   ` kernel test robot
2024-11-07  1:45   ` Guenter Roeck
2024-11-08  7:44     ` Encarnacion, Cedric justine
2024-11-08 14:31       ` Guenter Roeck
2024-11-13  5:45         ` Encarnacion, Cedric justine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bdc5b60-2442-4291-a2f2-2e3802b7e982@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Delphine_CC_Chiu@wiwynn.com \
    --cc=cedricjustine.encarnacion@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=marex@denx.de \
    --cc=noahwang.wang@outlook.com \
    --cc=peteryin.openbmc@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®