From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D143CE7A88 for ; Sun, 24 Sep 2023 03:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbjIXDQT (ORCPT ); Sat, 23 Sep 2023 23:16:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjIXDQO (ORCPT ); Sat, 23 Sep 2023 23:16:14 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02E5A197; Sat, 23 Sep 2023 20:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=hIhc6S9lojzS96JV1IiMmWOoZlmX89PQJ27DBWFUgb8=; b=tcs+ci/+NHqzYCxUBXKQ+iWWbo HfbC2lCB0ZZoR7iP5dsuSuFXkuh1tgcCGESEariPR4RvyDkM72A02vQzkxKS8hh5eOZU/cD/Td5Tc MKXK+8Wll1YtcvYbtg0SFi31WqGbXpEzFT1HVXukIcJDW6B7SWY0wnwAbN8joc058JbY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qkFaK-007KCk-Ou; Sun, 24 Sep 2023 05:15:04 +0200 Date: Sun, 24 Sep 2023 05:15:04 +0200 From: Andrew Lunn To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: "Russell King (Oracle)" , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Conor Dooley , George McCollister , Florian Fainelli , Vladimir Oltean , Kurt Kanzenbach , Matthias Brugger , AngeloGioacchino Del Regno , Woojung Huh , UNGLinuxDriver@microchip.com, Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Marcin Wojtas , Lars Povlsen , Steen Hegelund , Daniel Machon , Radhey Shyam Pandey , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Geert Uytterhoeven , Magnus Damm , Maxime Chevallier , Nicolas Ferre , Claudiu Beznea , Marek Vasut , Claudiu Manoil , Alexandre Belloni , John Crispin , Madalin Bucur , Ioana Ciornei , Lorenzo Bianconi , Felix Fietkau , Horatiu Vultur , Oleksij Rempel , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Grygorii Strashko , Sekhar Nori , Shyam Pandey , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH net-next v2 00/10] define and enforce phylink bindings Message-ID: <2be01f7e-8bd0-42c5-bc82-b1da29b83e24@lunn.ch> References: <20230916110902.234273-1-arinc.unal@arinc9.com> <6c1bb7df-34cd-4db9-95b6-959c87b68588@arinc9.com> <4856b212-5bc5-4783-a184-b34a4a915878@lunn.ch> <5650a2a3-a36f-441e-b4c2-aa7c751b5af5@arinc9.com> <410dfe3c-6f99-4054-88f8-0acbd134cfce@lunn.ch> <228f24db-0a26-4d38-8f73-a9691262cc5f@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <228f24db-0a26-4d38-8f73-a9691262cc5f@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > There is a MAC driver currently under review which does not have a PHY > > at all. The MAC is directly connected to a switch, all within one > > IC. The link is always running at 5Gbps, the link is always up. It is > > physically impossible to connect a PHY, so get_link_settings just > > returns hard coded values. > > The fixed-link property would be used to describe the link of the MAC here. Fixed-link make sense for a general purpose MAC which could be connected to a PHY, or could also be used without a PHY. fixed-link simplifies the code in that the MAC driver does not see a difference, it all looks like a PHY. However for a MAC which cannot be connected to a PHY, there is no need to emulate a PHY. The MAC driver will be simpler. So i would not recommend a fixed-link in this situation. Andrew