From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754444AbcHXUJN (ORCPT ); Wed, 24 Aug 2016 16:09:13 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:32943 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbcHXUJL (ORCPT ); Wed, 24 Aug 2016 16:09:11 -0400 Subject: Re: Memory (skb) leak in kernel 4.8-rc2 To: Frederic Dalleau , Marcel Holtmann , "Gustavo F. Padovan" , Linux Bluetooth mailing list , LKML References: <20160820071504.GA9663@t440s.P-661HNU-F1> From: Larry Finger Message-ID: <2be4b143-4f0f-c688-87c3-8056ecc43dfb@lwfinger.net> Date: Wed, 24 Aug 2016 15:02:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/21/2016 07:09 AM, Frederic Dalleau wrote: > Hi Marcel, Johan, > >>>> I am unable to unload module bluetooth to verify that the second >>>> leak is not a false positive; however, the one in btusb is a real >>>> memory leak. > > There was a bugzilla last week with that backtrace: > https://bugzilla.kernel.org/show_bug.cgi?id=120691 > > At the time, I was thinking that the leak could originate from one of the > req_complete_skb callback, but which one? > > And today that the issue has popped again, I found that hci_req_sync_complete > references the skb in hdev->req_skb. It is called (via hci_req_run_skb) from > either __hci_cmd_sync_ev which will pass the skb to the caller, or > __hci_req_sync which leaks. > > I have a patch on the grill. Frédéric, Any progress on this patch? Thanks, Larry