From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C07D49DBBD for ; Wed, 23 Sep 2026 11:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790162462; cv=none; b=geopT2CvKSRcBmlN8nG8dTIDgC5nPBW3cNX/Mep7JV6lq/Xz+++M+CzF6qWE5MRfznT5HlnskPZoZPkxbQV39hNZ9OKQ0+Hv8wl3M0a4kLaPXf7mBrA2TV5kBRrLsyYH0zssjYWVQDOyArJd/IXIQ5te8Xs5QP76nkjjz0XZknI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790162462; c=relaxed/simple; bh=IJU9MKcwbvSAyF5y30NT+cRls4Pn1fA0J/YBjBXRzkY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g+i7HmhaGGJ9BrmOtfB60unLTlSfKALYptisAimmsUdLu+y18vazDeIJ0C33r16vVjMHANGDgmb81gGbf6F+xvCXzApw+43Cd79ooA41DklUpzTLiG85JFfvJc4FQRzF3mENmn0F9NJOUWK8/jEKD76ATAI3Cd9fZmPFDZdR4e8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KOFFg2/R; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bn9qgeAb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KOFFg2/R"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bn9qgeAb" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NA2moe3208851 for ; Wed, 23 Sep 2026 11:20:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1pvnghHOUtv+RWwHYZG0OQG1LJBa0evkZWaVyqIA/oE=; b=KOFFg2/R3VL8g5ty lg3w6xp8EqYfWowoyBUsufen0Mwwz7lRw/xhzkS7YNyPHgJXk4jNb0frG1c6PETc orq70fAvyPcGktcwcrt5/xJj8CLuaVSUdmH+svWtbOzeUddWAGuMEZO8EiDd7dN2 RkI3Bz/AVD958iSgUgjI+sa0CkIx/qym2xNqJDB0NCPTXAza5gHXjuIX1G8LAkHk d+odsuReajFzUCRZikILMa8MOS6TP7HWmK+VZ/PgazflCG+QD4aab8rRv0sC4k5x VpO+RBaOl/zzrVWiy8D3rdTRKZfqggK3mE0RATrg/SHfR7U0OCaJIErETvSlhoA9 lWH8Pg== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gv78n1pvd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 23 Sep 2026 11:20:59 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-32b8c2b30c4so1172161eec.1 for ; Wed, 23 Sep 2026 04:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790162458; x=1790767258; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1pvnghHOUtv+RWwHYZG0OQG1LJBa0evkZWaVyqIA/oE=; b=bn9qgeAbV517ifSOIgeCQVegdb23XnDJ8ZZrt4KAeoIHcsxz3wf/CaEWiR7mkHZNmC pzyAQENr3yOC94GNF90Eyl8tg5ro7P+aFpWzc8tBoxF2P0nANhIsr6QlTHJx22t7AZHE WC4ZtoX++tY9AC+c81SU/vXBUVmcwKpQKVWCEaqb+8EyrOQREP9ct+YikJUSXs0FlUu1 qoMx+DVtN4YmKyAQnuDKgeZTnjiH/8BBKxAA56LWIiSgvlq3mADa6QNeUdXgk0UHp5wo dTJGoLnfHZsfsAGxlmVDApwNJulsBvNq0A+uC0JPjJLUeuu/+e9qjnfkn12yTQRR9jaA OeCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790162458; x=1790767258; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1pvnghHOUtv+RWwHYZG0OQG1LJBa0evkZWaVyqIA/oE=; b=wsxRaTMrEqHwgBke65/AT2pAE+nWxVrRBcjp9mNpqnPtHEzezxzfblnJwVbFUAZD2i tN0ynELmeeH1/+5JSyO9d0+uT08q5wXf20jIIBbnkdQOg/N9LL3wf8l0Xe96dl8+m3yk BMuiaKHnCpT9LxbJRxCosjxuItoKtbwQjGXgRSKskALvAYjQuCLPErVnPxtTC6c9H28o iq1OT99su0M6UsWRPKbXmtDcGurDZIrmvU6DDop3PA//TDHAKTEDGngd9gszva5H5RVj T2kZV+rQJdN+tyC/bExLQ+thEBywtFP1g9JX6b0Dtwo5CICuqWJy73SeUNLarp7vPpnH 7vQw== X-Forwarded-Encrypted: i=1; AKwUvBx3KkqL1SieOzjp2/mij015ME6/Epx2dZm1B7PiClozY8WzF16OQBt+vE3MkQgFgPmpfqHg1pb1SOMtQ14=@vger.kernel.org X-Gm-Message-State: AFuF++mGj/gtMGmFqa9aDeUXRGCX+DImzpA/Bu+FOEwulEWDS8kVmJYG N/K1T74sP63R5SKWf1sENwv97omKoosxMYZMDdhIPWSCPLJ9gyQV+V5CWb+P1oKsylWLJsPJA8M Drlq14aHJyqCY8WIFZs8xZWGPi4eTetraoyQK6dRn3dY4cc3yMupSUnkiHah00s0Zu2Y= X-Gm-Gg: AYBFou2W1STZcWdvvf1Fyk4LqHFkxCUDxqwy4Gj6GWs1l1yFNphL+JfiEhVmnHy3nHl SHzFWFTlOSY7uCuXrUsZCg/wVrGeShiFUglq0artaSTQ1mw6JqFpBlGY1oMUeWegKfI6RB7x+7D gLq1BwVYHF1ln1Nzcc9baRM01mrNI02whAE/1Wm2gOzcgUcgEdZh2SplsGGkcBMW7xpJIOXJvY8 40OWdrtzhHmp6Jv9b3OBWmQ1JXD7E8kyw/JKgp53QYNs9oAUhoiGEYetoJIc6wWXwiTiTH8WjuX EITXMT91fUPmNXQeG8e2TGMeZT7M+Q3AoiJpyCA4TfgCRornihn/oTtQiPrG2dRVVMH6sdqfDd8 LDlTNnKC0iQXwfTecc9VX6iToq/o= X-Received: by 2002:a05:7301:162d:b0:33c:5ff:71e4 with SMTP id 5a478bee46e88-33e8c249fb9mr2158396eec.9.1790162458377; Wed, 23 Sep 2026 04:20:58 -0700 (PDT) X-Received: by 2002:a05:7301:162d:b0:33c:5ff:71e4 with SMTP id 5a478bee46e88-33e8c249fb9mr2158378eec.9.1790162457791; Wed, 23 Sep 2026 04:20:57 -0700 (PDT) Received: from [10.218.18.193] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33e939fe502sm5805691eec.2.2026.09.23.04.20.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 04:20:57 -0700 (PDT) Message-ID: <2be528dd-487f-4093-a2eb-5916832a4123@oss.qualcomm.com> Date: Wed, 23 Sep 2026 16:50:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/4] ASoC: qcom: q6apm-dai: add SCM buffer assignment for mDSP platforms To: Mark Brown Cc: Srinivas Kandagatla , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mohit Sharma References: <20260922-vmid-v4-v5-0-e79cfd7af5b3@oss.qualcomm.com> <20260922-vmid-v4-v5-4-e79cfd7af5b3@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA0NSBTYWx0ZWRfX1+8luz/qrWfs 4r8zQGf/6OBWkm1HuMVKEiWEI1FEVcibjguCHcgEdlkwFImywvR7nWTDzQ+d89NO/Vv6zkpl/ti OyDTYA+cJbMzbwdKZkECqGviYsii+VU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA0NSBTYWx0ZWRfX7zbkUTkECygf Ep6pXSlLQ566OmLcW4aGuKM+9jm2v6ZK7h6LKeDpyNhYgtleZHUWEmHLldKzrqpHzTD/Qw2DKxo bEsGrRYIBcJDn74mzWSEtqVYTmjalxEAfjIlIXdja3INBtqGa7HCpmry32sgrVoE5WXKX/ZwbQZ o5QubrUH7TS8966upwOjAVOknVHkkPw4rNE0RtFqYup2WtopvH86qvp+q0aChXkKA3jkJTG+WFM rlSoTC5TtfYNy1KvlMCfRRuyNSTbb6nPtX+tp9cJZYNDMpIjeWh338P4qskkwjcxhtTWNPJxQx5 shortSohGFTY6a/2ktWfysjr/DCJwI+Q/cO0Zf3Ieds8HIOLowkC692m/Hmolvx4T8WZtXw8eau vFm3ugdMHzlOSpCuOfbCUwIcxwX1uoKXiIS1GINH/3FyDL+oQ+lLpUYBWQgC6yVokkrKOW2x6JR 3vNz/tY8K9zaiTHN7qg== X-Proofpoint-ORIG-GUID: deaMYwwuv66UBM9DhlFvVmKc7ffuxR1q X-Authority-Analysis: v=2.4 cv=aNFlOr9m c=1 sm=1 tr=0 ts=6ab3b61b cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=Eu4FWuEEJWto4IdLvdkA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-GUID: deaMYwwuv66UBM9DhlFvVmKc7ffuxR1q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230045 On 9/22/2026 6:00 PM, Mark Brown wrote: >> On platforms such as Qualcomm Shikra, audio is served by the modem DSP >> (mDSP) which runs in a stage-2 protected context. Unlike ADSP targets >> where SMMU-mapped system RAM is directly accessible, the mDSP cannot >> reach the PCM buffers unless they are explicitly SCM-assigned to the >> appropriate Virtual Machine IDs (VMIDs). Without this assignment, audio >> does not function on these platforms. >> +static int q6apm_dai_scm_assign(struct q6apm_dai_data *pdata, >> + phys_addr_t addr, size_t size) >> +{ >> + r = &pdata->scm_regions[pdata->num_scm_regions++]; > This needs a lock. > >> @@ -1021,6 +1168,7 @@ static int q6apm_dai_probe(struct platform_device *pdev) >> { >> + if (per_stream <= POS_BUFFER_BYTES + PAGE_SIZE) { >> + dev_err(dev, >> + "reserved-memory pool too small: %llu bytes\n", >> + (u64)rmem->size); > %pa Thanks Mark, fixed both in v6. I added a mutex to serialize scm_regions[] / num_scm_regions updates in q6apm_dai_scm_assign() and q6apm_dai_scm_unassign(), and changed the reserved-memory size diagnostic to use %pa Thanks Ajay Kumar Nandam