From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762202AbdALAHt (ORCPT ); Wed, 11 Jan 2017 19:07:49 -0500 Received: from mail-by2nam01on0070.outbound.protection.outlook.com ([104.47.34.70]:34786 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752749AbdALAHq (ORCPT ); Wed, 11 Jan 2017 19:07:46 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: 0ac94371-46bff7000001058c-32-5876c6aed212 Subject: Re: [PATCH 3/9] dma: Add dma_virt_ops To: Christoph Hellwig References: <20170111005648.14988-1-bart.vanassche@sandisk.com> <20170111005648.14988-4-bart.vanassche@sandisk.com> <20170111085625.GA15575@infradead.org> CC: Doug Ledford , , , Christian Borntraeger , Joerg Roedel , Andy Lutomirski , "Michael S . Tsirkin" From: Bart Van Assche Message-ID: <2be64d60-9579-4a2a-d38c-8f3ed4a2939f@sandisk.com> Date: Wed, 11 Jan 2017 16:07:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170111085625.GA15575@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42LhOum8SHfjsbIIg+9HxC2mr9jOYvHy/AdW i9MTFjFZTD41l8ni8q45bBbPDvWyWJzftZbV4v+vV6wOHB4HHx1i89i8Qstj06pONo/3+64C eaerPT5vkgtgi+KySUnNySxLLdK3S+DK6Du9jblgC2vFtr/XWRoYF7J0MXJySAiYSDyZf5kR xBYSWMok0XpVsouRC8jewSgxceJboCIOsKILW52gahglnk2OAbGFBfQkns46wg5iiwhoStxa 3s4M0TuPUWL+519sIA6zQCuTRPeWQ2Db2ASMJL69nwlm8wrYSdzZuxVsM4uAqsS+viZGkGWi AhESn7YaQZQISpyc+QSsnFPAWGLJzqVMICXMQMvW79IHCTMLyEs0b50NtldC4CarxN/z29gh DlWXOLlkPtMERuFZSEbNQmifhaR9ASPzKkax3Myc4tz01AJDE73ixLyUzOJsveT83E2MkOgp 3MH4+rb3IUYBDkYlHt4dNmURQqyJZcWVuYcYJTiYlUR4PxwHCvGmJFZWpRblxxeV5qQWH2KU 5mBREue9GP0xTEggPbEkNTs1tSC1CCbLxMEp1cBY7jQlhuvn01MRM2TOvP3+YemaW/LG00+r My64ucdr9Qeexx6alYvb0/NNpn//06G+XfNbCWNGa9/Dk1fZhU1uy4bNqp28IjtiZpLEFp7/ /meT1zxI2Oq25cAknwVROy4VyS/9/fGfavH0tW/5Vxzb+bIzcG3DbM6sJ9zvyi09Fi2e1x4Z mS/Yq8RSnJFoqMVcVJwIAG3Q8oyaAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgluLIzCtJLcpLzFFi42Lh2siRonvqRFmEwdk2DovpK7azWLw8/4HV 4vSERUwWk0/NZbK4vGsOm8WzQ70sFud3rWW1+P/rFasDh8fBR4fYPDav0PLYtKqTzeP9vqtA 3ulqj8+b5ALYorhsUlJzMstSi/TtErgy+k5vYy7Ywlqx7e91lgbGhSxdjBwcEgImEhe2OnUx cnEICSxmlLizaj1bFyMnh7CAnsTTWUfYQWwRAU2JW8vbmSGK5jFKzP/8iw3EYRZoZJI48OQI E0gVm4CRxLf3M1lAbF4BO4k7e7cygtgsAqoS+/qaGEG2iQpESHzaagRRIihxcuYTsHJOAWOJ JTuXgo1hFlCX+DPvEjOELS/RvHU28wRGvllIWmYhKZuFpGwBI/MqRrHczJzi3PTMAkMjveLE vJTM4my95PzcTYzgMOaM2sF4faL5IUYmDk6pBkbFVQejJ673N5U/mHV3os2y/zWs8++pMndt qd7q7bV5+10dufeedg2JXgIRu68EML9PbN+2dGvQHuWJD8vLV+bZCTVVTFjBcvUR25bIPx/c dyxJdHv264xO8ZnGSvdm7/zij0yPJ78wWS3OvD1LZOPal1fX1Bb3usXw96tY5ESc8FY/zFYm WarEUpyRaKjFXFScCAA8vtr9EwIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.225;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39860400002)(39850400002)(39840400002)(39450400003)(2980300002)(438002)(189002)(377454003)(199003)(24454002)(2950100002)(77096006)(38730400001)(33646002)(65956001)(83506001)(229853002)(50466002)(8936002)(6666003)(64126003)(8676002)(6916009)(31696002)(36756003)(86362001)(23676002)(54906002)(189998001)(81166006)(81156014)(92566002)(65806001)(305945005)(4326007)(68736007)(69596002)(2870700001)(110136003)(31686004)(356003)(626004)(4001350100001)(47776003)(2270400002)(97736004)(2906002)(106466001)(76176999)(54356999)(50986999)(5660300001)(65826007)(53416004);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR02MB033;H:milsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD016;1:H5Nl2sj4hlblmu2d6JlVNJakA2OqQ4qpq8GFUWy+7R9gXRgGNm8tI1Gu75+sSBw36xAiyh7JBHjZrk6v1gQ3LrlsOnYRhgypOOPhhAS9GuJq+vQ+n5ZVVhz3vq+mbz4QuefpsYzaDkcCzAqLbntYXA37aPhQ6eNKbzS2KQEdlz4dc9ikcgNbeVmlGX4XULg3ISEDQyPOI4oTvhXsCU0Ev6hhVZVVb1rSIaj89yQVgnE98ImnCSapykny/zF5BPmSXXAAfvSBY2ZdOlYWByq4UNbGgQnEJyhssDxHzl+Wdq0YspITgKOp3y+C1EeOrjkxzc2E1QTLBCQuyc94oAhOy7cEd56KOVA5T3+q/i6ypiF09nRZZMbeF6+1SFjDxqDWJ05PpEZMuzlCK872c1aaEKEMKxVS6ENJcySSDErRpOw6OvBo841JISwxircKXz8Alyf2VMt92CosiVrKOuzltRnKl0ww5Z6HZZGLU0nnSutDpWHnOEGuCL+PkL0nLEiM X-MS-Office365-Filtering-Correlation-Id: d07f6f6e-adc7-4b01-9739-08d43a7f0732 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BLUPR02MB033; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB033;3:nTnjcpIzC4u+tlrrm9B0WG4juQqSMSSbnEEmQ9XWiAb+4wvrrkhJIneGb82W5n5SMHQoP3mf+jmK+grHnA29S1hx5C3QIJfcmtAmTdtaTghzpr6xhudua69a2QDjz5peh3AO47m/spnGffFqE3QgzPYkPmxnzJZCMC0bp6H3EBDzXZyfK6Xt4Tx4nQlc4afDK2PXKbJPLYl/bMs6TDWiuAmMGpjmzAqQu5FAz3ssYzhs4e/gwqQmlHWMVosG+UCUBJstLn2YAH1XGPbOCZd4TovPTHyZBCUJ8/bnwD8XkkzPzMflG87Nq4Y8/IPmFkXdq72Ei9YKGYT9KO8c+giR/u9ksNlo06WJxeER37e/8wvTJdo+kGuv1optRmn2a0QFfO4z6vDj7DRj31+iZILgBA==;25:WyRww/BqNeaS9mvTHDiDJaK1GhSuBZjHGc2j/iyCwm/1ipna5KCx0/o/Zlv9zO3vBBEH+2BtXUSiextHovARlLVE5xmJf89mT5jUaDE72p4cF85ygcHMZC9rVd8f/QoCI1rM3AFAX+ocy3EWlw2MJop5MQFaerXAX+s25bQUzYoh/NsREmUj7HW8FtPBxLb+lV9ctyHgLEWKjweYpT5xbYL9Qeqgf8fUHp6q00U8IF1CWPGNBqU87GoCfluTLT5YSsGyI3fjZfhpHw5AA4XZb9CLDmSLzucnOqFwuyWIJ4EOs5gDqjoVsyAC/4UL8/qhBie4u4qQN6d8ofNWL67i/+LpedAICJ5i1yZOKifV1IW/j32c4WDQSAxiEsyKMPUMWk7ABsHpvh/nzowvs8phLKNzu1NRYeUTFQ+Bs0qkvclRHOlIjjpZhgY/BzkX343WFX8dE7JdPSYSm2aPKHL/jg== X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB033;31:b4rsAQcJlNoOCnrsuRzh23xhNabDcEX75a8jW6KedMMmrKt992icUwvcOVXZx3FWLGr6/pPk4Vwx9TBA+Zf50wxWBqq11W2NBV4tq+s4LUwhkpUrQbnkl/mRLsgE5GIGhJ+vTyv3KtrXjefWmK9RtQEdFagNnSNf5S8fv97z7z+ltmuDo+XLpPxeVWZrBf3EmCKek31DnbhiyEF7dk1D+ACycVQEULIVFKB8COxFfuRSiMY+lMqOAF1sm8rcGb5QD0wgKOEau85Pp3oh0inAYg==;20:1hRkzizxGqQoBWlwwzhQUN27R+JlSuf9FSZxb57KFCTgTarsK4wkpxoUa3qXjDC19adIc/DMw54C7OIPfYgYOka5k7F09wXaVgTzQcdY9FzKlDfikbhMKQkngPqhs6LqW4XCQUIfqZFBRwpNlSmL6RHaBZZ67cBtwjJ0CZGpB2P3kGT0RbKBj8TqpbA8CJDUmm5MkWjldYqMRDbvoawSgwer9yc1vvgnbyPp60ylgyfMhRukeAN3csVWq+rBDvubH0dhSDketpGhwv6kWreeXjeZrbmabBySpDt9VmTfUSScnHopUdO2ukfGM2A2Ab8k7RXWlEVLMgXxyZNp4jn7O2G3rK/JdjN+Er5lKf9ERrQ6e3bJMtFNbNKGvu72GXAnkpjPMhvPvFOXY9NvacF7nuZgHnnGN2HwiTuvDXEoD4ZZDD060tqN2VKX9Brw9JAiBMHPmnvxoq2qp4S11YNY/wRh7pJ23cIb8TYLk8eDDaPO87h2pf9zmW/x5NhPu0UR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13018025)(13016025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(6072148);SRVR:BLUPR02MB033;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB033; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB033;4:487KxRSTsb2z+VLfvPTmELzGynEVXxr5hfuCE+OuGoDRjtw0UFZe4//gl9gChowfnsdkIzux8TdlRep6okFAZ0lfRNv8gOs9dbNraRQKDk3Hi8hTXVVOnV4K2rSCiDoYLqFHmajOz7LkuyvAiSxo3ELpQZ0JYISb5lJ0+SrjBRr2TylmyyYCjnQ4gfcTKs3Mtw3xpRgBfnd2OLK6oTjz7ruAIddpoC1C0hRvLHi/8T6M09tH+4t7mRCP0RJhThQ8OjRciMjsd7Q+3aiq2VCgc/s1oMsCRsrr4z3nw9rt3OtOvczd53WCibaoF406Vw21Po0sYOELHO8JEfyykSn+xeafZpjM+0Qzsn7CgDHlckW0mETYF/s3I51dfxUXk02QlDi6A7uG6sViiNULJEdzn9JXbClOES2YDYKu3cWxZYnPP3JvGSY75i6PDnDZmTu+VNM2x7ykCewNRTROzf6VSiX548KCPYfHjowhozSatCv+DGPB21sClngjz7VMKSL4tOzL/1lTfHQyZoUTwHdMTVmp6hYLKwucaTsS7eh4SGTTwuyJic2AT6728VIsz63oiq9pDewd7TgSiXNBqIf0vBGjrc9Ns/3N7p23U1+aZsKwmuffpwUG8vS1qC1iYwqO X-Forefront-PRVS: 018577E36E X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAyTUIwMzM7MjM6YkozbUtnSmhNNDlRTnp2N2h6WUVTQWxBK2Vt?= =?utf-8?B?KzR5RlRJellUbllCMFI1NlpDOS9oeE5aVFh3M05WUE1VOHN1aGFla2d0RFgy?= =?utf-8?B?SjJraDJja24zaWRhL0Rnby9SL0dPbUVQM0FUeVoxbWRCY1YrZHJGdU1tMGhU?= =?utf-8?B?NjM1SDhZdWlyODNGRFA0emc3eUhUeWxjRlI5MjBVUXBrS3dORTlLTzRHWlF6?= =?utf-8?B?b3ZvODgraUZXVk1XcFczT282eEZNWXkwOGZlK2xlRThuOTJqTUVUZkQ3dENZ?= =?utf-8?B?VDlVOTZoMFdkRDNMdVFDQ1M0VGNxck1CTmhsMytXN05OY0FVdE1vU2VXdnJV?= =?utf-8?B?ckgvQWc5b1ozbWRQRWZ3ejcyVm5MNGNSbFlkTVBVdDV2RUNZb0xGMWMxNS84?= =?utf-8?B?Z0MvbUQ3RXd2RGI3ODJ1b3owQjhxZDIwTC90bmNQY2o1Mm9qRkZnb2U0cjdw?= =?utf-8?B?UVhaZWdWMi9tVk81NW81OG9Qc2xYUXluMEJkdmFBdnNOUTl2Lzh2VUxJdTRV?= =?utf-8?B?Wi9vT1RaT1ZYaWI2M3FrdGVTQUZ4REhQM2tmMlJHZWNGOXo3RCtGbnY3TWU2?= =?utf-8?B?MU1tU1gydkpTTlNQcVpYazFCTG9SOVJHeGxxclpobVJjSmFjb1JoZmRoQkdC?= =?utf-8?B?NGJ1TjVrcmhidjVTeEZISjJXUmxuV3pwQnd2VUpUNUxPSW55cStJNWlGKzNY?= =?utf-8?B?bm1UL1EyYzhaY1ZyRkpXellsaVFvZi9pd0cvQ2FRTUYyMi84cFliZjFDOC8v?= =?utf-8?B?ampDNjdxdUJpVVYwc1BYcGxwbzRrNW5qU3EvbTlXemZvRVFxV3FTdlFTTkVE?= =?utf-8?B?cVdaU01jTU5BelFEb0NkeFIvZ2tvNDRMWFp2NTJWOU5HQlh3TTZCTXdiV1l4?= =?utf-8?B?clgrbGtLdUFPeHl0b3IzVnhGamhJN21WR2hSbW5nYUNVTGwwWXY0bVhpVnl6?= =?utf-8?B?OThIY01QQjVaeUVBSE1DRk5YbWpRZlMycnJ6RGtvWW80cnJ6b2dSMm42VjZY?= =?utf-8?B?bGVSUm9wTHprbm9IRksreS9PQytUUGh2SmlSUWN1Vys4MEc2MmlYSHFKTjZu?= =?utf-8?B?YWJzUGhlWWV0Wm1KUTNKcFNUS045L1A2WDA5dmRSQ0FVNWZ0bHRJTkpGZjl5?= =?utf-8?B?VjlsS1laaEdFNnlIc0FGSDRLS0Q0cktTZHo0cy95Mm8zWmJDTDZWOEdPaDVt?= =?utf-8?B?c0Jvdm9NeGpQMDVPa044VHA5TnpNbm85dVdMd001UEdNOE9xUWcxMzZWWFVS?= =?utf-8?B?MnRpL0MxUTJvMzBmSjE5NXU2SXBwQVY3dHFleDJqa3hkc3VZYTFVV2w4cEpw?= =?utf-8?B?RlZCeWNtWWNoYUxpdk04dWROVHg4dXZWdllyck5ucFFYUFhMaGpadWM3NFpP?= =?utf-8?B?djcrcDYwZUJ3SGdhd25zVTlVaDduc1RKZWJRT3o0cmN5ZmtnOU40WXFJVDlW?= =?utf-8?B?bUNnNWJjdGpMRzRHNkc5dzBpeXdjMEsxSDA5TWdFZkYzNEJMb3ljcFM4YlY4?= =?utf-8?B?Q3BNYkJOVU8rZFM3bDFpbmk1WjBCdm51SEsvVkUwdHZ5QUlaMk9JVENmelkr?= =?utf-8?B?SVFsa2g0RE9kYXpqc2pXNE81aWhrSXZRazlGQzZXQ0dJV3dybnNKbDY3WmJF?= =?utf-8?B?QTNkR0dyM3BESVkwbXBETDZiMFYyRnFvZ1l3QjY5NXJOYmlBNitUajNIYVh0?= =?utf-8?B?R09oeC9kREE1RjZ6cVExK3FXRjAyMVdzZjIzVmdpcmk1WWQ1TGVnZmdKeXZa?= =?utf-8?B?UVZ2aDNNWndyd3U5Qjd6dGIzOWF3dDZmMU5OOFZUZmRsQUI1VVVJc2hyQndu?= =?utf-8?B?OTRuSldhK1dzVWp6WWYzMzgxWm5LckpPbnRxcTE5YnRpcU50Rm5yWG45Nk1a?= =?utf-8?Q?xR7OQG/nYU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB033;6:Q0RDZlBrPSevM7ub5lJtdd29nWBmqk+cQQNC3rIxQR69oITxgQq2h+hdpMBOAsiQteFRxd7C2KF1ZYlJT+/2/R0mr7csI0FxLwbWwkiO/25QRhDVIlNT1ONGci0Dyntmk3oFKc8e43c6CbSxUjZwzuf8YED5UyWEsxEI7MW2NEadsN9ekQGEkcalRJNFf2xcWIjz7siOvoBKpBhThqWLL7KrMWWOE33HgoX/PVDVGZyCytPCkYpqIxYmN8FdI/USE4JMlcueFUD1SaM1zDf8vbL4DyVLb/rKzPTTM4MReUdrHQT8cr2IEfzg5kQM53FEFlrWUVFxiJ/0jACWSTGWw4ta9lTCDCJn/Ey0qcMFLJp2UUoe9PpS88NR2/aBY9bn2lLSXFApHIBKPpotSmm+7IApbxBDmaGP9+iQ4pG0Vi43x7D30xcWI2qlQvKcPAX1yf8j/N6t4szDExI9IYRakg==;5:qo58vdnuGFMWaeNmZKw3qkdDpVhTOylwNRBU1PBLkSYdbjUWobJJCU55KgiSu2nMMM4Wcf674/4IalsWfGsNVIHs3duH/8w57Q6hnPWnwQrQAY02CBDkE9iYYgBjgUdV5KMGCvAbqo+LjHGfvdE1kw==;24:GhTS3K4Tzq/8IJp8npz9y3qZ52KZjeX3XS7z59np6a44ef2U85tyyyJhaHvHE8wjCeJ6Rbt8MFG4UmqKyqbt4tFNNaWUw7UWJ8CrBrXE4GM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB033;7:CVYhPdg5GzBzuGP4EAchjN/R9HazGGtKN99IavIKc6XxH2AMvtzXP3ljlKqGMlemzqrUsLzVhy1+u7Cf/4LAKOK3s8QrHJgBWI1mtn3UzTLVVd8j2uLn12u7XKjz2NaLnvCrdBYwsDAmBouP+J5tgtBB9bbUWRTuO+zyMQT5CIbg0LfTjWVLxLUXRhhPIMHfh4S57AYlKkrDhirdptkL8i1rCgTc2ZRTmmMfjAn6wNzQcOiBKD1f5nxVZlwnlQf8lchhiM3fJIlF6qDi6MNvFjyYbHAEUwMJX1vevoWDNjJmoNweDsf3nam9ZKW12cWuT9hbsGVtgtvHA4vvBgxB4FVm8DmRpHqQsP1qDhEft/neo7NlSXrAk++HCBeBpeSksWQu4izHwWgNQadEMXL82g+GnsnMFjsk3iP7wEvWAtVblcVYF+8BLkuEF+BJ8rZIRakL2ZEpnEnglhkkms2SHw== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 00:07:42.1004 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.225];Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB033 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2017 12:56 AM, Christoph Hellwig wrote: >> +lib-$(CONFIG_HAS_DMA) += dma-virt.o > > There probably should be a config option for it for two reasons: > > - do not bloat kernels that don't need it. > - the feature can only work for 32-bit architectures or for > 64-bit architectures that set ARCH_DMA_ADDR_T_64BIT… > Alternatively this option would have to force > ARCH_DMA_ADDR_T_64BIT when not yet set for 64-bit architectures. > > And yes, this is currently broken already for, but we'd better fix it. Hello Christoph, That sounds like a good idea to me. I will make sure that both dma_noop_ops and dma_virt_ops are only built if needed. Bart.