From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934681EE7CB for ; Tue, 17 Dec 2024 20:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734468751; cv=none; b=jXE9CDvzQb8deJnku00u8pfERfKNNE7QOeIeW2q4VCUBRBikMLc2Y/gDUkYYTWuhmX2YKzhc471eY/SWlHLEw85AsPGepdOpixt/7ji7KeUV/64VlAtrQZ5Am83A5yteS1krbDKvqS6Np0q2tZev31HyONW8DWBcqyPrUIyPBzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734468751; c=relaxed/simple; bh=QTgTwjrLzq+Vh3vlJUekypbgmjzQ4zFJ9paCtPkW590=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cB7PXOytVuCK2u6OH0SIy6A3gwWaMqXIscqtEqwF46k+WOXiQfvtEPYfDNFTgAJ2SrW+Zs1qulxP3j2ut0ghoZRh4H7/d73XIH5bgNiuug1abIASpjVRVknI7Mep+Z7LLUZqYMWgt6g2Kub+IIZ3jd7WhM93L9qgBjxuVoI7PSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=gGkDczDw; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="gGkDczDw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1734468746; bh=QTgTwjrLzq+Vh3vlJUekypbgmjzQ4zFJ9paCtPkW590=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gGkDczDweBrHtxydhN7MEf8Pgf0FmBXq6Z860ntzw+x4TerllQUvTIbx8BZLHLxwc lQD8Qe3C01isMn2ZlHk4JGoDudQc2VyxV8dBoyiDMMBxfUp5qhCAQT+M5EkZAzV9iQ 7iPiioHO2joqDxWOYGzvItswwkXYqtvFjOy5R92OYOk7bfrHX2LCPKLTjIGmhUvFj4 fEYT11ZdPZo6NlFVDxf8+N+LJcTNw/DfdACT+D+/NLaq6yteMODWLiVpjVNRgGhQmA p2p/DMGGMX0YpKIgohX9+dpGT9Xb9cHysiLSkh2Spui1zjeDquY+PbG6/NtT7JEsPK IwNXHq1qS+L3w== Received: from [192.168.1.90] (unknown [84.232.140.38]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id DA7CC17E380A; Tue, 17 Dec 2024 21:52:25 +0100 (CET) Message-ID: <2be9721e-62f3-41cc-83a8-5189b750a655@collabora.com> Date: Tue, 17 Dec 2024 22:52:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/rockchip: Don't change hdmi reference clock rate To: Derek Foreman , Algea Cao , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241217201708.3320673-1-derek.foreman@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <20241217201708.3320673-1-derek.foreman@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/17/24 10:17 PM, Derek Foreman wrote: > The code that changes hdmi->ref_clk was accidentally copied from > downstream code that sets a different clock. We don't actually > want to set any clock here at all. > > Setting this clock incorrectly leads to incorrect timings for > DDC, CEC, and HDCP signal generation. > > No Fixes listed, as the theoretical timing error in DDC appears to > still be within tolerances and harmless - and HDCP and CEC are not > yet supported. > > Signed-off-by: Derek Foreman > --- > drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 13 ------------- > 1 file changed, 13 deletions(-) Reviewed-by: Cristian Ciocaltea