mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] net: dsa: loop: release netdev reference on registration failure
Date: Tue, 3 Nov 2026 14:36:12 +0100	[thread overview]
Message-ID: <2bea0e6e-5bff-4a3d-aeb7-5b199924fb3b@lunn.ch> (raw)
In-Reply-To: <20261103100529.1309887-1-vulab@iscas.ac.cn>

On Tue, Nov 03, 2026 at 10:05:29AM +0000, Wentao Liang wrote:
> dsa_loop_drv_probe() takes a reference on the CPU net_device with
> dev_get_by_name() before calling dsa_register_switch(). The matching
> dev_put() is only done in dsa_loop_drv_remove(), which the driver core
> does not call after a failed probe, so every failed registration leaks
> the reference.

Please read:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You must indicate which tree this is for.

And please think carefully about which tree you pick. Does the issue
actually bother anybody?

    Andrew

---
pw-bot: cr

      parent reply	other threads:[~2026-11-03 13:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 10:05 Wentao Liang
2026-11-03 10:09 ` netdev-bot+sinfo
2026-11-03 10:26 ` Krzysztof Kozlowski
2026-11-03 13:36 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bea0e6e-5bff-4a3d-aeb7-5b199924fb3b@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®