From: Markus Elfring <Markus.Elfring@web.de>
To: Zhihao Cheng <chengzhihao1@huawei.com>, linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
Yi Zhang <yi.zhang@huawei.com>
Subject: Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating entries
Date: Mon, 1 Jun 2020 14:00:48 +0200 [thread overview]
Message-ID: <2bec05b7-78d3-fa36-134a-efbe977933e3@web.de> (raw)
> Fix some potential memory leaks in error handling branches while
> iterating xattr entries.
Such information is useful.
> For example, function ubifs_tnc_remove_ino()
> forgets to free pxent if it exists. Similar problems also exist in
> ubifs_purge_xattrs(), ubifs_add_orphan() and ubifs_jnl_write_inode().
Can an other wording variant be a bit nicer?
I suggest to avoid the specification of duplicate function calls
(also for the desired exception handling).
Will it be helpful to add a few jump targets?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455
Regards,
Markus
next reply other threads:[~2020-06-01 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 12:00 Markus Elfring [this message]
2020-06-01 13:45 ` Zhihao Cheng
2020-06-01 13:55 ` Richard Weinberger
2020-06-01 14:00 ` [1/2] " Markus Elfring
2020-06-01 14:09 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bec05b7-78d3-fa36-134a-efbe977933e3@web.de \
--to=markus.elfring@web.de \
--cc=chengzhihao1@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®