From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED90C388F7 for ; Thu, 5 Nov 2020 01:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1546520825 for ; Thu, 5 Nov 2020 01:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387986AbgKEBBH (ORCPT ); Wed, 4 Nov 2020 20:01:07 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:7413 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728052AbgKEBBG (ORCPT ); Wed, 4 Nov 2020 20:01:06 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CRQF92qWxz71p3; Thu, 5 Nov 2020 09:01:01 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 5 Nov 2020 09:00:59 +0800 Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE To: Eric Biggers CC: , , References: <20201104064310.15769-1-yuchao0@huawei.com> <20201104064310.15769-2-yuchao0@huawei.com> <20201104180153.GB846@sol.localdomain> From: Chao Yu Message-ID: <2bec3d16-e920-12b9-562d-0e055c1af28e@huawei.com> Date: Thu, 5 Nov 2020 09:00:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201104180153.GB846@sol.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/5 2:01, Eric Biggers wrote: > On Wed, Nov 04, 2020 at 02:43:10PM +0800, Chao Yu wrote: >> +static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg) >> +{ >> + struct f2fs_gc_range range; >> + struct f2fs_sb_info *sbi = F2FS_I_SB(file_inode(filp)); >> + >> + if (!capable(CAP_SYS_ADMIN)) >> + return -EPERM; >> + if (f2fs_readonly(sbi->sb)) >> + return -EROFS; >> + if (copy_from_user(&range, (struct f2fs_gc_range __user *)arg, >> + sizeof(range))) >> + return -EFAULT; >> + >> + return __f2fs_ioc_gc_range(filp, &range); >> +} > [...] >> #ifdef CONFIG_COMPAT >> +static int f2fs_compat_ioc_gc_range(struct file *file, unsigned long arg) >> +{ >> + struct f2fs_sb_info *sbi = F2FS_I_SB(file_inode(file)); >> + struct compat_f2fs_gc_range __user *urange; >> + struct f2fs_gc_range range; >> + int err; >> + >> + if (unlikely(f2fs_cp_error(sbi))) >> + return -EIO; >> + if (!f2fs_is_checkpoint_ready(sbi)) >> + return -ENOSPC; >> + if (!capable(CAP_SYS_ADMIN)) >> + return -EPERM; >> + if (f2fs_readonly(sbi->sb)) >> + return -EROFS; >> + >> + urange = compat_ptr(arg); >> + err = get_user(range.sync, &urange->sync); >> + err |= get_user(range.start, &urange->start); >> + err |= get_user(range.len, &urange->len); >> + if (err) >> + return -EFAULT; >> + >> + return __f2fs_ioc_gc_range(file, &range); >> +} > > It would be better to have __f2fs_ioc_gc_range() handle the f2fs_cp_error(), > f2fs_is_checkpoint_ready(), capable(), and f2fs_readonly() checks, so that they > don't have to be duplicated in the native and compat cases. > > Similarly for "move range". Will clean up in v3. Thanks, > > - Eric > . >