Re: [PATCH v3] mfd: tps65217: Introduce dependency on CONFIG_OF

[Keerthy <j-keerthy@ti.com>]

On Wednesday 30 August 2017 01:35 PM, Javier Martinez Canillas wrote:
> Hello Keerthy,
> 
> On Wed, Aug 30, 2017 at 7:50 AM, Keerthy <j-keerthy@ti.com> wrote:
>> Currently the driver boots only via device tree hence add a
>> dependency on CONFIG_OF. This leaves with a bunch of unused code
>> so clean that up. This patch also makes use of probe_new function
>> in place of the probe function so as to avoid passing i2c_device_id.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>
>> Changes in v3:
>>
>>   * Added more details to commit log.
>>   * No changes in code. Rebased to latest next branch.
>>
>> Changes in v2:
>>
>>   * Cleaned up chip_id and data attached to the match.
>>   * Cleaned up i2c_dev_id
>>   * dropped the rest of the patches in series for now
>>
>> Boot tested and checked for regulator registrations on am335x-boneblack
>>
> 
> Did you check building as a module? Autoload won't work if you remove
> the I2C device ID table.

You are right! I tracked many of your patches that are already in master
branch so assumed it to be working. Seems like not. Thanks for your
feedback.

> 
> [snip]
> 
>>
>> -static const struct i2c_device_id tps65217_id_table[] = {
>> -       {"tps65217", TPS65217},
>> -       { /* sentinel */ }
>> -};
>> -MODULE_DEVICE_TABLE(i2c, tps65217_id_table);
>> -
> 
> Unfortunately this can't be removed yet. We are getting there but
> still some patches need to land.
> 
> Rest of the patch looks good, so if you keep the I2C device ID table
> feel free to add:
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Thanks!

> 
> Best regards,
> Javier
>