From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F661202C53 for ; Thu, 13 Feb 2025 16:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739464590; cv=none; b=YoGaQAx2/UoP4q188HYluCMilnQD0rGi6GC0N+kMxoP1e03gWN+2b87lBtTtM/Pks6YySOzKL4MV7HgSkhtXYIUa4ldSZ0vG2LCx3AZtl5G0onGLnBmQTm0jqt/ArgHEVeqGlKQHJ2fE7sm4qdJkyadU9DRB0oijLMwWD5zGpH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739464590; c=relaxed/simple; bh=AQrazMltgXFOO4AhHLQxVg9E2MdXnYe8G96EurERGy4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HSmRrGbg2470wGcB/tNg9HOHvqCH39WFCaGAlIPz197QxuUudUfxBSu+3yAP13n6ccs4RJXoNpFAkQqWELXCQ6DDfcJ7Itq0KtlICmeSQHTgYwNhpMsGa9j4az1oGWlTYyctmr3D40nvKtOiVySSTo03nzEADR9VTqZU0Mxw+L4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JNg1ffw5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JNg1ffw5" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51DA2TwF002672 for ; Thu, 13 Feb 2025 16:36:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jRC9JvP4VHXNyNMipFwDuEvtSP6Ksiyg5e611bESZ68=; b=JNg1ffw54vq6vn0N HjZdNMLtyascFWWDAvd3gRaNKL6yhM86wZdWNJMFZ4VyfZ1vTnz+U+xJoHIR5hri o2pgpR9RMJjggd+7MRVjOJjEh0d/uB8G8hdGSFtXp8WBOBnwnpQi6aN1kLbbDl9v manfatZU67QSLS/+Fs6iATNYhdOwxuwEyHJe85BeOjGh68DT9w+VZdt+nhLIpW57 hhehWoXSbW5VzVcpMykCpR5IT4EK2rGw16kkEsfTpdxfb/Ern9bZ3iW//bQ6K2j+ TwHglL3QsTigQrmqHvWYuDfsofyDVsolNFTp9H4L8AB0dbl8sn50XFqxmM83OPSd j/WOgg== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44semp90mu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 13 Feb 2025 16:36:28 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6e422f1ceadso3022626d6.0 for ; Thu, 13 Feb 2025 08:36:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739464587; x=1740069387; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jRC9JvP4VHXNyNMipFwDuEvtSP6Ksiyg5e611bESZ68=; b=R7dq2yKbcVE8s+CmJa4BRWBLWqEL0VQojR3JNa5HQhBUVnLgC5kzCXRYmrTWc+EnsP f51YXwHDM0VA+mlpFRiW/kVqCRoKZ+s9QsRGTD6Pe8IIDgdckS8o0Tfi+4WLx96tunPx awVvAxsI/uw3NUTSdjUJZeZBJTI1tzhX6sfKlkScmkdp8lxCykfgrJE3U5xsZcJRHZ7A EkKk82bXg//RT6l/PjKydxE58oXWcbh2BrMzJ8h27Kx7ZfqCoHPoiDkdcVHjtZ5JGxbt +1/zIHWftCelTwB4Kdjuv5GnlDEWfb0aNPrbBy5SlbLRTSo+//Lk7WkzLu29lyFb5OFX XU1w== X-Forwarded-Encrypted: i=1; AJvYcCXjfwFGsjKDgN9Ndfmzw6A0VZQasyPPNceYy+OMBqt3ZZNsgm7MQNiPv26z6QZ9f1J1xT3QKN5NeDHnnHw=@vger.kernel.org X-Gm-Message-State: AOJu0YwXCAedLP4pbSfehTkl8TnHRjfkNVXeHJ4+VKprosuA5R+mxHtd N2b6PNCmabwqIZwZk4+fjAf+DKgMmycYttTvNIF4g8eB6hrLoysft+8sG3SyyncL9GtwN2CRrnD k6HNKXJ0xuc5DXVe3AoLDehGmvZ1bW1AMOt56kh3HQMr0u12KGFWCe/nUV2Cdrz0= X-Gm-Gg: ASbGncsEwvtaP1d8ej+RvO2d0urVJ9SDPSIImMdBnkw4oJpOpoHZEz/O87xC4+U+csh sLnW4qLEQKF9Eam6qUXudR9EqQDtKXV/8hhg3ZcQOE0SCq44imfKy4/YmwsQzLrlC2adbIKfTtL Oj5Lc1YGtWUUl5Y/LRPbDYzmNx3OFN+bBAymzms+hL/i07BV/OSQXyODN7Su7K/UUXOwm1OPzqw VAvhkF2qFIyXVyQ6UeOReySDXlQcwGtRvNfiNegogy0rZDuUqZRIjzrCMoHDGCO6Xl6XdOIP6sR HJC39oAAB26eQMtmucIOvshpSl676qVu1ip6g4lxJHAV3cn2Q4Ytup50SdU= X-Received: by 2002:a05:622a:1303:b0:467:5d34:aa84 with SMTP id d75a77b69052e-471afe57ae7mr39969281cf.9.1739464586944; Thu, 13 Feb 2025 08:36:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IE65B4BdI80A2hYuehypNi18VnhTOKeJzxy4QZub8Qv8xnIyZZrKkYGRhBtPZp8LP3QGhc+eA== X-Received: by 2002:a05:622a:1303:b0:467:5d34:aa84 with SMTP id d75a77b69052e-471afe57ae7mr39968921cf.9.1739464586479; Thu, 13 Feb 2025 08:36:26 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba5339d94asm161583966b.143.2025.02.13.08.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2025 08:36:26 -0800 (PST) Message-ID: <2bfaa1ce-0233-456d-ba2e-5b14533f3812@oss.qualcomm.com> Date: Thu, 13 Feb 2025 17:36:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] drm/msm/a6xx: Fix gpucc register block for A621 To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Caleb Connolly Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jie Zhang References: <20250213-a623-gpu-support-v1-0-993c65c39fd2@quicinc.com> <20250213-a623-gpu-support-v1-1-993c65c39fd2@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250213-a623-gpu-support-v1-1-993c65c39fd2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: iAqADbWj9Y2T-XyWDMwCWxjLN4nH0-1X X-Proofpoint-GUID: iAqADbWj9Y2T-XyWDMwCWxjLN4nH0-1X X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-13_07,2025-02-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 mlxlogscore=832 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502130119 On 13.02.2025 5:10 PM, Akhil P Oommen wrote: > From: Jie Zhang > > Adreno 621 has a different memory map for GPUCC block. So update > a6xx_gpu_state code to dump the correct set of gpucc registers. > > Signed-off-by: Jie Zhang > Signed-off-by: Akhil P Oommen > --- So GPU_CC is outside what we consider GPU register region upstream.. And I've heard voices (+Caleb) lately that we should get some clock register dumping infrastructure.. So while I'm not against this patch fixing a bug, perhaps we can get rid of dumping GPU_CC here in the near future Konrad