mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Devarsh Thakkar <devarsht@ti.com>
To: Jai Luthra <j-luthra@ti.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Andrew Davis <afd@ti.com>, Jayesh Choudhary <j-choudhary@ti.com>,
	Aradhya Bhatia <a-bhatia1@ti.com>
Subject: Re: [PATCH v6 5/6] arm64: dts: ti: k3-am62a7-sk: Split vcc_3v3 regulators
Date: Thu, 23 Mar 2023 18:53:02 +0530	[thread overview]
Message-ID: <2bfdd0ab-a73a-f1af-def1-0044cf8d4a01@ti.com> (raw)
In-Reply-To: <20230313-mcasp_upstream-v6-5-77685d7cbeb8@ti.com>

Hi Jai,

Thanks for the patch.

On 15/03/23 14:33, Jai Luthra wrote:
> VCC_3V3_MAIN is the output of LM5141-Q1, and it serves as an input to
> TPS22965DSGT which produces VCC_3V3_SYS.
I would suggest to put link to schematics too :
Design docs: Link: https://www.ti.com/lit/zip/sprr459
> 
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
With that change,
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

Regards
Devarsh
> ---
>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 5c9012141ee2..063e69e45163 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -76,10 +76,10 @@ vcc_5v0: regulator-1 {
>  		regulator-boot-on;
>  	};
>  
> -	vcc_3v3_sys: regulator-2 {
> +	vcc_3v3_main: regulator-2 {
>  		/* output of LM5141-Q1 */
>  		compatible = "regulator-fixed";
> -		regulator-name = "vcc_3v3_sys";
> +		regulator-name = "vcc_3v3_main";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
>  		vin-supply = <&vmain_pd>;
> @@ -98,6 +98,17 @@ vdd_mmc1: regulator-3 {
>  		gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
>  	};
>  
> +	vcc_3v3_sys: regulator-4 {
> +		/* output of TPS222965DSGT */
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_3v3_sys";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vcc_3v3_main>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  		pinctrl-names = "default";
> 

  reply	other threads:[~2023-03-23 13:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  9:03 [PATCH v6 0/6] arm64: ti: Enable audio on AM62 and AM62A Jai Luthra
2023-03-15  9:03 ` [PATCH v6 1/6] arm64: defconfig: Enable audio drivers for TI K3 SoCs Jai Luthra
2023-03-23 13:10   ` Devarsh Thakkar
2023-03-15  9:03 ` [PATCH v6 2/6] arm64: dts: ti: k3-am62-main: Add McASP nodes Jai Luthra
2023-03-15  9:03 ` [PATCH v6 3/6] arm64: dts: ti: k3-am625-sk: Enable audio on AM62 SK Jai Luthra
2023-03-15  9:03 ` [PATCH v6 4/6] arm64: dts: ti: k3-am62a-main: Add nodes for McASP Jai Luthra
2023-03-15  9:03 ` [PATCH v6 5/6] arm64: dts: ti: k3-am62a7-sk: Split vcc_3v3 regulators Jai Luthra
2023-03-23 13:23   ` Devarsh Thakkar [this message]
2023-03-15  9:03 ` [PATCH v6 6/6] arm64: dts: ti: k3-am62a7-sk: Enable audio on AM62A Jai Luthra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bfdd0ab-a73a-f1af-def1-0044cf8d4a01@ti.com \
    --to=devarsht@ti.com \
    --cc=a-bhatia1@ti.com \
    --cc=afd@ti.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=j-luthra@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®