From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08934E92708 for ; Thu, 5 Oct 2023 14:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239177AbjJEOly (ORCPT ); Thu, 5 Oct 2023 10:41:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233746AbjJEOhk (ORCPT ); Thu, 5 Oct 2023 10:37:40 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 007327ABE for ; Thu, 5 Oct 2023 07:03:17 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 605791595; Thu, 5 Oct 2023 05:57:00 -0700 (PDT) Received: from [10.57.2.226] (unknown [10.57.2.226]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 367153F641; Thu, 5 Oct 2023 05:56:20 -0700 (PDT) Message-ID: <2c0547a7-9d55-bfc9-cd3f-02f4f8b0308b@arm.com> Date: Thu, 5 Oct 2023 13:56:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight To: James Clark , Mike Leach Cc: gregkh@linuxfoundation.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, leo.yan@linaro.org, namhyung@kernel.org, atrajeev@linux.vnet.ibm.com, Oded Gabbay References: <20231005084001.34741-1-james.clark@arm.com> From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2023 13:42, James Clark wrote: > > > On 05/10/2023 13:08, Mike Leach wrote: >> Won't this also pick up.... >> >> drivers/accel/habanalabs/gaudi/gaudi_coresight.c >> >> ? >> >> Which isn't part of anything we maintain >> > > Ah ok I did try to check for other non Arm Coresight files with > Coresight in the name and didn't find any, but I must have missed that one. > > I will just explicitly add the missing ones instead. > > Although on further inspection it does seem to be related to some Arm > Coresight implementation, although not one that fits in the existing True, indeed it is hand written code sequence that we do for the normal CoreSight components. The access to the components looks a bit convoluted. However, with the coresight_access abstraction we have, it is possible to abstract it away and move the driver framework to CoreSight drivers. > Perf or Coresight driver framework. So I'm not sure if there could ever > be any sharing of code between the two, maybe not from an initial glance. Nothing that we could do at the moment without support from the habana labs folks. Suzuki > >> On Thu, 5 Oct 2023 at 09:40, James Clark wrote: >>> >>> There are a few files missing from the list like test_arm_coresight.sh >>> and arm-coresight.txt. These could be picked up just with a name match. >>> >>> Signed-off-by: James Clark >>> --- >>> MAINTAINERS | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 90f13281d297..3ee45066b7e4 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -2066,6 +2066,7 @@ F: tools/perf/arch/arm/util/pmu.c >>> F: tools/perf/tests/shell/coresight/* >>> F: tools/perf/util/cs-etm-decoder/* >>> F: tools/perf/util/cs-etm.* >>> +N: coresight >>> >>> ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE >>> M: Hans Ulli Kroll >>> -- >>> 2.34.1 >>> >> >>