From: "Ray Lee" <madrabbit@gmail.com>
To: "Alan Stern" <stern@rowland.harvard.edu>
Cc: "Dave Jones" <davej@redhat.com>,
"Kernel development list" <linux-kernel@vger.kernel.org>,
"David Brownell" <david-b@pacbell.net>
Subject: Re: annoying frequent overcurrent messages.
Date: Wed, 12 Jul 2006 11:06:37 -0700 [thread overview]
Message-ID: <2c0942db0607121106mdce053ap2ea631486dca68f@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0607121344420.6111-100000@iolanthe.rowland.org>
On 7/12/06, Alan Stern <stern@rowland.harvard.edu> wrote:
> > Then the logging of the 'all cleared up' message would be better if it
> > had a bit of hysteresis to it -- the good state is noticed, but don't
> > log it as such until it hangs out there for a while and has had a
> > chance to quiesce.
>
> You didn't read what I wrote -- there _is_ no "all cleared up" message.
You're right, I didn't -- my apologies. However:
> > That's almost exactly how the driver behaves currently -- the message is
> > printed just once when the state is first noticed. Nothing is printed
> > when the state is cleared, and nothing gets printed repeatedly during the
> > problem period. But then the problem recurs very quickly.
If you change my wording from "all cleared up message" to "clearing
the internal state that keeps track of whether we're still in an
overcurrent situation" then my suggestion still makes sense. In short,
don't believe we're out of the overcurrent state until a bit of time
passes.
Before we go any further, let's make sure my suggestion could even fix
anything for Dave. Dave? How often are these messages printed? Do they
come in clumps? Or are they periodic? In other words, would a bit of
hystersis in the state clearing code remove most of the messages for
you? Or am I just stirring up trouble?
Ray
next prev parent reply other threads:[~2006-07-12 18:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200607111747.13529.david-b@pacbell.net>
2006-07-12 14:19 ` Alan Stern
2006-07-12 16:56 ` Dave Jones
2006-07-12 17:09 ` Ray Lee
2006-07-12 17:19 ` Alan Stern
2006-07-12 17:34 ` Ray Lee
2006-07-12 17:45 ` Alan Stern
2006-07-12 18:06 ` Ray Lee [this message]
2006-07-12 17:51 ` Dave Jones
2006-07-12 18:07 ` Alan Stern
2006-07-12 18:26 ` Alan Cox
2006-07-13 12:08 ` Pavel Machek
2006-07-13 12:14 ` Arjan van de Ven
2006-07-13 14:29 ` Alan Stern
2006-08-08 11:37 ` Pavel Machek
2006-07-13 20:50 Al Boldi
2006-07-14 20:44 ` Pavel Machek
2006-07-15 3:54 ` Al Boldi
-- strict thread matches above, loose matches on Subject: below --
2006-07-12 0:37 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0942db0607121106mdce053ap2ea631486dca68f@mail.gmail.com \
--to=madrabbit@gmail.com \
--cc=davej@redhat.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ray-gmail@madrabbit.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome