From: "Ray Lee" <madrabbit@gmail.com>
To: "Michael Bommarito" <michael.bommarito@gmail.com>
Cc: "Mike Galbraith" <efault@gmx.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-git19] BUG due to bad argument to ieee80211softmac_assoc_work
Date: Wed, 13 Dec 2006 21:23:29 -0800 [thread overview]
Message-ID: <2c0942db0612132123o12d8d250rb9583a2dc1588993@mail.gmail.com> (raw)
In-Reply-To: <5b8e20700612132035w2ad90000wcaca60be5d93277d@mail.gmail.com>
On 12/13/06, Michael Bommarito <michael.bommarito@gmail.com> wrote:
> Sorry, realized I might not have been clear as to what I meant! The
> patch was attached to the bugzilla entry, but I'll attach it here as
> well. My description of the patch itself was really as complicated as
> it gets too (just two lines, switch (void*)mac to
> &mac->assoc.work.work in
> net/ieee80211/softmac/ieee80211softmac_assoc.c), just a small bug
> while somebody was rushing through the work/delayed_work changes.
--- net/ieee80211/softmac/ieee80211softmac_assoc.c 2006-12-13
11:23:03.000000000 -0500
+++ net/ieee80211/softmac/ieee80211softmac_assoc.c 2006-12-13
11:24:26.000000000 -0500
@@ -167,7 +167,7 @@
ieee80211softmac_assoc_notify_scan(struct net_device *dev, int
event_type, void *context)
{
struct ieee80211softmac_device *mac = ieee80211_priv(dev);
- ieee80211softmac_assoc_work((void*)mac);
+ ieee80211softmac_assoc_work(&mac->associnfo.work.work);
}
static void
@@ -177,7 +177,7 @@
switch (event_type) {
case IEEE80211SOFTMAC_EVENT_AUTHENTICATED:
- ieee80211softmac_assoc_work((void*)mac);
+ ieee80211softmac_assoc_work(&mac->associnfo.work.work);
break;
case IEEE80211SOFTMAC_EVENT_AUTH_FAILED:
case IEEE80211SOFTMAC_EVENT_AUTH_TIMEOUT:
Good catch, though it was already caught. See:
http://lkml.org/lkml/2006/12/12/46
...for (basically) the same patch.
But again, good catch :-).
next prev parent reply other threads:[~2006-12-14 5:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 18:17 Michael Bommarito
[not found] ` <1166070494.5853.0.camel@Homer.simpson.net>
2006-12-14 4:35 ` Michael Bommarito
2006-12-14 5:23 ` Ray Lee [this message]
2006-12-14 12:34 ` Michael Bommarito
2006-12-14 15:06 ` Johannes Berg
2006-12-14 21:38 ` Uli Kunitz
2006-12-14 21:48 ` Michael Bommarito
2006-12-15 0:47 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0942db0612132123o12d8d250rb9583a2dc1588993@mail.gmail.com \
--to=madrabbit@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.bommarito@gmail.com \
--cc=ray-gmail@madrabbit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®