mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ray Lee <ray-lk@madrabbit.org>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	Pavel Machek <pavel@ucw.cz>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: acpi/sleep.c saved_magic fix overflow
Date: Fri, 10 Apr 2009 10:53:27 -0700	[thread overview]
Message-ID: <2c0942db0904101053g3a7a3d6bh50c0501a1bb73af@mail.gmail.com> (raw)
In-Reply-To: <1239385015.3169.15.camel@ht.satnam>

On Fri, Apr 10, 2009 at 10:36 AM, Jaswinder Singh Rajput
<jaswinder@kernel.org> wrote:
> Impact: fix overflow
>
> Constant 0x123456789abcdef0 is so big for a long.
> So using saved_magic 0x12345678 for both 32 and 64 bit.
>

Uhm, what? saved_magic is a long, which is 64 bits wide on on 64 bit systems.

  parent reply	other threads:[~2009-04-10 17:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10 17:36 Jaswinder Singh Rajput
2009-04-10 17:50 ` Cyrill Gorcunov
2009-04-10 17:53 ` Ray Lee [this message]
2009-04-10 17:55 ` Pavel Machek
2009-04-10 18:05   ` Jaswinder Singh Rajput
2009-04-10 18:11     ` Pavel Machek
2009-04-10 18:14     ` Cyrill Gorcunov
2009-04-10 18:15     ` Jaswinder Singh Rajput
2009-04-10 19:13   ` Sam Ravnborg
2009-04-10 19:16     ` Jaswinder Singh Rajput
2009-04-10 19:29       ` Sam Ravnborg
2009-04-10 19:49         ` Jaswinder Singh Rajput
2009-04-10 20:15           ` Pavel Machek
2009-04-12 17:25             ` Rafael J. Wysocki
2009-04-12 17:30               ` Ingo Molnar
2009-04-10 19:51       ` Thomas Gleixner
2009-04-10 18:13 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0942db0904101053g3a7a3d6bh50c0501a1bb73af@mail.gmail.com \
    --to=ray-lk@madrabbit.org \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®