From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753895AbdFWITx (ORCPT ); Fri, 23 Jun 2017 04:19:53 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7929 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752669AbdFWITv (ORCPT ); Fri, 23 Jun 2017 04:19:51 -0400 Subject: Re: [PATCH NET v2 0/2] Add loopback support in phy_driver and hns ethtool fix From: Yunsheng Lin To: , , CC: , , , , References: <1498204473-194648-1-git-send-email-linyunsheng@huawei.com> Message-ID: <2c145fde-eb2a-a3e6-4c3e-53b3c00ee830@huawei.com> Date: Fri, 23 Jun 2017 16:18:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1498204473-194648-1-git-send-email-linyunsheng@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.190.125] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.594CCEF6.00AF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b5c76e4c8e9940b6f859efdaddd6ca5c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My apology, this patch set have a bug in hns mac driver which is not calling phy_loopback enable and disable in pair, I will send a v3 to fix it. Please ignore this patch set. Best Regards Yunsheng Lin On 2017/6/23 15:54, Lin Yun Sheng wrote: > This Patch Set add set_loopback in phy_driver and use it to setup loopback > when doing ethtool phy self_test. > > Patch V2: > 1. Add phy_loopback in phy_device.c. > 2. Do error checking and do the read and write once in genphy_loopback. > 3. Remove gen10g_loopback in phy_device.c. > > Patch V1: Initial Submit > > Lin Yun Sheng (2): > net: phy: Add phy loopback support in net phy framework > net: hns: Use phy_driver to setup Phy loopback > > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 68 +++++------------------- > drivers/net/phy/marvell.c | 1 + > drivers/net/phy/phy_device.c | 41 ++++++++++++++ > include/linux/phy.h | 5 ++ > 4 files changed, 61 insertions(+), 54 deletions(-) >