From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 370D933065D for ; Tue, 16 Dec 2025 14:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765895520; cv=none; b=mm9OFQQ8KGAz5GuHdb001VcOUKM8/w2XfM8AHqmLeEP5ngJuZWlIeuPzG/iSKQ8iU74I+VVQ5V3M2R4IkcDXSQfHBPx/aazqfISpSvHfteOtp9gEkkIsI5eoeO5WGMeE/jnAZiYl3wq1jyCtvCdAZJNaHAeW398QBjRkhXsOkes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765895520; c=relaxed/simple; bh=ZzNov03F7y+cUoSrRCIHW1mWWECeKZAXm94LSetcYY8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hyTo+kFBQWuaOWdz/YpoHyERhIEY3+7Gw4tjli2Nsq9bhkDQS/DlthG+6h3f02grwbP8p+5RJqeBGChpaMD/JOYLgPdY7VxoDXMF4GSWdkGho1Q5PAWpA6r5BL/+w+qUmA0sHqAZd2ZYGiqfFO9nJnkaDa9MiJV9h8ggy90jypw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JXYAPBj1; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JXYAPBj1" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-47796a837c7so34101815e9.0 for ; Tue, 16 Dec 2025 06:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765895516; x=1766500316; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vrvW6xI1XkjYJ7Zx47OyO1gNTKJ3KALebK0l5/GjGy0=; b=JXYAPBj1jiHg9q68O9MAGEy2jn6xZpaV5INbWT3XfODTgKJHss/iv8huw1EskdfIke 0TT+Yz0QyHU/Hl97j15umGCQeHlRVGvCrfiDOasR0eoKQxpJyKTYpkpg6O8BDBct53Qc /9pBWdjq2r9aaKoDm9JyCrl2enehli/JfI4/86nNQ2sOgXPxI4tmEsOFYcIPCnu7ckNZ 1Kk2qLzl4tNTRlsJ4v1iNvxoEOC0WjKfqX99IlrAoYnhscI6L5KBmxCPwbc902xD9L2Z S6+0jT9v340/TFWixJyQkQqmiYslcInjR+3TFxs1k7p3EPtl6rPGrRZjz9U1XatNIFEO kUnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765895516; x=1766500316; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vrvW6xI1XkjYJ7Zx47OyO1gNTKJ3KALebK0l5/GjGy0=; b=EAGqKMEtVlfUkNT2bHBX0Q2QzzNgehCis/9wnpOeQuo46/tM5fwSjMYPra2VPm+Hdy PNtb6T30H0eiSZAIQbp4gwTqc4Rg3QvqUCStFeAIn8oONwi6jM+tQkzXlTZ37cNHi3lz z4SXj26QovD2AZvGues0tmyGd2cvb8ZI4hO11nQiOd0IZ+iXCy+L+EUg6MCENPRxAK0l R9aFloWQ1V1OY6oz/dYBpShOK+BiinYT2B+6x8wnwlf5KprUZlP41gMPdq3f+Lp3RdM8 qjG6PHWzsdskq9pfIYIxIC0fGirkCiaIagaT6g4MtyZfaXbIx7S4m57nCnC1ube3emAW ExDg== X-Forwarded-Encrypted: i=1; AJvYcCXVE50ZEPrv2zmqle6Gr5mRDsUuEZ9SjYT5KE9eKFoZxdwvuN7QG8H63swDWCjUslDmWmtTp+rk+Bo6wk4=@vger.kernel.org X-Gm-Message-State: AOJu0YyuSiHnY2yWmYLzC2z2EKvjCMyPFMHcMB6g43QXAJdShMC1a3wc qBLuMxsht8m4uf5IiKHfiCAcb2wd0chy92ChGSo7wC5kghKQsk4zALL+ X-Gm-Gg: AY/fxX4SCtPn7ttFivttbHof5V5HSXu1Qj5/DNHjdSgguglVAgnRtRGbrFd0I11Vewp 3QyUDkYFMq/ZBDoRq+udOO35XIWguoNj7xsN9Km83Z/qhviVSFeEWDUaLc2uKmWFOQzIXRXOh3O NvUVx2yaYsTnT//OHChs7QD0Cowp4WhxtuccX4Rv+VqTaVqtpHnyBuZYKKmfS+ZWChNFpA1ELd6 U9HWmGYoTnkwH4Hn2bqUIkoTzOoPxCgPNktupdbYVwXtQmpUzTi0zTNpIULEdJuzndvm55GjmYn hu4apDMcpinSAhwTjvKXCTKGDMbTYbN7GXDFFO8UgOKBepksFm36mrWnWvLkiEN8W9vcZYV17ZN JmjOMmVZRQIEO0NVaBV6lsw6V9AeAGZOr1wnScECmww6+BlQT4aYT6JgHU5kN1MNerxGFw7cSFW czdGww2s1vwGAJUvhKp8uqJdaV95RrYOCRJ0XH4DSoijE5q2xIyhBVEi0NXQ7bDlocmW2k9JqzO uyhAhczLROjULe5P+g= X-Google-Smtp-Source: AGHT+IGzep9ECZOwaPNpiBb0/p/BCg7/qLnqLf0vDlNHlWftA8GOgxq/kseyAt169pupxPA5dddF1A== X-Received: by 2002:a05:600c:35d4:b0:477:7b16:5fa6 with SMTP id 5b1f17b1804b1-47a8f89c85dmr179474045e9.3.1765895516300; Tue, 16 Dec 2025 06:31:56 -0800 (PST) Received: from [192.168.1.3] (92.40.200.39.threembb.co.uk. [92.40.200.39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f4ef38bsm259154525e9.0.2025.12.16.06.31.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 06:31:55 -0800 (PST) Message-ID: <2c1656ff-cba9-4122-a414-d22958f5857b@gmail.com> Date: Tue, 16 Dec 2025 14:31:52 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: [PATCH] drm/msm/dp: Enable support for eDP v1.4+ link rates table To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?J=C3=A9r=C3=B4me_de_Bretagne?= , Steev Klimaszewski References: <20251214-drm-msm-edp14-v1-1-45de8c168cec@gmail.com> Content-Language: en-US From: Dale Whinham In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/12/2025 22:15, Dmitry Baryshkov wrote: > I'd suggest following i915 and writing DP_LANE_COUNT_SET before > DP_LINK_BW_SET. Thank you - made this change for v2. >> + /* For eDP v1.4+, parse the SUPPORTED_LINK_RATES table */ >> + if (link_info->revision >= DP_DPCD_REV_14) { > > No, eDP has separate versioning register. DP revision != eDP revision. You're absolutely right, this was a mistake. Does something like this seem reasonable for v2? if (msm_dp_panel->dpcd[DP_EDP_CONFIGURATION_CAP]) { u8 edp_rev; rc = drm_dp_dpcd_read_byte(panel->aux, DP_EDP_DPCD_REV, &edp_rev); if (rc) return rc; if (edp_rev >= DP_EDP_14) { // parse the rates // ... } } -- Best regards, Dale