From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED14C001DF for ; Wed, 2 Aug 2023 10:11:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232818AbjHBKLV (ORCPT ); Wed, 2 Aug 2023 06:11:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232789AbjHBKLS (ORCPT ); Wed, 2 Aug 2023 06:11:18 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2829F11F for ; Wed, 2 Aug 2023 03:11:15 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DEB35113E; Wed, 2 Aug 2023 03:11:57 -0700 (PDT) Received: from [10.57.89.109] (unknown [10.57.89.109]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 67A013F6C4; Wed, 2 Aug 2023 03:11:13 -0700 (PDT) Message-ID: <2c1894c4-c0e3-ea90-d5f6-24c3ed8c0e4f@arm.com> Date: Wed, 2 Aug 2023 11:11:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V2 2/4] arm_pmu: acpi: Add a representative platform device for TRBE To: Anshuman Khandual , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Mark Rutland , linux-kernel@vger.kernel.org References: <20230801094052.750416-1-anshuman.khandual@arm.com> <20230801094052.750416-3-anshuman.khandual@arm.com> <20230801145111.GF26253@willie-the-truck> <505c6b25-d9e8-d7b3-1a0d-2b51e45fb66a@arm.com> From: Suzuki K Poulose In-Reply-To: <505c6b25-d9e8-d7b3-1a0d-2b51e45fb66a@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2023 02:07, Anshuman Khandual wrote: > > > On 8/1/23 20:21, Will Deacon wrote: >> On Tue, Aug 01, 2023 at 03:10:50PM +0530, Anshuman Khandual wrote: >>> diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h >>> index a0801f68762b..7ec26d21303d 100644 >>> --- a/include/linux/perf/arm_pmu.h >>> +++ b/include/linux/perf/arm_pmu.h >>> @@ -187,5 +187,6 @@ void armpmu_free_irq(int irq, int cpu); >>> #endif /* CONFIG_ARM_PMU */ >>> >>> #define ARMV8_SPE_PDEV_NAME "arm,spe-v1" >>> +#define ARMV8_TRBE_PDEV_NAME "arm-trbe-acpi" >> >> Why is the TRBE name formatted differently to the SPE one? > > Nothing specific, although "arm,spe-v1" seemed more like a DT naming > scheme. But could change the name as "arm,trbe-v1" to be in sync with > SPE here. Do we really need v1 ? I would leave it as arm,trbe Suzuki