mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Zqiang <qiang.zhang@linux.dev>
Cc: frederic@kernel.org, neeraj.upadhyay@kernel.org,
	joelagnelf@nvidia.com, urezki@gmail.com, boqun@kernel.org,
	rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcutorture: Synchronously wait for all rcu_torture_irq() callbacks to complete
Date: Thu, 27 Aug 2026 10:28:51 -0700	[thread overview]
Message-ID: <2c1dde18-2e5c-4d20-b464-e16196c9efe7@paulmck-laptop> (raw)
In-Reply-To: <20260824092427.31303-1-qiang.zhang@linux.dev>

On Mon, Aug 24, 2026 at 05:24:27PM +0800, Zqiang wrote:
> The rcu_torture_reader() drives RCU readers from interrupt context via
> smp_call_function_single(cpu, rcu_torture_irq, NULL, 0) with wait=0, to
> runs rcu_torture_irq() on a remote CPU. this is async, nothing waits for
> the remote handler to run.
> 
> On shutdown, torture_stop_kthread() only waits for each reader kthread to
> return, and the reader's timer_delete_sync() only drains its timer. Neither
> waits for a rcu_torture_irq() which still pending or executing on a remote
> CPU, so it can run after all readers have exited and rcu_torture_cleanup()
> has already advanced.
> 
> 1. rcu_torture_irq() may issue cur_ops->call(rhp, rcu_torture_timer_cb)
>    after cur_ops->cb_barrier() has been waiting for all outstanding
>    callbacks complete. once the module is unloaded, fires into freed
>    module text, a use-after-free happen.
> 
> 2. rcu_torture_irq() may still be inside rcu_torture_one_read(), holding
>    a read-side critical section, when cur_ops->cleanup() tears the flavor
>    down (e.g. cleanup_srcu_struct()), triggering an active-reader warning
>    or use-after-free of the torn-down structure.
> 
> This commit therefore issue a kick_all_cpus_sync() after all readers
> kthread have returned and before cur_ops->cb_barrier(), synchronous IPI
> round trip to every CPU guarantees that every rcu_torture_irq() which
> previously issued by any reader has completed.
> 
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>

Good catch!  Queued for further review and testing, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/rcutorture.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 4b4d9c70e827..f177ba9cb604 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -4476,6 +4476,8 @@ rcu_torture_cleanup(void)
>  		for (i = 0; i < nrealreaders; i++)
>  			torture_stop_kthread(rcu_torture_reader,
>  					     reader_tasks[i]);
> +		if (irqreader && cur_ops->irq_capable)
> +			kick_all_cpus_sync();
>  		kfree(reader_tasks);
>  		reader_tasks = NULL;
>  	}
> -- 
> 2.17.1
> 

      reply	other threads:[~2026-08-27 17:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24  9:24 Zqiang
2026-08-27 17:28 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c1dde18-2e5c-4d20-b464-e16196c9efe7@paulmck-laptop \
    --to=paulmck@kernel.org \
    --cc=boqun@kernel.org \
    --cc=frederic@kernel.org \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.upadhyay@kernel.org \
    --cc=qiang.zhang@linux.dev \
    --cc=rcu@vger.kernel.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®