From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Om Prakash Singh <quic_omprsing@quicinc.com>, konrad.dybcio@linaro.org
Cc: agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
davem@davemloft.net, devicetree@vger.kernel.org,
herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, marijn.suijten@somainline.org,
robh+dt@kernel.org, vkoul@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: crypto: qcom,prng: Add SM8450
Date: Sat, 19 Aug 2023 09:45:09 +0200 [thread overview]
Message-ID: <2c208796-5ad6-c362-dabc-1228b978ca1d@linaro.org> (raw)
In-Reply-To: <20230818161720.3644424-1-quic_omprsing@quicinc.com>
On 18/08/2023 18:17, Om Prakash Singh wrote:
> Instead of having SoC name "qcom,sm8450-prng-ee" we could use "qcom,rng-ee" as
> new IP core is not longer pseudo random number generator. so "prng" can be
> changed to "rng". Clock configuration is not needed on sm8550 as well. So it is
> better to use generic compatible string.
I am not sure if I understand your point. You mean drop "p" in "prng" or
drop specific compatible? The first depends in the block - if it is
still pseudo. The second - why? That's contradictory to what is in the
guidelines and what we have been pushing for very long time. Going
against guidelines would require proper justification (and not some
usual justification "I don't need it", because we talked about this many
many times). One should not bring downstream poor practices to upstream,
but the other way. You should fix downstream code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-19 7:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 20:50 [PATCH 0/3] Introduce PRNG on SM8450 Konrad Dybcio
2023-08-11 20:50 ` [PATCH 1/3] dt-bindings: crypto: qcom,prng: Add SM8450 Konrad Dybcio
2023-08-13 9:48 ` Conor Dooley
2023-08-18 16:17 ` Om Prakash Singh
2023-08-19 7:45 ` Krzysztof Kozlowski [this message]
2023-08-21 0:52 ` Om Prakash Singh
2023-08-21 6:07 ` Krzysztof Kozlowski
2023-08-22 4:27 ` Om Prakash Singh
2026-01-20 10:41 ` Konrad Dybcio
2023-08-11 20:50 ` [PATCH 2/3] crypto: qcom-rng: Make the core clock optional regardless of ACPI presence Konrad Dybcio
2023-08-14 2:39 ` Bjorn Andersson
2023-08-11 20:50 ` [PATCH 3/3] arm64: dts: qcom: sm8450: Add PRNG Konrad Dybcio
2023-08-14 3:27 ` (subset) [PATCH 0/3] Introduce PRNG on SM8450 Bjorn Andersson
2023-08-18 10:26 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c208796-5ad6-c362-dabc-1228b978ca1d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_omprsing@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®