From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735AbdGEMZL (ORCPT ); Wed, 5 Jul 2017 08:25:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33004 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbdGEMZK (ORCPT ); Wed, 5 Jul 2017 08:25:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 036F04E4CA Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=david@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 036F04E4CA Subject: Re: [PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY_EV exits To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1499251124-35803-1-git-send-email-pbonzini@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <2c21b3a2-da45-7f87-776c-ebca59eb4e87@redhat.com> Date: Wed, 5 Jul 2017 14:25:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1499251124-35803-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 05 Jul 2017 12:25:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.07.2017 12:38, Paolo Bonzini wrote: > This exit ended up being reported, but the currently exposed data does not provide > much of a starting point for debugging. In the reported case, the vmexit was > an EPT misconfiguration (MMIO access). Let userspace report ethe exit qualification > and, if relevant, the GPA. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/vmx.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 6dcc4873e435..4be80c3ac24d 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -8408,9 +8408,15 @@ static int vmx_handle_exit(struct kvm_vcpu *vcpu) > exit_reason != EXIT_REASON_TASK_SWITCH)) { > vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR; > vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_DELIVERY_EV; > - vcpu->run->internal.ndata = 2; > + vcpu->run->internal.ndata = 3; > vcpu->run->internal.data[0] = vectoring_info; > vcpu->run->internal.data[1] = exit_reason; > + vcpu->run->internal.data[2] = vcpu->arch.exit_qualification; > + if (exit_reason == EXIT_REASON_EPT_MISCONFIG) { > + vcpu->run->internal.ndata++; > + vcpu->run->internal.data[3] = > + vmcs_read64(GUEST_PHYSICAL_ADDRESS); vcpu->run->internal.data[vcpu->run->internal.ndata++] = ... So we don't have to name the position explicitly. Whatever you prefer. Reviewed-by: David Hildenbrand > + } > return 0; > } > > -- Thanks, David