mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: tli012345@163.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	tangpengpeng <tangpengpeng@higon.com>
Subject: Re: [PATCH] net: fix amd-xgbe flow-control issue
Date: Thu, 26 Jul 2018 08:13:28 -0500	[thread overview]
Message-ID: <2c28089a-7a2b-c279-2905-b6a533b87932@amd.com> (raw)
In-Reply-To: <20180726064516.56740-1-tli012345@163.com>

On 7/26/2018 1:45 AM, tli012345@163.com wrote:
> From: tangpengpeng <tangpengpeng@higon.com>
> 
> If we enable or disable xgbe flow-control by ethtool ,
> it does't work.Because the parameter is not properly
> assigned,so we need to adjust the assignment order
> of the parameters.
> 
> Signed-off-by: tangpengpeng <tangpengpeng@higon.com>

You should add a Fixes tag as this bug was introduced with commit:

  c1ce2f77366b ("amd-xgbe: Fix flow control setting logic")

And since that commit was introduced in 4.2, you'll want to ask David to
push this to stable (4.4 and higher).

With that,

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 4b5d625de8f0..8a3a60bb2688 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -1111,14 +1111,14 @@ static void xgbe_phy_adjust_link(struct xgbe_prv_data *pdata)
>  
>  		if (pdata->tx_pause != pdata->phy.tx_pause) {
>  			new_state = 1;
> -			pdata->hw_if.config_tx_flow_control(pdata);
>  			pdata->tx_pause = pdata->phy.tx_pause;
> +			pdata->hw_if.config_tx_flow_control(pdata);
>  		}
>  
>  		if (pdata->rx_pause != pdata->phy.rx_pause) {
>  			new_state = 1;
> -			pdata->hw_if.config_rx_flow_control(pdata);
>  			pdata->rx_pause = pdata->phy.rx_pause;
> +			pdata->hw_if.config_rx_flow_control(pdata);
>  		}
>  
>  		/* Speed support */
> 

  reply	other threads:[~2018-07-26 13:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26  6:45 tli012345
2018-07-26 13:13 ` Tom Lendacky [this message]
2018-07-26 16:30 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c28089a-7a2b-c279-2905-b6a533b87932@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tangpengpeng@higon.com \
    --cc=tli012345@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®