From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752294AbdLFWdC (ORCPT <rfc822;w@1wt.eu>);
        Wed, 6 Dec 2017 17:33:02 -0500
Received: from fllnx210.ext.ti.com ([198.47.19.17]:35713 "EHLO
        fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751827AbdLFWdA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Dec 2017 17:33:00 -0500
Subject: Re: [PATCH] dt: bindings: as3645a: Fix the example node
To: Rob Herring <robh@kernel.org>
CC: <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
        <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-leds@vger.kernel.org>
References: <20171205133637.30022-1-dmurphy@ti.com>
 <20171206215204.7qyjjd2oue7n7l37@rob-hp-laptop>
From: Dan Murphy <dmurphy@ti.com>
Message-ID: <2c2b1fc0-6156-2897-b597-6911fee64556@ti.com>
Date: Wed, 6 Dec 2017 16:32:36 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171206215204.7qyjjd2oue7n7l37@rob-hp-laptop>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Rob

On 12/06/2017 03:52 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>> Fix the address-cells and size-cells example node
>> to reflect to the correct representation.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> index fdc40e354a64..8a49ccfec29b 100644
>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> @@ -59,8 +59,8 @@ Example
>>  =======
>>  
>>  	as3645a@30 {
>> -		#address-cells: 1
>> -		#size-cells: 0
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>>  		reg = <0x30>;
>>  		compatible = "ams,as3645a";
> 
> Convention is also we put compatible first.
> 

OK I will move that too for v2.

Can that be in the same patch or do you want a separate patch?

Dan

>>  		flash@0 {
>> -- 
>> 2.15.0.124.g7668cbc60
>>


-- 
------------------
Dan Murphy