From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC34E29D273 for ; Mon, 6 Apr 2026 15:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775489711; cv=none; b=oyY/N8uf7JytpzDlyT5kgR6F5X6RpyGXzP74JRL5ByP7hVq/WKvTcjeE9qxige6es4YPbvsFstSGFZF9UeUGsdbuNOgbOcAeQMSmO/xy5g50WG/fsscvYV/4e9bSbGqNk/KPujykjOooAZfpPM2DkdwE95mDz5fYXg3+uav58Ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775489711; c=relaxed/simple; bh=PeJ0qfne2uhHQErbrACwR6uosvy5/ctshzcF8Zu+wY8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qU513ShHpvmHJJQcspBSfB7+AJt6op6POOTX8Sspoei9EdIGLP9Lxjn9ahqNGIcGV5mFdjm5nfXNal8atbVAOCOi60o4RSWKC1XXoudyzkhH9Ee1W9ty1f4sVAldBe7yKrr+2162uG3McFeeioRkJY6y99BJfILVQ69uBUKtYVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=IYvyOMIQ; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="IYvyOMIQ" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CC6BF240104 for ; Mon, 6 Apr 2026 17:35:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017; t=1775489707; bh=FrvJ3c1jcb/A4OobC0soBysKl/qEfJVZNNMZlqp6IvY=; h=Message-ID:Subject:From:To:Cc:Date:Autocrypt:Content-Type: MIME-Version:OpenPGP:From; b=IYvyOMIQiDPwWU4AqIOrMbKcVj+OBgx1jibYVXGOlVXqhx1ls2l26Isq00za+Si/Y ydLMLZPNwSI+LkMLvMiua99IHQxDb6XXXR781UX7LUk/IxTJ+j+JnoWeyAfl9JLNed km/ePf2GNtSBuPWk+lRrxxN0Bk2hkDjWgJxEtGs1cbSjhV/WGiWtHDcPgQ0enUJInu i8kaqWt+bk06wAPJ1q+fSwQNoP7NgtXzNmIlL1sD+x5XRjVwlLK27ugn7g6QXrHi60 y5f7iPQUAQeFez+Uu4FJ6q39SufI7eZKFmb6OeJ5MPboXoNgOOI+yYvfLbmS/gdBTC riPLCvf0pVQ7A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4fqD0m2GPlz9rxF; Mon, 6 Apr 2026 17:35:04 +0200 (CEST) Message-ID: <2c3ebaeb21755b037a7fcb80323c48e75d904774.camel@posteo.de> Subject: Re: [PATCH v6 2/2] dt-bindings: embedded-controller: Add synology microp devices From: Markus Probst To: Krzysztof Kozlowski Cc: Hans de Goede , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?ISO-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Date: Mon, 06 Apr 2026 15:35:06 +0000 In-Reply-To: <0b785ee4-7d15-4a9d-a820-20ea15225ea1@kernel.org> References: <20260405-synology_microp_initial-v6-0-08fde474b6c9@posteo.de> <20260405-synology_microp_initial-v6-2-08fde474b6c9@posteo.de> <20260406-ancient-amethyst-poodle-1ba0b2@quoll> <63fbd1a5cddc5b79302056fa7b01a790aca8ba8e.camel@posteo.de> <0b785ee4-7d15-4a9d-a820-20ea15225ea1@kernel.org> Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=mQINBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93 qReNLkOWguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVA m76Ww+/pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt 9k5JARhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbm fAjaoT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwT jRQxBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1 J+FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN 6OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJCX CeMe4BO4iaxUQARAQABtCdNYXJrdXMgUHJvYnN0IDxtYXJrdXMucHJvYnN0QHBvc3Rlby5kZT6JAl QEEwEIAD4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AWIQSCdBjE9KxY53IwxHM0dh/4561 D0gUCaIZ9HQIZAQAKCRA0dh/4561D0pKmD/92zsCfbD+SrvBpNWtbit7J9wFBNr9qSFFm2n/65qen NNWKDrCzDsjRbALMHSO8nigMWzjofbVjj8Nf7SDcdapRjrMCnidS0DuW3pZBo6W0sZqV/fLx+AzgQ 7PAr6jtBbUoKW/GCGHLLtb6Hv+zjL17KGVO0DdQeoHEXMa48mJh8rS7VlUzVtpbxsWbb1wRZJTD88 ALDOLTWGqMbCTFDKFfGcqBLdUT13vx706Q29wrDiogmQhLGYKc6fQzpHhCLNhHTl8ZVLuKVY3wTT+ f9TzW1BDzFTAe3ZXsKhrzF+ud7vr6ff9p1Zl+Nujz94EDYHi/5Yrtp//+N/ZjDGDmqZOEA86/Gybu 6XE/v4S85ls0cAe37WTqsMCJjVRMP52r7Y1AuOONJDe3sIsDge++XFhwfGPbZwBnwd4gEVcdrKhnO ntuP9TvBMFWeTvtLqlWJUt7n8f/ELCcGoO5acai1iZ59GC81GLl2izObOLNjyv3G6hia/w50Mw9MU dAdZQ2MxM6k+x4L5XeysdcR/2AydVLtu2LGFOrKyEe0M9XmlE6OvziWXvVVwomvTN3LaNUmaINhr7 pHTFwDiZCSWKnwnvD2+jA1trKq1xKUQY1uGW9XgSj98pKyixHWoeEpydr+alSTB43c3m0351/9rYT TTi4KSk73wtapPKtaoIR3rOFHLQXbWFya3VzLnByb2JzdEBwb3N0ZW8uZGWJAlEEEwEIADsWIQSCd BjE9KxY53IwxHM0dh/4561D0gUCaIO9eAIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCR A0dh/4561D0oHZEACEmk5Ng9+OXoVxJJ+c9slBI2lYxyBO84qkWjoJ/0GpwoHk1IpyL+i+kF1Bb7y Hx9Tiz8ENYX7xIPTZzS8hXs1ksuo76FQUyD6onA/69xZIrYZ0NSA5HUo62qzzMSZL7od5e12R6OPR lR0PIuc4ecOGCEq3BLRPfZSYrL54tiase8HubXsvb6EBQ8jPI8ZUlr96ZqFEwrQZF/3ihyV6LILLk geExgwlTzo5Wv3piOXPTITBuzuFhBJqEnT25q2j8OumGQ+ri8oVeAzx24g1kc11pwpR0sowfa5MvZ WrrBcaIL7uJfR/ig7FyGnTQ1nS3btf3p0v8A3fc4eUu/K2No3l2huJp3+LHhCmpmeykOhSB63Mj3s 3Q87LD0HE0HBkTEMwp+sD97ZRpO67H5shzJRanUaDTb/mREfzpJmRT1uuec0X2zItL7a6itgMJvYI KG29aJLX3fTzzVzFGPgzVZYEdhu4y53p0qEGrrC1JtKR6DRPE1hb/OdWOkjmJ75+PPLD9U5IuRd6y sHJWsEBR1F0wkMPkEofWsvMYJzWXx/rvTWO8N4D6HigTgBXAXNgbc3IHpHlkvKoBJptv6DRVRtIrz 0G0cfBY0Sm7he4N2IYDWWdGnPBZ3rlLSdj5EiBU2YWgIgtLrb8ZNJ3ZlhYluGnBJDGRqy2jC9s1jY 66sLA9rQZMHhJTzMyIDwweGlvMzJAcG9zdGVvLmV1PokCbQQTAQgAVxYhBIJ0GMT0rFjncjDEczR2 H/jnrUPSBQJpa71VGxSAAAAAAAQADm1hbnUyLDIuNSsxLjExLDIsMgIbAwULCQgHAgIiAgYVCgkIC wIEFgIDAQIeBwIXgAAKCRA0dh/4561D0gKJD/9uOQKYlsDoQX65Gd0LiMT0C+5vXgr3VI0PHDOwcv 51fJ3A1vNyPZRFPGrz8+mDEXUQOF/INfnz5Tu1QHwf+iYcWcTGAN/FHgVR6ET6VBNU2hJaKhu+Ggo kjYyJTOvyX+3yNRUfSny0GjTjIPuPTErjqmHF+BtjXslpgwqnNMznf3lRIuUjRORupos6p3k1DndE 5vzUTmXSvMyXyOD2KhBl/kL76k0bHYyAQytZPag12pltrtFbA/r2phDGN2si8PooDT99bSTJjaM45 MTAAHbHKJfvgfK41bNFD5mMtpWpL195XRtS0Nrxdg3PaYBxN5gtTG0RyZfpYRlkdEhm+jj/8RxuSG i/qdhRdbiI7K2IELWeQVHSNDi9JabR/UzlR4NSnhfAjRIVlRM+eFbUl8XwxwVrAkojF5IraH2qRvg VCmuFsHUW07FUlrDrzpjXsD73cKppoFGDCdDR0BHJepXbFLS9+AqkT+guRJlnCTg2p+TQtnbwPgKp Vj98JixovCl99zRYTsL2bRNU5+q8iET65VMJ1ydyNanvLd5vI/NqDkXhlXLsGmdaDTtu4R21PkToX dQNGrZ91M9nlIBKw8Y7c7xZ4098qX2b8JX/CxD+gC1r4C8vuA3GkhFLx+KlkON7LyiJPkrePp6Qky jfGillcaQOqFZ3WwVqyzG1BUfTow== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-aBPuCxcB1QSZeRtglttO" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt --=-aBPuCxcB1QSZeRtglttO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2026-04-06 at 16:42 +0200, Krzysztof Kozlowski wrote: > On 06/04/2026 16:22, Markus Probst wrote: > > On Mon, 2026-04-06 at 09:59 +0200, Krzysztof Kozlowski wrote: > > > On Sun, Apr 05, 2026 at 07:36:29PM +0200, Markus Probst wrote: > > > > Add the Synology Microp devicetree bindings. Those devices are > > > > microcontrollers found on Synology NAS devices. They are connected = to a > > > > serial port on the host device. > > > >=20 > > > > Those devices are used to control certain LEDs, fan speeds, a beepe= r, to > > > > handle buttons, fan failures and to properly shutdown and reboot th= e > > > > device. > > > >=20 > > > > This includes the following compatible ids: > > > > - synology,ds923p-microp > > > > - synology,ds918p-microp > > > > - synology,ds214play-microp > > > > - synology,ds225p-microp > > > > - synology,ds425p-microp > > > > - synology,ds710p-microp > > > > - synology,ds1010p-microp > > > > - synology,ds723p-microp > > > > - synology,ds1522p-microp > > > > - synology,rs422p-microp > > > > - synology,ds725p-microp > > > > - synology,ds118-microp > > > > - synology,ds124-microp > > > > - synology,ds223-microp > > > > - synology,ds223j-microp > > > > - synology,ds1823xsp-microp > > > > - synology,rs822p-microp > > > > - synology,rs1221p-microp > > > > - synology,rs1221rpp-microp > > > > - synology,ds925p-microp > > > > - synology,ds1525p-microp > > > > - synology,ds1825p-microp > > >=20 > > > Drop, we see this in the diff. > > A prior review commit suggested I should add them [1]. > > So only synology,ds923p-microp in the Subject then? >=20 > I do not see how this list resolves my comment. Really, explain my how > listing part of binding answers WHY they are not compatible? I might have misunderstood it then, my apologies for that. >=20 >=20 > >=20 > > [1] > > https://lore.kernel.org/all/20260330-delicate-sassy-mayfly-ebcca7@quoll= / > >=20 > > >=20 > > > >=20 > > > > Signed-off-by: Markus Probst > > > > --- > > > > .../synology,ds923p-microp.yaml | 112 +++++++++= ++++++++++++ > > > > MAINTAINERS | 1 + > > > > 2 files changed, 113 insertions(+) > > > >=20 > > > > diff --git a/Documentation/devicetree/bindings/embedded-controller/= synology,ds923p-microp.yaml b/Documentation/devicetree/bindings/embedded-co= ntroller/synology,ds923p-microp.yaml > > > > new file mode 100644 > > > > index 000000000000..4518e9b74be1 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/embedded-controller/synolog= y,ds923p-microp.yaml > > > > @@ -0,0 +1,112 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/embedded-controller/synology,ds= 923p-microp.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Synology NAS on-board Microcontroller > > > > + > > > > +maintainers: > > > > + - Markus Probst > > > > + > > > > +description: | > > > > + Synology Microp is a microcontroller found in Synology NAS devic= es. > > > > + It is connected to a serial port on the host device. > > > > + > > > > + It is necessary to properly shutdown and reboot the NAS device a= nd > > > > + provides additional functionality such as led control, fan speed= control, > > > > + a beeper and buttons on the NAS device. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - synology,ds923p-microp > > > > + - synology,ds918p-microp > > > > + - synology,ds214play-microp > > > > + - synology,ds225p-microp > > > > + - synology,ds425p-microp > > > > + - synology,ds710p-microp > > > > + - synology,ds1010p-microp > > > > + - synology,ds723p-microp > > > > + - synology,ds1522p-microp > > > > + - synology,rs422p-microp > > > > + - synology,ds725p-microp > > > > + - synology,ds118-microp > > > > + - synology,ds124-microp > > > > + - synology,ds223-microp > > > > + - synology,ds223j-microp > > > > + - synology,ds1823xsp-microp > > > > + - synology,rs822p-microp > > > > + - synology,rs1221p-microp > > > > + - synology,rs1221rpp-microp > > > > + - synology,ds925p-microp > > > > + - synology,ds1525p-microp > > > > + - synology,ds1825p-microp > > >=20 > > > So we already talked about this and you were told to use compatibilit= y. > > > Your driver clearly states several of these are compatible, so I am > > > confused that I do not see it expressed here. > > The driver does not have all functionality implemented yet. >=20 > Either this drivers works or not. If it works, explain me how they are > not compatible. I will use my ds923+ as baseline here. Known relevant differences that make them not compatible: ds918p: - no system current sensor ds214play: - has an cpu fan - has only 1 fan - no system current sensor ds225p: - has usb copy led and button - has only 1 fan - no system current sensor ds415p: - no system current sensor ds710p: - has esata led - has only 1 fan - no system current sensor ds1010p: - has alert led controlled via microp - no system current sensor ds723p - has only 1 fan ds725p: - has only 1 fan - no system current sensor ds1522p: rs422p: - power led is green - has 3 fans rs822p: - power led is green - supports fan rpm report via an adt7475 chip and therefore does not have gpios for fan failure - no system current sensor ds118, ds124, ds223j: - different shutdown behaviour - has only 1 fan - no system current sensor ds223: - different shutdown behaviour - has usb copy led and button - has only 1 fan - no system current sensor rs1221p, rs1221rpp: - power led is green - supports fan rpm report via an adt7475 chip and therefore does not have gpios for fan failure - no system current sensor ds925p, ds1525p, ds1825p, ds1823xsp: - supports fan rpm report via an adt7475 chip and therefore does not have gpios for fan failure - no system current sensor Thanks - Markus Probst >=20 > >=20 > > A few examples of differences not yet visible in the driver: > > - synology,ds214play-microp is the only model in the current list to > > have an cpu fan > > - 4 of the models are arm based and need a different shutdown behaviour > > - different amount of fans (already present in the binding via fan- > > failure-gpios) > >=20 > > I could try to group them together, but Synology does not document the > > exact difference between them. > >=20 > > As Rob mentioned [2], I need to be able to handle unexpected > > differences without qurik properties. >=20 > I did not object that. >=20 >=20 > Best regards, > Krzysztof --=-aBPuCxcB1QSZeRtglttO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJPBAABCAA5FiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IFAmnT0p4bFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyAAoJEDR2H/jnrUPSuOoP/1/Q5Sk0NSfn22D0NXeN bZxqQBuALD34n4oOriVB22NiaVhelIpkMnRgzNvgup+TVKhNxASfWeC1c39VEQTo oV63H5f3Frth3IKjmu646kHd+pdyFzTAE3hBycBYsN/pxEuLheYUb5IbgQPJQYzW qG8MyGZJx/Fxh7LGsVmIta5qjV2h7Bjt6akYolQ4n2cphKDnklowW8mbrvoQSKgz hbRp1IkuKGZ+CjsyBjdQBKg904HUVHA1FlKoYo7GerULtiBexasqSgvW8u7/uMLO SAfYzL4C+d9OX82HJGNM72N5ED2qDh52yKEYaA2vftQnw9TIFo6iyLFvBlAx9lgT sA9+Ch1O5YxHN7HNPm+tpw4We1zrnM62J5dZCDcZVcVbQtqnPB32TcQVLYsK6sto h1uPgCj3V6QLC7Po9J4cNkcuZMJnBI64j9bZonSdcMtgv+n9NhoGUjxOmvdrjmV1 8eSk+ZkCPKlJwrw7z9ctxxRc0s5J4RvHwjuNisrf0kdV1gIxAhdgEafzfUHQsHZi aQRJfVowhmsItw1BWXdaXGtuxuC921HzKRKXjlonpvzThPU4zP6LYFqnpyIW33/Z KXR0LvmCuEaiZNItVPw6L5ed0HX1ICW1DhrU9U1THgg2/Nk1niejyxehSPVbKEvo buj1qsnrrO7vJsa3BNG2NF9W =6T3R -----END PGP SIGNATURE----- --=-aBPuCxcB1QSZeRtglttO--