From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41CFE273FD; Mon, 30 Sep 2024 17:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727716577; cv=none; b=QNY8aPMzahf29hqCd93dLUxHmissJUer1JeElWacxmiMG7lavtuDX4GYvMIzLypRSaIDaSSOGw/066nLmFOT2pkW78cbS2NYoiOWkr1KuX6HkjfPJ6dXsBBWZ6CMuYT7cuqVUPBOuOwfKmMpIYiycW6fPN161z/g9un1R4AFFbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727716577; c=relaxed/simple; bh=LUUN+KQTS2A0UDw3fO12Gaa2xVVfygL011e9t2dG8nA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=qqU+WWmKKLD0QNRDsRxAPlzvFF3XtB4fviaeK3OY9QbI7d3ao5LL51WuJRecJWVBBu0kVTLwejQypHY0a8/ivdfNNkWYLAr9hHZ+Q3UipWntGoHQfOGGdmTR/c2nY63vpTxN47F4w+s/w5U+lzJ9MibzpUMYz4fJlppS4m46g8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.2.100] (213.87.154.82) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Mon, 30 Sep 2024 20:16:03 +0300 Message-ID: <2c3f3d6c-63a7-4ddd-b32d-3b2ae6988ce2@omp.ru> Date: Mon, 30 Sep 2024 20:16:03 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next PATCH 02/11] net: ravb: Disable IP header RX checksum offloading To: Paul Barker , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: Paul Barker , Geert Uytterhoeven , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Biju Das , Claudiu Beznea , , , References: <20240930160845.8520-1-paul@pbarker.dev> <20240930160845.8520-3-paul@pbarker.dev> Content-Language: en-US From: Sergey Shtylyov Organization: Open Mobile Platform In-Reply-To: <20240930160845.8520-3-paul@pbarker.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 09/30/2024 16:58:49 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 19 X-KSE-AntiSpam-Info: Lua profiles 188099 [Sep 30 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 35 0.3.35 d90443ea3cdf6e421a9ef5a0a400f1251229ba23 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 213.87.154.82 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 19 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 09/30/2024 17:02:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 9/30/2024 2:10:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 9/30/24 19:08, Paul Barker wrote: > From: Paul Barker > > For IPv4 packets, the header checksum will always be checked in software > in the RX path (inet_gro_receive() calls ip_fast_csum() unconditionally) > so there is no advantage in asking the hardware to also calculate this > checksum. > > Signed-off-by: Paul Barker Reviewed-by: Sergey Shtylyov [...] MBR, Sergey