From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Chris Lew <quic_clew@quicinc.com>
Cc: Alex Elder <elder@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 4/4] soc: qcom: aoss: Tidy up qmp_send() callers
Date: Mon, 31 Jul 2023 10:23:56 +0200 [thread overview]
Message-ID: <2c43966d-33da-107a-ff47-370e3e27a99a@linaro.org> (raw)
In-Reply-To: <20230731041013.2950307-5-quic_bjorande@quicinc.com>
On 31.07.2023 06:10, Bjorn Andersson wrote:
> With qmp_send() handling variable length messages and string formatting
> he callers of qmp_send() can be cleaned up to not care about these
> things.
>
> Drop the QMP_MSG_LEN sized buffers and use the message formatting, as
> appropriate.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
If Alex is okay with that going through qcom:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
One nit below.
[...]
> - snprintf(buf, sizeof(buf),
> - "{class: volt_flr, event:zero_temp, res:%s, value:%s}",
> - qmp_cdev->name,
> - cdev_state ? "on" : "off");
> -
> - ret = qmp_send(qmp_cdev->qmp, buf);
> -
> + ret = qmp_send(qmp_cdev->qmp, "{class: volt_flr, event:zero_temp, res:%s, value:%s}",
There's a space after the first colon but not after the subsequent
ones.
Konrad
prev parent reply other threads:[~2023-07-31 8:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 4:10 [PATCH 0/4] soc: qcom: aoss: Introduce debugfs interface and cleanup things Bjorn Andersson
2023-07-31 4:10 ` [PATCH 1/4] soc: qcom: aoss: Move length requirements from caller Bjorn Andersson
2023-07-31 15:10 ` Simon Horman
2023-07-31 21:29 ` Chris Lew
2023-07-31 23:10 ` Bjorn Andersson
2023-07-31 23:46 ` Chris Lew
2023-07-31 4:10 ` [PATCH 2/4] soc: qcom: aoss: Add debugfs interface for sending messages Bjorn Andersson
2023-07-31 8:15 ` Konrad Dybcio
2023-07-31 16:01 ` Bjorn Andersson
2023-07-31 8:21 ` Andrew Lunn
2023-07-31 15:39 ` Bjorn Andersson
2023-08-01 8:45 ` Andrew Lunn
2023-07-31 15:08 ` Simon Horman
2023-08-01 4:41 ` Pavan Kondeti
2023-07-31 4:10 ` [PATCH 3/4] soc: qcom: aoss: Format string in qmp_send() Bjorn Andersson
2023-07-31 8:20 ` Konrad Dybcio
2023-07-31 4:10 ` [PATCH 4/4] soc: qcom: aoss: Tidy up qmp_send() callers Bjorn Andersson
2023-07-31 8:23 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c43966d-33da-107a-ff47-370e3e27a99a@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_clew@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®