From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB381547E0 for ; Wed, 8 Jan 2025 20:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736369008; cv=none; b=NkOa6qx3i40XLP9aCIvjkL7CWSLrBlCUJVLI8kE9Wk0k8dgmpKmQcjSHI7y6yRFp57k+yWWlu7sdSUL4HVw5/IWUlaGHahK3FvF87wSTC3f/GASKzJGky1NBFL/AUIY47yHifQUf1jFGfsu1czt5WT1sHMFS3is/A9ydaiXYMSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736369008; c=relaxed/simple; bh=Lw5rU+NglZOWa0E7G6JTz+PmQ7ZQS+wqtD71Kb85YU4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j/j7T/viV0fQva7/4pOZ3uBETbxP+GgtinZTLS3E/jtAsV65qmHvV1rM5LSpmYA1QB3PmoT80Xt5abeERufgbsEzemJS23xZhDgday+tA+hoM8D6knlNPHdXHzEi649njVyO/4a9NTCBOiBILa9HaLLMyQO2jCntPgLp8yAt/fQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ejBmbgoL; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ejBmbgoL" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-71e2bc5b90fso104569a34.0 for ; Wed, 08 Jan 2025 12:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736369004; x=1736973804; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rOnlbWdm8MLO/mvmzUuC0fDQsKMvE3v8m4PGv6tTsVo=; b=ejBmbgoLJUHyyd3tM5qaPmlwFGbgZ9Ue8qmly9rF1h37MEPuNDvhr/lu/eGjvhYF12 sojDa5S4cvqUSj0jzq0n49H5pcsILXAxVPmrEJ0xym9VZrIai1SDEqACQskwdSZUtbuS 63z0RNHkii6HJAjeAmaAxWHMJDtxgKzqBHiL1k3M4IwizrWlir89XSOrWttR0D1TuKdN qr+Qgd/r3Hg8DtkXWABk6aJCJzCKwiciAlMW/9/RNY9q5ZEcs8qn/E5Rt/A0ROufLIqc hKNqbuoXm4G+arURrR4wQR3pbCz38d26+S6BQvFWIet3xE7S6CA/xWe4XQntX5ZIjHl+ h31A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736369004; x=1736973804; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rOnlbWdm8MLO/mvmzUuC0fDQsKMvE3v8m4PGv6tTsVo=; b=QS0eSahgtfg7/hdVGVRynOueIZAhpBBPwMh2Nh2x8607D+XhXj3GBIB7UqCPjVLcpj tIB2jaTIwYmAGqeC4WacPaYPgPR27EClDEJiy1RHtg+R29geWx/UO1FNAe9y/JoWXCqC NLhweeMwnw89I+GCyYIkQyKAZ9OVz1M+k2/zjcDn8EIHCxyqxa5ZkynITi3gMHidiiYv sdd1b4LeFuuCEWGthq8bRnlcHQ2+KCRJwEtAygR3Uy28tAE7YUxk3nHbuS2gUMiziF4k SD2pOe1FKJ7NzQR4WM8JZVuUBUMom7tD13pwoF5yiL1OO1MqI3tA8HN4O1IhKdgfX4k7 3p6A== X-Forwarded-Encrypted: i=1; AJvYcCWarralVrGBo0fqCKo6id4jXNQ+SJEkrO/gpK699l90luvCY3e6mWeZek0G0rBggU7TbiV46MGTttqM+TY=@vger.kernel.org X-Gm-Message-State: AOJu0YzjIEgwn6TBXFpcIbNjSmWUkmNnhMpaBktJNS3hH7LmI5QlWSNG a+Lz2hHw0rA4tIZtTTPuZZ1VXS5Om6geogYbmFDylIK13QBkio8iITSoLIyea40= X-Gm-Gg: ASbGncsDiUdtOCeBqrWBTBUcx3sKm/7a8N18aIrIhgos5sioZLvDeGaTQGwUqlhV8GB xmhWzQwk1M9Um94Lt9t93YnVzm178LOfH7jYdLfZYlqEc0OwMRYE8DJjWn5HddIO/0GlrozSNnn 8kHNavmJyZQ7PwK8WKfiKmbsupZVsLI14+XjyTNJVghC6em3hoLaSnDBuDq4NF+aZNL722ltQsZ aylpGDKzsY8xOIzdNdtScqkRF5XxqLjRsfHDkK+mjyoXwk1T0B9CH2sWIUB3GOUFFIXgEqxDDF9 wfzGVJtPs4u5rC54kQ== X-Google-Smtp-Source: AGHT+IHZQTydffoMLMGFSuLVu3iR+r4PZsv88PGYtk2GLXya8RF9Gf48BD4Iw9dxlWsQuyCYrVvu/g== X-Received: by 2002:a05:6808:1a1a:b0:3eb:39f5:de8b with SMTP id 5614622812f47-3ef2eda1cf2mr2487942b6e.32.1736369003998; Wed, 08 Jan 2025 12:43:23 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ece25014dcsm11642547b6e.26.2025.01.08.12.43.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 12:43:23 -0800 (PST) Message-ID: <2c43b7a8-1005-4364-83fd-b2a06cb18a25@baylibre.com> Date: Wed, 8 Jan 2025 14:43:22 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/9] iio: dac: ad3552r-common: fix ad3541/2r ranges To: Angelo Dureghello , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Mihail Chindris , Nuno Sa Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250108-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v2-0-2dac02f04638@baylibre.com> <20250108-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v2-1-2dac02f04638@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250108-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v2-1-2dac02f04638@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/8/25 11:29 AM, Angelo Dureghello wrote: > From: Angelo Dureghello > > Fix ad3541/2r voltage ranges to be as per ad3542r datasheet, > rev. C, table 38 (page 57). > > The wrong ad354xr ranges was generating erroneous Vpp output. > > In more details: > - fix wrong number of ranges, they are 5 ranges, not 6, > - remove non-existent 0-3V range, > - adjust order, since ad3552r_find_range() get a wrong index, > producing a wrong Vpp as output. > > Retested all the ranges on real hardware, EVALAD3542RFMCZ: > > adi,output-range-microvolt (fdt): > <(000000) (2500000)>; ok (Rfbx1, switch 10) > <(000000) (5000000)>; ok (Rfbx1, switch 10) > <(000000) (10000000)>; ok (Rfbx1, switch 10) > <(-5000000) (5000000)>; ok (Rfbx2, switch +/- 5) > <(-2500000) (7500000)>; ok (Rfbx2, switch -2.5/7.5) > > Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support") > Signed-off-by: Angelo Dureghello > --- Reviewed-by: David Lechner