From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE8DC77B7E for ; Thu, 27 Apr 2023 06:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243054AbjD0Gn0 (ORCPT ); Thu, 27 Apr 2023 02:43:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbjD0GnY (ORCPT ); Thu, 27 Apr 2023 02:43:24 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E6C319AB; Wed, 26 Apr 2023 23:43:22 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 4301F24E246; Thu, 27 Apr 2023 14:43:20 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 27 Apr 2023 14:43:19 +0800 Received: from [192.168.120.42] (171.223.208.138) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 27 Apr 2023 14:43:19 +0800 Message-ID: <2c43c2e3-afdb-6bee-37bc-655c0a1b0762@starfivetech.com> Date: Thu, 27 Apr 2023 14:43:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Content-Language: en-US To: Andrew Lunn CC: , , , Peter Geis , Frank , "David S . Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Yanhong Wang References: <20230426063541.15378-1-samin.guo@starfivetech.com> <20230426063541.15378-2-samin.guo@starfivetech.com> From: Guo Samin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Re: [PATCH v1 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg From: Andrew Lunn to: Samin Guo data: 2023/4/26 > On Wed, Apr 26, 2023 at 02:35:40PM +0800, Samin Guo wrote: >> The motorcomm phy (YT8531) supports the ability to adjust the drive >> strength of the rx_clk/rx_data, the value range of pad driver >> strength is 0 to 7. >> >> Signed-off-by: Samin Guo >> --- >> .../devicetree/bindings/net/motorcomm,yt8xxx.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> index 157e3bbcaf6f..e648e486b6d8 100644 >> --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> @@ -18,6 +18,16 @@ properties: >> - ethernet-phy-id4f51.e91a >> - ethernet-phy-id4f51.e91b >> >> + rx-clk-driver-strength: >> + description: drive strength of rx_clk pad. >> + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] >> + default: 3 > > What do the numbers mean? What are the units? mA? > > Andrew Hi Andrew, They represent the gradient of the current, which should be the higher the value, the greater the current. However, there is no exact current value to determine from YT8531 datasheet. Probably Motorcomm @Frank.sea knows what it means. Description: Drive strenght of rx_clk pad. 3'b111: strongest; 3'b000: weakest. Default: 0x3 Best regards, Samin