mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Felix Fietkau <nbd@nbd.name>,
	netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Cc: willemdebruijn.kernel@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 net-next v4 2/6] net: add support for segmenting TCP fraglist GSO packets
Date: Tue, 30 Apr 2024 12:23:56 +0200	[thread overview]
Message-ID: <2c48e13a26c55abf8e2199cae3b8b19596a419ec.camel@redhat.com> (raw)
In-Reply-To: <20240427182305.24461-3-nbd@nbd.name>

On Sat, 2024-04-27 at 20:22 +0200, Felix Fietkau wrote:
> @@ -37,6 +101,9 @@ static struct sk_buff *tcp4_gso_segment(struct sk_buff *skb,
>  	if (!pskb_may_pull(skb, sizeof(struct tcphdr)))
>  		return ERR_PTR(-EINVAL);
>  
> +	if (skb_shinfo(skb)->gso_type & SKB_GSO_FRAGLIST)
> +		return __tcp4_gso_segment_list(skb, features);

I'm sorry for the incremental feedback, I almost forgot.

Possibly the above condition could deserve an unlikely() annotation?
less relevant than for GRO case, but at least we have consistent
handling of such flag.

Thanks!

Paolo


  parent reply	other threads:[~2024-04-30 10:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240427182305.24461-1-nbd@nbd.name>
2024-04-27 18:22 ` [PATCH v4 net-next v4 1/6] net: move skb_gro_receive_list from udp to core Felix Fietkau
2024-04-27 18:22 ` [PATCH v4 net-next v4 2/6] net: add support for segmenting TCP fraglist GSO packets Felix Fietkau
2024-04-30 10:19   ` Paolo Abeni
2024-04-30 10:27     ` Felix Fietkau
2024-04-30 10:40       ` Paolo Abeni
2024-04-30 10:57         ` Felix Fietkau
2024-04-30 10:23   ` Paolo Abeni [this message]
2024-04-30 11:31   ` Eric Dumazet
2024-04-27 18:22 ` [PATCH v4 net-next v4 3/6] net: add code for TCP fraglist GRO Felix Fietkau
2024-04-27 18:23 ` [PATCH v4 net-next v4 4/6] net: create tcp_gro_lookup helper function Felix Fietkau
2024-04-27 18:23 ` [PATCH v4 net-next v4 5/6] net: create tcp_gro_header_pull " Felix Fietkau
2024-04-27 18:23 ` [PATCH v4 net-next v4 6/6] net: add heuristic for enabling TCP fraglist GRO Felix Fietkau
2024-04-30  3:25   ` Jakub Kicinski
2024-04-30 10:12   ` Paolo Abeni
2024-04-30 10:23     ` Felix Fietkau
2024-04-30 10:31       ` Paolo Abeni
2024-04-30 10:55         ` Felix Fietkau
2024-04-30 11:14           ` Paolo Abeni
2024-04-30 10:33   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c48e13a26c55abf8e2199cae3b8b19596a419ec.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®