From: "Christian König" <christian.koenig@amd.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>,
alexander.deucher@amd.com, airlied@linux.ie, daniel@ffwll.ch
Cc: lukas.bulwahn@gmail.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] drm/amd/amdgpu: Fix errors in function documentation
Date: Sun, 9 May 2021 18:30:48 +0200 [thread overview]
Message-ID: <2c5387b7-2fa1-9b5a-c671-806429b463aa@amd.com> (raw)
In-Reply-To: <20210509144923.6316-1-dwaipayanray1@gmail.com>
Am 09.05.21 um 16:49 schrieb Dwaipayan Ray:
> Fix a couple of syntax errors and removed one excess
> parameter in the function documentations which lead
> to kernel docs build warning.
>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +++
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index ae9fb2025259..312f24004413 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -320,11 +320,14 @@ static int amdgpu_ras_debugfs_ctrl_parse_data(struct file *f,
> * "disable" requires only the block.
> * "enable" requires the block and error type.
> * "inject" requires the block, error type, address, and value.
> + *
> * The block is one of: umc, sdma, gfx, etc.
> * see ras_block_string[] for details
> + *
> * The error type is one of: ue, ce, where,
> * ue is multi-uncorrectable
> * ce is single-correctable
> + *
> * The sub-block is a the sub-block index, pass 0 if there is no sub-block.
> * The address and value are hexadecimal numbers, leading 0x is optional.
> *
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 16252d48e5a4..7e1a67295106 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
> *
> * @adev: amdgpu_device pointer
> * @vm: requested vm
> - * @vm_context: Indicates if it GFX or Compute context
> * @pasid: Process address space identifier
> *
> * Init @vm fields.
next prev parent reply other threads:[~2021-05-09 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 14:49 Dwaipayan Ray
2021-05-09 16:30 ` Christian König [this message]
2021-05-10 21:02 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c5387b7-2fa1-9b5a-c671-806429b463aa@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®