From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E425C636D7 for ; Thu, 23 Feb 2023 09:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233869AbjBWJR6 (ORCPT ); Thu, 23 Feb 2023 04:17:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbjBWJR4 (ORCPT ); Thu, 23 Feb 2023 04:17:56 -0500 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B848C7289; Thu, 23 Feb 2023 01:17:53 -0800 (PST) Received: from loongson.cn (unknown [10.20.42.133]) by gateway (Coremail) with SMTP id _____8AxYcw8L_djQRIEAA--.2702S3; Thu, 23 Feb 2023 17:17:48 +0800 (CST) Received: from [10.20.42.133] (unknown [10.20.42.133]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxbL4mL_djtIs5AA--.39148S3; Thu, 23 Feb 2023 17:17:27 +0800 (CST) Message-ID: <2c54ec72-28c9-7ce2-e525-b2ad01bd8f9a@loongson.cn> Date: Thu, 23 Feb 2023 17:17:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] Mips: ls2k1000: dts: add the display controller device node Content-Language: en-US To: Krzysztof Kozlowski , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230222165514.684729-1-suijingfeng@loongson.cn> <32a56a81-e9b5-138b-4dff-35c2525cc0b6@loongson.cn> <6662546a-2c83-71bd-7050-903331201bdc@loongson.cn> <53cc20a0-bc9d-a094-13bc-6a5ef78069d1@kernel.org> From: suijingfeng In-Reply-To: <53cc20a0-bc9d-a094-13bc-6a5ef78069d1@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8DxbL4mL_djtIs5AA--.39148S3 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBjvJXoWxZr45urWxZF4UZw4UKF17Jrb_yoW5Zr4fpF 9xAFsrKrW8JF17tr1Sqw1rJrnIvFWrAF1DWrsrtw18J34qv3W7tr18Jr10gry8Zry7A3Wj vr1rGrWIgF15J3DanT9S1TB71UUUUjDqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bqxYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJVW0owAa w2AFwI0_JF0_Jw1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44 I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2 jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62 AI1cAE67vIY487MxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxC20s026xCa FVCjc4AY6r1j6r4UMxCIbckI1I0E14v26r4a6rW5MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2 IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42 IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280 aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8uc_3UUUUU== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/2/23 16:59, Krzysztof Kozlowski wrote: > On 23/02/2023 09:40, suijingfeng wrote: >> On 2023/2/23 15:58, Krzysztof Kozlowski wrote: >>> On 23/02/2023 04:19, Sui jingfeng wrote: >>>> Hi, >>>> >>>> On 2023/2/23 02:32, Krzysztof Kozlowski wrote: >>>>> On 22/02/2023 17:55, suijingfeng wrote: >>>>>> The display controller is a pci device, it's pci vendor id is >>>>>> 0x0014, it's pci device id is 0x7a06. >>>>>> >>>>>> Signed-off-by: suijingfeng >>>>>> --- >>>>>> .../boot/dts/loongson/loongson64-2k1000.dtsi | 21 +++++++++++++++++++ >>>>>> 1 file changed, 21 insertions(+) >>>>>> >>>>>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>>> index 8143a61111e3..a528af3977d9 100644 >>>>>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>>>>> @@ -31,6 +31,18 @@ memory@200000 { >>>>>> <0x00000001 0x10000000 0x00000001 0xb0000000>; /* 6912 MB at 4352MB */ >>>>>> }; >>>>>> >>>>>> + reserved-memory { >>>>>> + #address-cells = <2>; >>>>>> + #size-cells = <2>; >>>>>> + ranges; >>>>>> + >>>>>> + display_reserved: framebuffer@30000000 { >>>>>> + compatible = "shared-dma-pool"; >>>>>> + reg = <0x0 0x30000000 0x0 0x04000000>; /* 64M */ >>>>>> + linux,cma-default; >>>>>> + }; >>>>>> + }; >>>>>> + >>>>>> cpu_clk: cpu_clk { >>>>>> #clock-cells = <0>; >>>>>> compatible = "fixed-clock"; >>>>>> @@ -198,6 +210,15 @@ sata@8,0 { >>>>>> interrupt-parent = <&liointc0>; >>>>>> }; >>>>>> >>>>>> + display-controller@6,0 { >>>>>> + compatible = "loongson,ls2k1000-dc"; >>>>>> + >>>>>> + reg = <0x3000 0x0 0x0 0x0 0x0>; >>>>>> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; >>>>>> + interrupt-parent = <&liointc0>; >>>>>> + memory-region = <&display_reserved>; >>>>> NAK. >>>> Err :(,  please give me a chance to explain >>>>> Test your code against the bindings you send. >>>> I can guarantee to you that I test may code more than twice. The code >>>> used to testing is listed at link [1]. >>> I wrote - test against the bindings. I don't believe that it was tested. >>> Please paste the output of the testing (dtbs_check). > ^^^^^^^^^^^^ > Do you see this ----------^^^^? > > But you pasted: > >> I *do* run the test against the bindings and the test result say nothing. >> >> I reset my modify today made, then re-run the test again. >> >> I'm telling the truth: the test result say nothing. I paste the log at >> below: >> >> make -j$(nproc) ARCH=loongarch >> CROSS_COMPILE=loongarch64-unknown-linux-gnu- dt_binding_check > This -------------------------------------------^^^^^^^^^^^^ Yes, I see it. I means I have tested all of them as the instruction[1]! the test log just say nothing.  I re-run it again and all passed. [1] https://www.kernel.org/doc/html/v5.9/devicetree/writing-schema.html#:~:text=The%20DT%20schema%20project%20can%20be%20installed%20with,they%20are%20in%20your%20PATH%20%28~%2F.local%2Fbin%20by%20default%29. > > Best regards, > Krzysztof