From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Santosh Raspatur <santosh@chelsio.com>
Subject: [PATCH 08/33] cxgb3/l2t: Mark expected switch fall-through
Date: Tue, 7 Aug 2018 18:14:18 -0500 [thread overview]
Message-ID: <2c55cbf706fd10b0e5b3f1a8397a244cbe1fd335.1533675546.git.gustavo@embeddedor.com> (raw)
In-Reply-To: <cover.1533675546.git.gustavo@embeddedor.com>
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114780 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/ethernet/chelsio/cxgb3/l2t.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/l2t.c b/drivers/net/ethernet/chelsio/cxgb3/l2t.c
index 248e40c..0e9182d 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/l2t.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/l2t.c
@@ -136,6 +136,7 @@ int t3_l2t_send_slow(struct t3cdev *dev, struct sk_buff *skb,
if (e->state == L2T_STATE_STALE)
e->state = L2T_STATE_VALID;
spin_unlock_bh(&e->lock);
+ /* fall through */
case L2T_STATE_VALID: /* fast-path, send the packet on */
return cxgb3_ofld_send(dev, skb);
case L2T_STATE_RESOLVING:
--
2.7.4
next prev parent reply other threads:[~2018-08-07 23:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 23:09 [PATCH 00/33] net: ethernet: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-07 23:09 ` [PATCH 01/33] 8390: axnet_cs: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:09 ` [PATCH 02/33] alteon: acenic: mark " Gustavo A. R. Silva
2018-08-07 23:11 ` [PATCH 03/33] bnx2x: Mark expected switch fall-thoughs Gustavo A. R. Silva
2018-08-07 23:11 ` [PATCH 04/33] net: macb: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:13 ` [PATCH 05/33] liquidio: mark " Gustavo A. R. Silva
2018-08-07 23:13 ` [PATCH 06/33] cxgb4/l2t: Mark " Gustavo A. R. Silva
2018-08-07 23:13 ` [PATCH 07/33] cxgb4/t4_hw: mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-07 23:14 ` Gustavo A. R. Silva [this message]
2018-08-07 23:15 ` [PATCH 09/33] net: thunderx: mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:15 ` [PATCH 10/33] net: tulip_core: " Gustavo A. R. Silva
2018-08-07 23:16 ` [PATCH 11/33] net: tulip: de4x5: mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-07 23:17 ` [PATCH 12/33] be2net: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:17 ` [PATCH 13/33] net: hns: " Gustavo A. R. Silva
2018-08-07 23:18 ` [PATCH 14/33] net: hns3: " Gustavo A. R. Silva
2018-08-07 23:19 ` [PATCH 15/33] i40e_main: mark " Gustavo A. R. Silva
2018-08-07 23:20 ` [PATCH 16/33] i40e_txrx: " Gustavo A. R. Silva
2018-08-07 23:21 ` [PATCH 17/33] net/mlx4/mcg: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-07 23:21 ` [PATCH 18/33] net/mlx4/en_rx: " Gustavo A. R. Silva
2018-08-07 23:22 ` [PATCH 19/33] igb_main: " Gustavo A. R. Silva
2018-08-07 23:22 ` [PATCH 20/33] igb: e1000_82575: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:23 ` [PATCH 21/33] igb: e1000_phy: " Gustavo A. R. Silva
2018-08-07 23:24 ` [PATCH 22/33] igbvf: netdev: " Gustavo A. R. Silva
2018-08-07 23:24 ` [PATCH 23/33] vxge: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-07 23:25 ` [PATCH 24/33] net/mlx5e: " Gustavo A. R. Silva
2018-08-08 22:26 ` Saeed Mahameed
2018-08-07 23:25 ` [PATCH 25/33] qed: qed_dev: " Gustavo A. R. Silva
2018-08-07 23:26 ` [PATCH 26/33] netxen_nic: " Gustavo A. R. Silva
2018-08-07 23:27 ` [PATCH 27/33] qede: qede_fp: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:28 ` [PATCH 28/33] qlcnic: Mark expected switch fall-througs Gustavo A. R. Silva
2018-08-07 23:29 ` [PATCH 29/33] qlge: mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:30 ` [PATCH 30/33] net: ethernet: sxgbe: mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-07 23:31 ` [PATCH 31/33] net: sfc: falcon: mark expected switch fall-through Gustavo A. R. Silva
2018-08-07 23:31 ` [PATCH 32/33] net: tlan: Mark " Gustavo A. R. Silva
2018-08-07 23:32 ` [PATCH 33/33] net: ethernet: ti: cpts: mark " Gustavo A. R. Silva
2018-08-08 0:59 ` [PATCH 00/33] net: ethernet: Mark expected switch fall-throughs David Miller
2018-08-08 16:26 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c55cbf706fd10b0e5b3f1a8397a244cbe1fd335.1533675546.git.gustavo@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®