From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
Robin Murphy <robin.murphy@arm.com>,
linux@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 01/12] arm-cci: add missing of_node_put after of_device_is_available
Date: Sun, 14 Apr 2019 16:45:11 +0200 [thread overview]
Message-ID: <2c56bdcb-9354-c719-13df-38b5f1974f10@web.de> (raw)
In-Reply-To: <1550928043-14889-2-git-send-email-Julia.Lawall@lip6.fr>
> @@ -538,8 +538,10 @@ static int cci_probe(void)
> struct resource res;
>
> np = of_find_matching_node(NULL, arm_cci_matches);
> - if (!of_device_is_available(np))
> + if (!of_device_is_available(np)) {
> + of_node_put(np);
> return -ENODEV;
> + }
>
> ret = of_address_to_resource(np, 0, &res);
> if (!ret) {
How do you think about to move this function call to an additional jump target
for the desired exception handling?
Regards,
Markus
next prev parent reply other threads:[~2019-04-14 14:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 13:20 [PATCH 00/12] " Julia Lawall
2019-02-23 13:20 ` [PATCH 01/12] arm-cci: " Julia Lawall
2019-04-01 12:48 ` Mukesh Ojha
2019-04-14 14:45 ` Markus Elfring [this message]
2019-04-16 13:02 ` Robin Murphy
2019-02-23 13:20 ` [PATCH 02/12] drm/tegra: rgb: " Julia Lawall
2019-04-01 12:49 ` Mukesh Ojha
2019-04-14 15:01 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 03/12] PowerPC-83xx: " Julia Lawall
2019-04-01 12:49 ` Mukesh Ojha
2019-04-14 15:25 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 04/12] phy: tegra: " Julia Lawall
2019-04-01 12:50 ` Mukesh Ojha
2019-04-14 15:42 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 05/12] tee: optee: " Julia Lawall
2019-02-28 11:17 ` Jens Wiklander
2019-02-23 13:20 ` [PATCH 06/12] omapfb: " Julia Lawall
2019-04-01 12:07 ` Bartlomiej Zolnierkiewicz
2019-02-23 13:20 ` [PATCH 07/12] drm: omapdrm: " Julia Lawall
2019-04-01 12:58 ` Mukesh Ojha
2019-02-23 13:20 ` [PATCH 08/12] crypto: " Julia Lawall
2019-02-28 6:39 ` Herbert Xu
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
2019-03-12 20:28 ` Kevin Hilman
2019-04-14 16:12 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 10/12] cpufreq: ap806: " Julia Lawall
2019-02-25 4:29 ` Viresh Kumar
2019-02-23 13:20 ` [PATCH 11/12] ARM: OMAP2+: " Julia Lawall
2019-03-22 22:24 ` Tony Lindgren
2019-04-14 16:38 ` [11/12] " Markus Elfring
2019-04-14 16:49 ` Julia Lawall
2019-02-23 13:20 ` [PATCH 12/12] drivers: firmware: psci: " Julia Lawall
2019-04-01 12:47 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c56bdcb-9354-c719-13df-38b5f1974f10@web.de \
--to=markus.elfring@web.de \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®