From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07DF636A015; Wed, 11 Feb 2026 10:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770806944; cv=none; b=rX4yFdD5UTmNlqx8MALz5gUsMUJPNgiIZXtvVv7D1W3iwvZWi18faqaV7IGx1ydAwKDec1utWXur1EKwg9ygX/BnW/mlKEzxr9uMRkpMVlrBXZG/fmx2XQrPDa2+5RQy6+FEKrOUdxOPoyi5ihNqo9WpTPv2fNHKWq0RhvaCpjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770806944; c=relaxed/simple; bh=jIf0+M3KsfRjlOzc2/0QBIWz/ppKHa03wFBPNYg07fQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PMdXWFQKVpUO5c1nLtaqCVdhJm8HtEHrQhAs1K5zmSWhCinv2w+lUHP+g0jMkSYZ1fzjW9+L6k3BX3hJonM/u2XQM+0HneUZBLwXaCUoCJKUexQRJZUuFt8Fw4TkSrfrspT4Z+1T05cqYjeMVfsZjwQW9T+HKOwn35Hc5wgEaBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nOAWdGAB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nOAWdGAB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7578EC2BC86; Wed, 11 Feb 2026 10:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770806943; bh=jIf0+M3KsfRjlOzc2/0QBIWz/ppKHa03wFBPNYg07fQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nOAWdGAB422xPPd7QDWj60Kx78Sxej19WVk56f75O3KNQ98O2AdkjRUoy68srGJPE EwzAIpO8m7ycTR1RJ7voXjF8NE1v459RHdEeyC56YdnNdlNLrja/wRIpX9SZjoMi5t 7SNaFXHW429GRhZyZVofrZzCqoT2qRKUn6VtsZ1g3w5Vf71//lPyZ148PhTFtD2/XR Kgdg8mxPVzURaW7Ms6XVEXJVyKYc0Kb5QIuGJoUESEL9ThRPW6XjL+TniyeqkVgQ77 IPL4zYrz8ah8sm1lSUDqhZGM7APaOO/DXdJ02PWUSK9ZgHipXF+d2gXRvfBGUbTgLF bZtklWJPQeCdg== Message-ID: <2c5734db-1e62-4aeb-9c6a-ef14939575c2@kernel.org> Date: Wed, 11 Feb 2026 11:48:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] gpio: aggregator: add gpio-aggregator DT compatible To: Bartosz Golaszewski , Geert Uytterhoeven Cc: James Hilliard , linux-gpio@vger.kernel.org, Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Stein , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260211081355.3028947-1-james.hilliard1@gmail.com> <20260211081355.3028947-2-james.hilliard1@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/02/2026 11:38, Bartosz Golaszewski wrote: > On Wed, Feb 11, 2026 at 10:50 AM Geert Uytterhoeven > wrote: >> >>>> >>>> static const struct of_device_id gpio_aggregator_dt_ids[] = { >>>> + { >>>> + .compatible = "gpio-aggregator", >>>> + }, >>>> { >>>> .compatible = "gpio-delay", >>>> .data = (void *)FWD_FEATURE_DELAY, >>>> -- >>>> 2.43.0 >>>> >>> >>> Regardless of the DT bindings - this change is perfectly fine. We do >>> that for other "virtual" devices like gpio-sim, gpio-virtuser, etc. I >>> would just ask you to document it under >>> Documentation/admin-guide/gpio/gpio-aggregator.rst. >> >> This is not a pure virtual device, but for use with actual hardware. >> >> Nacked-by: Geert Uytterhoeven >> > > Well, it is a virtual device in that there's no actual "aggregator" > device on the board. It virtually aggregates GPIOs into a separate > chip for user's convenience. While there's no such device as a > gpio-aggregator - and so we must not put it into bindings nor into > mainline devicetree sources - having a compatible matching in the > driver is perfectly fine IMO. Just like gpio-sim. I already wrote, you cannot have undocumented compatible. There are even explicit checks for this - in schema and checkpatch - so with your approach you accept known warnings. Really, no, and fact we need to keep discussing it: Nacked-by: Krzysztof Kozlowski Best regards, Krzysztof