From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E862EB64DC for ; Sun, 9 Jul 2023 12:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbjGIM46 (ORCPT ); Sun, 9 Jul 2023 08:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjGIM45 (ORCPT ); Sun, 9 Jul 2023 08:56:57 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72860A6; Sun, 9 Jul 2023 05:56:50 -0700 (PDT) X-GND-Sasl: contact@artur-rojek.eu X-GND-Sasl: contact@artur-rojek.eu X-GND-Sasl: contact@artur-rojek.eu X-GND-Sasl: contact@artur-rojek.eu X-GND-Sasl: contact@artur-rojek.eu X-GND-Sasl: contact@artur-rojek.eu Received: by mail.gandi.net (Postfix) with ESMTPA id 88CDDC0002; Sun, 9 Jul 2023 12:56:47 +0000 (UTC) MIME-Version: 1.0 Date: Sun, 09 Jul 2023 14:56:47 +0200 From: Artur Rojek To: John Paul Adrian Glaubitz Cc: Rich Felker , Geert Uytterhoeven , Sergey Shtylyov , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sh: hd64461: fix virq offsets In-Reply-To: References: <20230709121311.211720-1-contact@artur-rojek.eu> Message-ID: <2c57d9cc03b6a430234c0016bf78fa22@artur-rojek.eu> X-Sender: contact@artur-rojek.eu Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-07-09 14:48, John Paul Adrian Glaubitz wrote: > Hi Artur! > > On Sun, 2023-07-09 at 14:13 +0200, Artur Rojek wrote: >> A recent change to start counting SuperH IRQ #s from 16 breaks support >> for the Hitachi HD64461 companion chip. >> >> Move the offchip IRQ base and HD64461 IRQ # by 16 in order to >> accommodate for the new virq numbering rules. >> >> Fixes: a8ac2961148e ("sh: Avoid using IRQ0 on SH3 and SH4") >> Signed-off-by: Artur Rojek >> --- >> arch/sh/cchips/Kconfig | 4 ++-- >> arch/sh/include/asm/hd64461.h | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/sh/cchips/Kconfig b/arch/sh/cchips/Kconfig >> index efde2edb5627..9659a0bc58de 100644 >> --- a/arch/sh/cchips/Kconfig >> +++ b/arch/sh/cchips/Kconfig >> @@ -29,9 +29,9 @@ endchoice >> config HD64461_IRQ >> int "HD64461 IRQ" >> depends on HD64461 >> - default "36" >> + default "52" >> help >> - The default setting of the HD64461 IRQ is 36. >> + The default setting of the HD64461 IRQ is 52. >> >> Do not change this unless you know what you are doing. >> >> diff --git a/arch/sh/include/asm/hd64461.h >> b/arch/sh/include/asm/hd64461.h >> index afb24cb034b1..6d85db6cf54b 100644 >> --- a/arch/sh/include/asm/hd64461.h >> +++ b/arch/sh/include/asm/hd64461.h >> @@ -229,7 +229,7 @@ >> #define HD64461_NIMR HD64461_IO_OFFSET(0x5002) >> >> #define HD64461_IRQBASE OFFCHIP_IRQ_BASE >> -#define OFFCHIP_IRQ_BASE 64 >> +#define OFFCHIP_IRQ_BASE 80 >> #define HD64461_IRQ_NUM 16 >> >> #define HD64461_IRQ_UART (HD64461_IRQBASE+5) > > I think it would be better to write this as (64 + 16) for consistency > with the other changes made by Sergey. Sure, I will send v2 with this change, although the same can't be applied to HD64461_IRQ value above, so some inconsistency will exist either way. > > Adrian