From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC6EF19ABAB for ; Tue, 28 Jan 2025 11:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738064399; cv=none; b=Sc2QNNYdR5I7s4CsJ3uuTmNQjiumAL+RnW9k3H5rNznboeaMco3uOfcY5P8OweOM/iCPVoRTrkRuEL6i3R+RajPJMYCX07NGClt6bR5N018ny6uY1/uGFRMwxHt76BpqPUb8aWYZgNo0QRTX7HyWRi2UoVTJw9DEK6MsBFIl7f0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738064399; c=relaxed/simple; bh=CztCANHMFWijIHQAJBDs/iFyXn0A5ARLD+mZiYzCDzM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YCNSbS9fG+g2WsIFwAwE6p36+1G19N5A7h5nqqwq91r2I33Ib+J4LVBhDdjFv4lCjjt/dfdYRnyQnl4CI02R/uKEMW3uxOvbAYTOot3KTt7BeIaK/56wRphvzvtBvt1aCb9/MRp0/rbnCKdR6QsNxIl4nE29Wlt8BHq9NnxliZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HMO5lwGV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HMO5lwGV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738064396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=P4hMO7vivag5v9/Z7aCMmyd1JZBnkSDVWLrzET6ai1o=; b=HMO5lwGVFSNfi9n+syZqzrxWP7LlfAdoiUrCIYE1UzfE7eu+rwrK82o+Ha20GV+t3D+X3S xJnaSXiEA0WZE3NQ3p9lLriOeZbmDzxFRYKSJdAMfM+b0jS5XjS9wuMMNekTYqQXBZ4EVb aUw1tKKLJot2r+yKLxATJ0qddD7Gb0w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-V9yXw6FHM7CILVx2d9wCrQ-1; Tue, 28 Jan 2025 06:39:55 -0500 X-MC-Unique: V9yXw6FHM7CILVx2d9wCrQ-1 X-Mimecast-MFC-AGG-ID: V9yXw6FHM7CILVx2d9wCrQ Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385dcae001fso2091579f8f.1 for ; Tue, 28 Jan 2025 03:39:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738064394; x=1738669194; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=P4hMO7vivag5v9/Z7aCMmyd1JZBnkSDVWLrzET6ai1o=; b=K0VrsuVTG8JDkRtL0eIP1iNmCGFqVkja3O2rA9q/R5vnHMd+HaA4TFFMN1b17hvtpI PBVpURMpEGBPWRyojRawa0MnKbpzibstRLGmgtR2SlxJLe0jm1Yk9YrbaoIvVxdP0WLQ bZN5Ed3Yo+Sbajssg+y2cjcLAI7W254fpVIIT2vqo/UK50LKobGON40rhdL09PEje8JY /BxzxHNhFt1JuOf3HH9A6B0H3TsW0AvtFlE5hzXsxDseoDZ3amAcGVuPrDnHal42WPK+ oLp0zGIwm4rOJACLxJAcfPesxsU9ml0sho5Faxo1WmpSV4WjzkVgI+ERCPsUdE7kOBTP fckQ== X-Forwarded-Encrypted: i=1; AJvYcCVHJZMnIwuUlM7LHs2UqPxs/XCuwhs9LQxW0ae+6AbsxNXnXsENMxLBOHNrJzNSM7NnAhnHwKTPpOTsdbI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj7YNckGRufqSGXvhg8s7tDTy3aFDF3r26251wB3OO18uFSLJO Gu5FxmcxKvsGYPmI9Jh8d+UZJ6fIh+7HxdODKDvFf3N3mCijp+LoSVm6UGW6+1Hzzq+j5p9fuen u7g5ngGGeIf4vOhfPVBfL5FK5D1MIroMpUIitIh5wVCWDdO2ZQ/i4kNvonF+5ZA== X-Gm-Gg: ASbGnct1HNedUtG4mDxwz7CTG/lh8gNamc4jXpPGeFPD8nGkpXb5zbzg2+3q3nVsjWh xZ/Uowce2hsOy4+SXVq70vxVVbV3XHYGgX5lUE1VOlT/A0FkmD3t/UJzA0vxg4TXopazg8O0Knd rZQ04peo1Go7aWV6q3ljz4KiJpcGJsztCfX3LDcR1cNrt3SpUfauH4mG6nfOkotFmUS2wb6p19y TL/MUxf0utw6E5d1oMUFVKkr/Hls2FQcYPQaH4qyOcLDJpoUAV14Kgio5rtbASZ1SJeYp8wzgLz C8SFXKGkMWkWCOm4K7T4TW9HLr4xBGcEoUP0sO9mgDm3LbSOi9mGeXAZv/hoWfJ3CWxT31GaOfv f3OvCeUef1Nm+RElygQ040JVgw9wEff6A X-Received: by 2002:adf:a1cc:0:b0:38a:a074:9f3c with SMTP id ffacd0b85a97d-38bf5663dbcmr35397522f8f.16.1738064394139; Tue, 28 Jan 2025 03:39:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2OV58QgpQihobiY29cmAjfcbEjrbDKoKJhEqWyTrWzNmUiJJ5p8HeAILDenm6TuJPkZm6dQ== X-Received: by 2002:adf:a1cc:0:b0:38a:a074:9f3c with SMTP id ffacd0b85a97d-38bf5663dbcmr35397493f8f.16.1738064393729; Tue, 28 Jan 2025 03:39:53 -0800 (PST) Received: from ?IPV6:2003:cb:c73f:ce00:1be7:6d7f:3cc3:563d? (p200300cbc73fce001be76d7f3cc3563d.dip0.t-ipconnect.de. [2003:cb:c73f:ce00:1be7:6d7f:3cc3:563d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1c3fedsm13594888f8f.85.2025.01.28.03.39.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 03:39:53 -0800 (PST) Message-ID: <2c599f1f-f63b-4504-a026-46bf73954124@redhat.com> Date: Tue, 28 Jan 2025 12:39:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [x86] 4817f70c25: stress-ng.mmapaddr.ops_per_sec 63.0% regression To: Peter Zijlstra Cc: kernel test robot , Qi Zheng , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Dave Hansen , Andy Lutomirski , Catalin Marinas , David Rientjes , Hugh Dickins , Jann Horn , Lorenzo Stoakes , Matthew Wilcox , Mel Gorman , Muchun Song , Peter Xu , Will Deacon , Zach O'Keefe , Dan Carpenter , Rik van Riel References: <202501281734.d408a35b-lkp@intel.com> <46ea4509-0f38-4b22-bd91-f05c68db2562@redhat.com> <20250128113100.GB7145@noisy.programming.kicks-ass.net> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250128113100.GB7145@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.01.25 12:31, Peter Zijlstra wrote: > On Tue, Jan 28, 2025 at 11:05:17AM +0100, David Hildenbrand wrote: >> On 28.01.25 10:57, kernel test robot wrote: >>> >>> hi, Qi Zheng, >>> >>> this is more a FYI report than a regression report. >>> >>> by 4817f70c25, parent/4817f70c25 configs have below diff, >>> >>> --- /pkg/linux/x86_64-rhel-9.4/gcc-12/718b13861d2256ac95d65b892953282a63faf240/.config 2025-01-27 16:20:43.419181382 +0800 >>> +++ /pkg/linux/x86_64-rhel-9.4/gcc-12/4817f70c25b63ee5e6fd42d376700c058ae16a96/.config 2025-01-26 09:27:16.848625105 +0800 >>> @@ -1236,6 +1236,8 @@ CONFIG_IOMMU_MM_DATA=y >>> CONFIG_EXECMEM=y >>> CONFIG_NUMA_MEMBLKS=y >>> CONFIG_NUMA_EMU=y >>> +CONFIG_ARCH_SUPPORTS_PT_RECLAIM=y >>> +CONFIG_PT_RECLAIM=y >>> >>> # >>> # Data Access Monitoring >>> >>> >>> this report seems show the impact of PT_CLAIM feature for this stress-ng case. >>> >>> To us, this is not a code logic regression, but is kind of 'regression' from a >>> new feature. anyway, below full report just FYI. >> >> mmapaddr test case seems to mostly do mmap+munmap. No obvious sign of >> MADV_DONTNEED, unless buried somewhere :) >> >> So either >> >> (1) The series is reclaiming page tables outside of MADV_DONTNEED, which >> it shouldn't -- in particular not during munmap() where that happens >> already using the "ordinary" page table removal code for removed >> VMAs. >> >> (2) This is the effect of MMU_GATHER_RCU_TABLE_FREE that gets selected? >> >> >> I recall a recent series to select MMU_GATHER_RCU_TABLE_FREE on x86 >> unconditionally (@Peter, @Rik). > > Those changes should not have made it to Linus yet. > > /me updates git and checks... > > nope, nothing changed there ... yet Sorry, I wasn't quite clear. CONFIG_PT_RECLAIM made it upstream, which has "select MMU_GATHER_RCU_TABLE_FREE" in kconfig. So I'm wondering if the degradation we see in this report is due to MMU_GATHER_RCU_TABLE_FREE being selected by CONFIG_PT_RECLAIM, and we'd get the same result (degradation) when unconditionally enabling MMU_GATHER_RCU_TABLE_FREE. -- Cheers, David / dhildenb