From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010037.outbound.protection.outlook.com [52.101.61.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31E3D3876D0; Tue, 28 Apr 2026 23:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.37 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777417801; cv=fail; b=KGD71tu+ATdC7sXknZtCKA4VPkE7MppvBOdu7Ciq+dq+rkBxpzKOuuhCU/hDMpHuQku8jW04uIIYHCIlqXJHS8r/lp8X6PVp3pq8Rve3Ptft4HyJ52ysOkFfAuca4kaRndoxRObE0fgRW/rPsv9zSfG1hffC7TgUJ509941UIGk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777417801; c=relaxed/simple; bh=IdLNgohFZ5Tyho7UAljfE8MeTV8C3fS9TzU9RfKyjHk=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=YOrr6bJ5e0mPyfwepSpv1oG0ikpfSvVsUcGuW+pT4gK/8O/ea3xKE0cmfinkVjI2wYuHDKfoYMwjIUH8Jo78eL+BECN9idsKBJqA+qG4ebABrKFfLV7pIDCKCX5CvyVQdCfF5Bt6+/IURHbz7qo6pn1pk07GMoKmpC0k01C5zRw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ZXtloSRL; arc=fail smtp.client-ip=52.101.61.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ZXtloSRL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H0rRyw8RtHk3DF5M6LJ4MUbD7bS5IH44nyUs8vnJMPezgoCeRZFkRWWe1mipeTWe0jDRq0/18qu6YT6wn4yn/2Y+6rHWC7IgfN6oW2oBBtFAwPdOzj3vAFUuZGt0ffQUXdRtlNhAhJJB9lsClaj+9K94rtCn5kiqapz8iahQ5ZQjVPE2/LHjlfyGZfpySuKOHYT7ZBlgsPh+UDRtk+Y4rwTBBHiN9DuBF4bBeboVhvJvXhK5w9xD6yZQaXQvLxBAAOjpXyLSxi28eivpeMD5YBv2Uu94/esaWLW9Gw4gKxL5RYqgT9YbYbTf/2JC3YpN6NVgHDRfQWdi2TkCr2BbTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qdI9cH/uoPN2zeLkihmmgeJP6WBSWiOLq/Aa5OjGZeY=; b=o/OvXAtYCc9yQQYSI9zHxvWjaA/nwyFtVdtHbLXPyZw1q79dEdAEHbguoQjRbREj/Nj282nl88xxmLETnCZKJCYmMaH8o696wzTtK1sLej76eGMoYExUELny0k0rQF+Z0yrp/DjIxqAXGuNYMacsB5vm94MG+B0QQUyi+ai36+8Iyki0LESq0MB+gtVftUk6d2mm4keMTu10dlYMGPEB3S/7gMkk8CulrL6urnJ7QX5E+IoofoLfqIYEO0KAE3F4ZuoHY/qjqH6QclEY4Ww21rPiAD31y3yawR6bOpJLwzsqzFZ1mnGEmnth56BGUqEFgcyTqLyv4swD02IFaJBxFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qdI9cH/uoPN2zeLkihmmgeJP6WBSWiOLq/Aa5OjGZeY=; b=ZXtloSRL4+vVfsdFBhuuCIfDPLXtYxFTvaH4WxL4MqyoU3/Yj14m3syjDR+Y6ONg4ZOjCfX9nC6Of0jDLNFHMhNkU2gs8LNC2fwKEgUmgTNqvlKf8GRE+FmknT5EzpkmiqDvzMCUlAD9jmzgaLdaH9KUKSi6Y+B/YXrTgekwQDI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from IA0PPF9A76BB3A6.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bdc) by SJ0PR12MB5673.namprd12.prod.outlook.com (2603:10b6:a03:42b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.17; Tue, 28 Apr 2026 23:09:56 +0000 Received: from IA0PPF9A76BB3A6.namprd12.prod.outlook.com ([fe80::ca9:67f1:6872:decc]) by IA0PPF9A76BB3A6.namprd12.prod.outlook.com ([fe80::ca9:67f1:6872:decc%6]) with mapi id 15.20.9846.025; Tue, 28 Apr 2026 23:09:56 +0000 Message-ID: <2c5a7921-dcb8-4cce-8223-69f6709bf59e@amd.com> Date: Tue, 28 Apr 2026 18:09:53 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [tip: x86/urgent] x86/resctrl: Fix SNC detection To: "Luck, Tony" , Babu Moger Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org, Reinette Chatre , "Peter Zijlstra (Intel)" , Ingo Molnar , Zhang Rui , Chen Yu , x86@kernel.org References: <20260303110100.367976706@infradead.org> <177263917393.1647592.6057050710859194701.tip-bot2@tip-bot2> <37ac0376-43a3-4283-a3d5-4d57b3bec578@amd.com> Content-Language: en-US From: "Moger, Babu" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA1P222CA0092.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:35e::12) To IA0PPF9A76BB3A6.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bdc) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PPF9A76BB3A6:EE_|SJ0PR12MB5673:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e316327-72c0-491a-a1ea-08dea57b42fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 9LFpKHCGyDqMpSAt413txLBnd+b1CpjkIbgEjBpILYoaKsW5xMICwByL8amq9ZH2w6w2bAMCxSGg1w+MSHTNBCD7Q8J28VGSwdwZhWsXCsTJBO4/J6cVHG0q+cmq2abxKW/uUdADw0fZrCG9QfLUjfYlrwN4nAzHo6Tb+RIgnk2tauEMFskdSJnm03npwdfnwFuMSBCb18C4T0AC0YQK5MDo4TYWfuwDfrKyB8WlxZpuddQSd9yBAsXYwcAZYw8uk7IR6LoTyFtnMmZF8xKffdWXmhTzRpasF75f7u3B3sDL4Zdm1eq+bfEEsVYYdRmGEdHCkjRruYuBv+lJfU6ZFNu/aUPt2HejyvOIIGlEDhCgZ0XJfqFTJFwfGf7T5nevK0fzd5AOVrz37BC29eQqB0NZTGAhcCXuPHHTKJhMgr9DLGzNTGj6mD7k4eGjRMQzlZRDAwOIcfcYpEJ6hrWhkX0XlIs/L0VhXZA5U9LK8gkfPtmTrwnGlZkdJasH1ybew24ShT7Myrd8Mwn1vcykUTVl+84KTBg2mOxMxOeC6q/3sD3ja6NDeJEICpvH50a4XTnNP16XatUbyfkbgGGoC8qBn42h293ULUb+mIF7gHQE+Z+BYN19eXJxC7oMK1o8O1/J6HW8E0jmfse/JzEogMkAzX60O+3ooZNd4z6a4OWEeme266bq7vQh9Xo2Pq/0mMsCvloN5AumCM15mdDkEnw2SLyWAr09JaeWsF3XiDw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PPF9A76BB3A6.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDRxRWx4RHpvNVYwYXBVb3kxNVNza3FvcjVNZTFlTHhGbVUzT3c5NW54Vk5O?= =?utf-8?B?NklnZ2x3bmdsaFpnQm9aWVB0WURkeko0UEkybXVZWXpoZkFyYjF0UkVicldE?= =?utf-8?B?b2dNTk9rZVhleUlmMDIwVEorLzBTTWFIZVBpZXFxcndrdm1ZVVp5a25xK2ZR?= =?utf-8?B?dytwZk9VVTU3a2FvSmlBMzBWUFB4dmg5YjhhOTMxSUs5OEhTT0JPUHRNQnN5?= =?utf-8?B?SjNLdTNQYm5FZmlKekU1bmI5QmMrL3RBQWYwYkoyREU2bW9Ed0NsTENSR0dM?= =?utf-8?B?dmIxRlhNekJxT29vOXpWTUNPUXJ6Ris1RlhiT3ZSejJSZ1Q1aGdXdkZNb1hD?= =?utf-8?B?VWFTcVJTcUs4SFo1aE5HN0hIT3ZUUkUzY2o3c1YwUGR2QXJXSzk4SVdjOGdI?= =?utf-8?B?N2FWZkd0QWM5L29RQllJT2tuQ3BwWU96VDlzRTUvRHNqaVhTblMvZkZ1NnVD?= =?utf-8?B?QzdCN251UURtYndtdnFJeExYd21ET2xWaS9HOURFMmtqT3FjamxFdWlyZjFn?= =?utf-8?B?L2ZCeUppcldyR1pweVVoS3kyLzFmSzB4WUJiMjVVdnRJQW1scm9wS0NVT01o?= =?utf-8?B?cGZJVWVBSVRNM2JMaFBPdld3NVBiQ00yT2diQTRFMWJIMzZ1dlJCTHE0U1JK?= =?utf-8?B?dXBjMXE4QkpMKzEwRkV0Q1V5N2Rnbkk4QU5Qd29qaVhIenVoWXlzbGFCK3ZW?= =?utf-8?B?dE05Nmp4aWRGcDQ5T2xmQm1nOFozMnY0Mm95QUVPSm5ua3BScTlPdDcwaXo4?= =?utf-8?B?d3lLSCtQYVRqU29BcFVEZHR4STNxaGI3S1ZhTjdRekU5bTd3Rk5ybXRuSzBH?= =?utf-8?B?WFRBMlJtMWdjM24wcHdBNlVucWM1N2hTbDY1YytkS2t2cTVtOGJxa3E0ZWt4?= =?utf-8?B?dkxqNW9YTTByYW9kaVhGRVdsZUN2eWtSTkF3Y3dGV3R4dk5HNUNLMWFXWVNy?= =?utf-8?B?V2REQ0E3VkFTYU9yM3Qrc2NVUCtRZmZaQXBVMHdTRnUrWm56NXRwYXJoZnVF?= =?utf-8?B?VTZyZ2JlMnduc3JLN3k0eU55enVBWlUyaW8reUdZcVYzUDVGMng1NXFxek54?= =?utf-8?B?NkZOMHZUK3RIRjY0cWZuRUJKaDNlcHBVbEY1SDUzdmxDKzJIQWpwYno2WmRi?= =?utf-8?B?d0xwM2U0Sjd6eEFPWFYzZkJiZDdxdTFPYnN4YithbldYcW1HTmlmMFkxcEwx?= =?utf-8?B?U042enlDL011TUwwWXZzU0UwRDhkWG4xd0NsZUJqWmFHRlAxeWZ5dEVzZ3FC?= =?utf-8?B?d3pseVdvdmhWSWE4WEV3Q05WcmxwdlVzNForalB2RVcrOTd1VGlMWkh3QXo2?= =?utf-8?B?d1NSQkl6cXVEV1hjN3FMS0dVamhTK0pFR2tmb0F3NDczT3BMZzllT2w1ekV2?= =?utf-8?B?NURISk11bG1IU1ZXMWJ5WWVGVGlCSENIOGYwcEhqdEhBRG9kc0FZNVdNaU1S?= =?utf-8?B?TWNyZ25iMm5tS0phN3o0K1FoVVBCVnBieEd4YVVySjkrWDZ5RmI1cm5KZTdh?= =?utf-8?B?K1hpMm93b0tTREdVSFdSelE5YWkvMVFGcEN4VTI3cVp0cFdJZVJKZW5JY05U?= =?utf-8?B?MW9Qa0NBcjB6M3Qxdzh0NnFhQlJyS0xiWnpSVXZpYXNXbzhTR1Q2a09FRHh2?= =?utf-8?B?YmVYdWRkWDc0UjNaSko5aWlBODFqZmxudDJPMjdXUHV0SzRNRDF6cHpQZ1R6?= =?utf-8?B?ZmYwZjZBbTl2WlR5SnRCdXQ2c1p3T08yRzF3aFJXdW1SdXo2eU84TjM0dWdt?= =?utf-8?B?OThuOWUxQ3MzTmk4YmpUZ1RxMVBkT001d0pyUW1ITVhNQWduNG96aldxQy8x?= =?utf-8?B?UEoxOWs1SVJ5bXVDRzR1WG9jTTN6RzhJR1dXWmltOEdKaTlRUUJOT2RTKzNS?= =?utf-8?B?M3FTa1cxSmFRR1U5aXQ2MHgvbTU3VEZ1Z2EvSlJmN3hnREgzaFBPV09YUFBX?= =?utf-8?B?b0V4U3pQa0l5NFcyKzVSSnRJVXJ5SmhTL3N3YnBxckR5Q25OZ1RrdFp0ZkR0?= =?utf-8?B?RGpDYmUzUEo4czEzUURHZ2NrcHJUY1NYZDVwZmhxTnl1bUFPa0dlbTdSSFpI?= =?utf-8?B?Y3NFcmRMeWtxcnA1V3dFRzJBUWVSc1FodW82MXVJL2tWVmRaNE40UExmdjFQ?= =?utf-8?B?MzJnSHJHQlFqdHB0TjhhdTg3RmxhZ0xFdWZLa21ERSs1RlNpMHBueHBDQjV5?= =?utf-8?B?eXlGbXFGT1dVZndsaURWYmFsL3V1MzNIMWVxMXlUMFlsWVc2M2x2dnJwNG5X?= =?utf-8?B?NGNvMnF3UlN4ZUJTU3NCODNsNUhVeFM1K0Y5eCsyUzlKSFJFNnc2Mnk5dy8v?= =?utf-8?Q?0/tEx5JlkXaFd0J/x1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e316327-72c0-491a-a1ea-08dea57b42fa X-MS-Exchange-CrossTenant-AuthSource: IA0PPF9A76BB3A6.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 23:09:56.1534 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FnZT41LF/fCDZZjnQQzbS+yj1MaiZ6oj3GkUBlIt7GzAGzzLVXA4+unDq9BJtL4P X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5673 Hi Tony, On 4/28/2026 3:52 PM, Luck, Tony wrote: > On Tue, Apr 28, 2026 at 03:41:51PM -0500, Babu Moger wrote: >> Hi Tony, > ... >> Saw these messages on AMD system(7.1.0-rc1). >> >> sudo dmesg |grep CoD >> [ 6.614667] resctrl: CoD enabled system? Resctrl not supported >> >> >> Might confuse some users. Not a big deal. But we should fix it in next >> version. > > Babu, > > Indeed yes. Thanks for letting me know. > > I think this should fix it. Can you test please? > > -Tony > > --- > > diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c > index 497cc57ac135..3d72ff5d0c25 100644 > --- a/arch/x86/kernel/cpu/resctrl/monitor.c > +++ b/arch/x86/kernel/cpu/resctrl/monitor.c > @@ -374,7 +374,12 @@ static const struct x86_cpu_id snc_cpu_ids[] __initconst = { > > static __init int snc_get_config(void) > { > - int ret = topology_num_nodes_per_package(); > + int ret; > + > + if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) > + return 1; > + > + ret = topology_num_nodes_per_package(); > > if (ret > 1 && !x86_match_cpu(snc_cpu_ids)) { > pr_warn("CoD enabled system? Resctrl not supported\n"); >> > Yes. it fixes it. Thanks Babu