From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbdHBFNU (ORCPT ); Wed, 2 Aug 2017 01:13:20 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:37630 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbdHBFNT (ORCPT ); Wed, 2 Aug 2017 01:13:19 -0400 Subject: Re: [PATCH 3/5] phy: phy-bcm-ns2-usbdrd: Replace the deprecated extcon API To: Chanwoo Choi , , References: <1500254456-6525-1-git-send-email-cw00.choi@samsung.com> <1500254456-6525-4-git-send-email-cw00.choi@samsung.com> CC: , , , , , Raviteja Garimella From: Kishon Vijay Abraham I Message-ID: <2c5b20ab-a1cd-f7c0-12e7-2cc338a84bfc@ti.com> Date: Wed, 2 Aug 2017 10:42:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1500254456-6525-4-git-send-email-cw00.choi@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 17 July 2017 06:50 AM, Chanwoo Choi wrote: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_get_state() > > Cc: Kishon Vijay Abraham I > Cc: Raviteja Garimella > Signed-off-by: Chanwoo Choi Acked-by: Kishon Vijay Abraham I > --- > drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c > index 9ae59e223131..d099a0c8cee5 100644 > --- a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c > +++ b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c > @@ -253,16 +253,16 @@ static void extcon_work(struct work_struct *work) > vbus = gpiod_get_value_cansleep(driver->vbus_gpiod); > > if (!id && vbus) { /* Host connected */ > - extcon_set_cable_state_(driver->edev, EXTCON_USB_HOST, true); > + extcon_set_state_sync(driver->edev, EXTCON_USB_HOST, true); > pr_debug("Host cable connected\n"); > driver->data->new_state = EVT_HOST; > connect_change(driver); > } else if (id && !vbus) { /* Disconnected */ > - extcon_set_cable_state_(driver->edev, EXTCON_USB_HOST, false); > - extcon_set_cable_state_(driver->edev, EXTCON_USB, false); > + extcon_set_state_sync(driver->edev, EXTCON_USB_HOST, false); > + extcon_set_state_sync(driver->edev, EXTCON_USB, false); > pr_debug("Cable disconnected\n"); > } else if (id && vbus) { /* Device connected */ > - extcon_set_cable_state_(driver->edev, EXTCON_USB, true); > + extcon_set_state_sync(driver->edev, EXTCON_USB, true); > pr_debug("Device cable connected\n"); > driver->data->new_state = EVT_DEVICE; > connect_change(driver); >