From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE5F1265606 for ; Wed, 25 Mar 2026 15:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774451770; cv=none; b=dGBFcsvgS1MoJmgpv6yoAl8d946037noYtUWZOf2JrAujsx9XFRSxTx1xlbQr7S/YvYe4EOPcTBVMT8Ht2n+3Q3gQl8w/vXKpARaRqV/Mxg/hCIc33Oo4tqBiY9YAKzfuE/sM13Qo8zbyP5LD52CMXHLtbbqPQrHcSmDHKYN4bE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774451770; c=relaxed/simple; bh=/vywv4hZ4+kE2TvgFYQ3L9kVw42zFJldnDoEQi5wZGU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bVC0Y67DuuTFU+v1TrcvEXqRycjUcsIx2rKpoyN2OJWLWMR+M7wzyFqYCaWRMr0pg5IkDkiJkAAtSduSusrOdPx5P1bEMxFwruluMMf44BY3z/Pa9pIw8WM3+rBBlWBVHQq7MK9mjDdCPaIwrFwwPhgJUD5vpAjqLUmydiDukrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Xtl9lsug; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xtl9lsug" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b886fc047d5so1129932966b.3 for ; Wed, 25 Mar 2026 08:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774451767; x=1775056567; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jeZDmS4QXWBXj1GSyJBXJGYP+hGJySEXWFfrbydgUbc=; b=Xtl9lsugTjkG1zZ3ws5CkNNW0aOB1buzoShWTUH9GO8vsOmYQ8EAdjqMrPBnZa24uJ 5Oj4ABMUHI00QYCSOUD6my+zhaz9e7UFsphPqhbvaxMEMRrcyxLmWlsJQABR9VSTSv6K MysRVPFd5hXAOgErCJkqUQP42uxmbycD828DD1TJSpa2RqQvITZs9+gupw9snXR9kwcH wqqITJdDFcGkvCgAGz8EsfSTpSee4lXNkI87HVUETqllVPy3L0FGqOrq4MqxursLHngD UleQ6BtlB58AK/5VCf7FUsm+bY0dvRFJHXnNB+KqGy46rgBSyiJNm8UY55kJ2JfRNG0W MH0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774451767; x=1775056567; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jeZDmS4QXWBXj1GSyJBXJGYP+hGJySEXWFfrbydgUbc=; b=nifHswALaQyNeOu8vD8EZxhXkBOZ92/0y/QC85h1T7GknXZUjyAUHu9wJF9CaGi1xN zN+LESiX761Ien08MnrUrFuTHDgK3I9fpZOV9nQ1IoA3zsMaQrZf/cEI096J9EuszX9e 0Jnugz+PW+BC7r+C2eIfHhhcMmfBAPQiKXmOxdMT4USBNTPk39HjLDYz179dL1OZN7cZ ykiSpHT4zzO22PQvUjNJXJJeZ4tUXXI8S/DOyeF2lN2u9V4TPoOseD24yXLwWJZbHdz5 q8Hda3dxVJvFnH+ylnRo9FF9M01YB5s+MbL28OETZhOU0f0oj8OWnavxnzk4aUuYIGJ2 U07Q== X-Forwarded-Encrypted: i=1; AJvYcCW8SH+7muMAtgD5H03Xz6sCRvcmC+mmfIRZOhKvPzejmzjoZfQHcjOSoDJJj1nAg12tc9qqzZqw9dW7FpI=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ5muB4Kut0QCvhVebp1Gp1mjMz8tLnMOJM8yAhq3HybO/IGPr FCIWEFg3JIy2lxURDp6gq14HihvMzP479oD/EpdE+fiPU2ugL92E1vphkLJzufb1f6E= X-Gm-Gg: ATEYQzx6KMtGNdV6wDWPHA6vw2wSJ6otnIclQpE8XP9ci9Ru8JwpOQilmmOodQiwXQ0 LKSft+dbSER9SmK9Lw97E1m/ZdsCgbFc7Ydw6Jh445oCf5t44Yj25ouAUM0DUGywQZ/1fe9QkDb I/qRawHHw5RpPH6Y3dmutQ3MuXM+hc7mntr6ZvQHVN8I/RPrpYDo03ZDk2Z9lFHnCIDAwm2lhxP nyrm1dcjiJ5D1Znbb3lrb5/yn/EQADYQId6oqgjIIkNcf2E/BsXp9iPRGIFwEhzMIaspohAhVav jaR8eNgOmNV1k8rDG1fhIiMIXtey0ZD2Zw4/chux3YAH8x7f7ClLUMVobTisjbaZQbO5qLebUiu xew7PYn28jPt2+uJaE/YyBBLB5I/8zoeLfyxmW1aS3R5ELVI4xEXey8cXIiPC/QEUid/XNOXEvB R9+hBXGKlv7H1xd692BJ+Eu7Ve2NnQ9OFGrWi+ X-Received: by 2002:a17:907:619b:b0:b98:1129:51 with SMTP id a640c23a62f3a-b9a3f1abe69mr195370666b.17.1774451767271; Wed, 25 Mar 2026 08:16:07 -0700 (PDT) Received: from [192.168.0.167] ([109.76.163.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9832f440e7sm800025966b.3.2026.03.25.08.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 08:16:06 -0700 (PDT) Message-ID: <2c5b8402-6036-43b9-bda3-aeee0c6a9d7d@linaro.org> Date: Wed, 25 Mar 2026 15:16:03 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/7] media: iris: switch to hardware mode after firmware boot To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , Conor Dooley , Saravana Kannan , Joerg Roedel , Will Deacon , Robin Murphy , Stefan Schmidt , Hans Verkuil , Krzysztof Kozlowski , Vishnu Reddy , Hans Verkuil Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev References: <20260313-kaanapali-iris-v3-0-9c0d1a67af4b@oss.qualcomm.com> <20260313-kaanapali-iris-v3-2-9c0d1a67af4b@oss.qualcomm.com> <7dbf7a23-7a02-4e9e-99c8-6716e3dcf7d9@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <7dbf7a23-7a02-4e9e-99c8-6716e3dcf7d9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/03/2026 15:14, Vikash Garodia wrote: > > On 3/13/2026 6:49 PM, Vikash Garodia wrote: >> Currently the driver switches the vcodec GDSC to hardware (HW) mode >> before firmware load and boot sequence. GDSC can be powered off, keeping >> in hw mode, thereby the vcodec registers programmed in TrustZone (TZ) >> carry default (reset) values. >> Move the transition to HW mode after firmware load and boot sequence. >> >> The bug was exposed with driver configuring different stream ids to >> different devices via iommu-map. With registers carrying reset values, >> VPU would not generate desired stream-id, thereby leading to SMMU fault. >> >> For vpu4, when GDSC is switched to HW mode, there is a need to perform >> the reset operation. Without reset, there are occassional issues of >> register corruption observed. Hence the vpu GDSC switch also involves >> the reset. >> >> Fixes: dde659d37036 ("media: iris: Introduce vpu ops for vpu4 with >> necessary hooks") >> Co-developed-by: Vishnu Reddy >> Signed-off-by: Vishnu Reddy >> Signed-off-by: Vikash Garodia >> --- > > Hi Bryan, > > Please pull this fix patch, let me know if you need me to resend this > separately. > > Regards, > Vikash np --- bod